mbox series

[net-next,0/2] Document PolarFire SoC can controller

Message ID 20220607065459.2035746-1-conor.dooley@microchip.com (mailing list archive)
Headers show
Series Document PolarFire SoC can controller | expand

Message

Conor Dooley June 7, 2022, 6:54 a.m. UTC
Hey,
When adding the dts for PolarFire SoC, the can controllers were omitted,
so here they are...

Thanks,
Conor.

Conor Dooley (2):
  dt-bindings: can: mpfs: document the mpfs can controller
  riscv: dts: microchip: add mpfs's can controllers

 .../bindings/net/can/microchip,mpfs-can.yaml  | 45 +++++++++++++++++++
 .../boot/dts/microchip/microchip-mpfs.dtsi    | 18 ++++++++
 2 files changed, 63 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml

Comments

Marc Kleine-Budde June 7, 2022, 7:15 a.m. UTC | #1
On 07.06.2022 07:54:58, Conor Dooley wrote:
> When adding the dts for PolarFire SoC, the can controllers were
                                             ^^^
> omitted, so here they are...

Nitpick:
Consider writing "CAN" in capital letters to avoid confusion for the not
informed reader.

Is the documentation for the CAN controller openly available? Is there a
driver somewhere?

Marc
Conor Dooley June 7, 2022, 7:52 a.m. UTC | #2
On 07/06/2022 08:15, Marc Kleine-Budde wrote:
> On 07.06.2022 07:54:58, Conor Dooley wrote:
>> When adding the dts for PolarFire SoC, the can controllers were
>                                               ^^^
>> omitted, so here they are...
> 
> Nitpick:
> Consider writing "CAN" in capital letters to avoid confusion for the not
> informed reader.

Yeah, sure. I'll try to get over my fear of capital letters ;)

> 
> Is the documentation for the CAN controller openly available? Is there a
> driver somewhere?

There is a driver /but/ for now only a UIO one so I didn't send it.
There's an online doc & if the horrible link doesn't drop you there
directly, its section 6.12.3:
https://onlinedocs.microchip.com/pr/GUID-0E320577-28E6-4365-9BB8-9E1416A0A6E4-en-US-3/index.html?GUID-A362DC3C-83B7-4441-BECB-B19F9AD48B66

And a PDF direct download here, see section 4.12.3 (page 72):
https://www.microsemi.com/document-portal/doc_download/1245725-polarfire-soc-fpga-mss-technical-reference-manual

Thanks,
Conor.
Marc Kleine-Budde June 7, 2022, 8:28 a.m. UTC | #3
On 07.06.2022 07:52:30, Conor.Dooley@microchip.com wrote:
> On 07/06/2022 08:15, Marc Kleine-Budde wrote:
> > On 07.06.2022 07:54:58, Conor Dooley wrote:
> >> When adding the dts for PolarFire SoC, the can controllers were
> >                                             ^^^
> >> omitted, so here they are...
> > 
> > Nitpick:
> > Consider writing "CAN" in capital letters to avoid confusion for the not
> > informed reader.
> 
> Yeah, sure. I'll try to get over my fear of capital letters ;)

:)

> > Is the documentation for the CAN controller openly available? Is there a
> > driver somewhere?
> 
> There is a driver /but/ for now only a UIO one so I didn't send it.

Brrrrr...

> There's an online doc & if the horrible link doesn't drop you there
> directly, its section 6.12.3:
> https://onlinedocs.microchip.com/pr/GUID-0E320577-28E6-4365-9BB8-9E1416A0A6E4-en-US-3/index.html?GUID-A362DC3C-83B7-4441-BECB-B19F9AD48B66
> 
> And a PDF direct download here, see section 4.12.3 (page 72):
> https://www.microsemi.com/document-portal/doc_download/1245725-polarfire-soc-fpga-mss-technical-reference-manual

Thanks. The documentation is quite sparse, is there a more detailed one?
The register map cannot be downloaded directly anymore. For reference:

http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map

regards,
Marc
Conor Dooley June 7, 2022, 8:54 a.m. UTC | #4
On 07/06/2022 09:28, Marc Kleine-Budde wrote:
> On 07.06.2022 07:52:30, Conor.Dooley@microchip.com wrote:
>> On 07/06/2022 08:15, Marc Kleine-Budde wrote:
>>> On 07.06.2022 07:54:58, Conor Dooley wrote:
>>>> When adding the dts for PolarFire SoC, the can controllers were
>>>                                              ^^^
>>>> omitted, so here they are...
>>>
>>> Nitpick:
>>> Consider writing "CAN" in capital letters to avoid confusion for the not
>>> informed reader.
>>
>> Yeah, sure. I'll try to get over my fear of capital letters ;)
> 
> :)
> 
>>> Is the documentation for the CAN controller openly available? Is there a
>>> driver somewhere?
>>
>> There is a driver /but/ for now only a UIO one so I didn't send it.
> 
> Brrrrr...

Yeah, I know..

> 
>> There's an online doc & if the horrible link doesn't drop you there
>> directly, its section 6.12.3:
>> https://onlinedocs.microchip.com/pr/GUID-0E320577-28E6-4365-9BB8-9E1416A0A6E4-en-US-3/index.html?GUID-A362DC3C-83B7-4441-BECB-B19F9AD48B66
>>
>> And a PDF direct download here, see section 4.12.3 (page 72):
>> https://www.microsemi.com/document-portal/doc_download/1245725-polarfire-soc-fpga-mss-technical-reference-manual
> 
> Thanks. The documentation is quite sparse, is there a more detailed one?

Nope, that's all I've got...

> The register map cannot be downloaded directly anymore. For reference:
> 
> http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map

Oh that sucks. I know we have had some website issues over the weekend
which might be the problem there. I'll try to bring it up and find out.

> 
> regards,
> Marc
>
Conor Dooley June 13, 2022, 12:52 p.m. UTC | #5
On 07/06/2022 09:54, Conor.Dooley@microchip.com wrote:
> On 07/06/2022 09:28, Marc Kleine-Budde wrote:
>> On 07.06.2022 07:52:30, Conor.Dooley@microchip.com wrote:
>>> On 07/06/2022 08:15, Marc Kleine-Budde wrote:
>>>> On 07.06.2022 07:54:58, Conor Dooley wrote:
>>>>> When adding the dts for PolarFire SoC, the can controllers were
>>>>                                               ^^^
>>>>> omitted, so here they are...
>>>>
>>>> Nitpick:
>>>> Consider writing "CAN" in capital letters to avoid confusion for the not
>>>> informed reader.
>>>
>>> Yeah, sure. I'll try to get over my fear of capital letters ;)
>>
>> :)
>>
>>>> Is the documentation for the CAN controller openly available? Is there a
>>>> driver somewhere?
>>>
>>> There is a driver /but/ for now only a UIO one so I didn't send it.
>>
>> Brrrrr...
> 
> Yeah, I know..
> 
>>
>>> There's an online doc & if the horrible link doesn't drop you there
>>> directly, its section 6.12.3:
>>> https://onlinedocs.microchip.com/pr/GUID-0E320577-28E6-4365-9BB8-9E1416A0A6E4-en-US-3/index.html?GUID-A362DC3C-83B7-4441-BECB-B19F9AD48B66
>>>
>>> And a PDF direct download here, see section 4.12.3 (page 72):
>>> https://www.microsemi.com/document-portal/doc_download/1245725-polarfire-soc-fpga-mss-technical-reference-manual
>>
>> Thanks. The documentation is quite sparse, is there a more detailed one?
> 
> Nope, that's all I've got...
> 
>> The register map cannot be downloaded directly anymore. For reference:
>>
>> http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map
> 
> Oh that sucks. I know we have had some website issues over the weekend
> which might be the problem there. I'll try to bring it up and find out.
> 

Hey Marc,
Doc is still not available but should be getting fixed.
What do I need to do for this binding? Are you happy to accept it without
a driver if I add links to the documentation and a working link to the
register map?
Thanks,
Conor.
Marc Kleine-Budde June 13, 2022, 1:45 p.m. UTC | #6
On 13.06.2022 12:52:00, Conor.Dooley@microchip.com wrote:
> >> The register map cannot be downloaded directly anymore. For reference:
> >>
> >> http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map
> > 
> > Oh that sucks. I know we have had some website issues over the weekend
> > which might be the problem there. I'll try to bring it up and find out.
> > 
> 
> Hey Marc,
> Doc is still not available but should be getting fixed.

Thanks.

> What do I need to do for this binding? Are you happy to accept it without
> a driver if I add links to the documentation and a working link to the
> register map?

I'm taking both patches and change the CAN into capital letters while
applying, I'll also add a link to the datasheets.

regards,
Marc
Conor Dooley June 13, 2022, 1:48 p.m. UTC | #7
On 13/06/2022 14:45, Marc Kleine-Budde wrote:
> On 13.06.2022 12:52:00, Conor.Dooley@microchip.com wrote:
>>>> The register map cannot be downloaded directly anymore. For reference:
>>>>
>>>> http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map
>>>
>>> Oh that sucks. I know we have had some website issues over the weekend
>>> which might be the problem there. I'll try to bring it up and find out.
>>>
>>
>> Hey Marc,
>> Doc is still not available but should be getting fixed.
> 
> Thanks.
> 
>> What do I need to do for this binding? Are you happy to accept it without
>> a driver if I add links to the documentation and a working link to the
>> register map?
> 
> I'm taking both patches and change the CAN into capital letters while
> applying, I'll also add a link to the datasheets.

Cool, SGTM.
Thanks,
Conor.