[v12,0/2] Hey Uwe, all,

Message

Conor Dooley Nov. 10, 2022, 9:35 a.m. UTC

I've dropped the first two patches, as I applied them last night to my
tree, so just the driver & maintainers change here now.

The pre 6.0-rc1 cover letter/series is here:
https://lore.kernel.org/linux-pwm/[e-mail]

Thanks,
Conor.

Changes since v11:
- swap a "bare" multiply & divide for the corresponding helper to
  prevent overflow
- factor out duplicate clk rate acquisition & period calculation
- make the period calculation return void by checking the validity of
  the clock rate in the caller

Changes since v10:
- reword some comments
- try to assign the period if a disable is requested
- drop a cast around a u8 -> u16 conversion
- fix a check on period_steps that should be on the hw_ variant
- split up the period calculation in get_state() to fix the result on
  32 bit
- add a rate variable in get_state() to only call get_rate() once
- redo the locking as suggested to make it more straightforward.
- stop checking for enablement in get_state() that was working around
 intended behaviour of the sysfs interface

Changes since v9:
- fixed the missing unlock that Dan reported

Changes since v8:
- fixed a(nother) raw 64 bit division (& built it for riscv32!)
- added a check to make sure we don't try to sleep for 0 us

Changes since v7:
- rebased on 6.0-rc1
- reworded comments you highlighted in v7
- fixed the overkill sleeping
- removed the unused variables in calc_duty
- added some extra comments to explain behaviours you questioned in v7
- make the mutexes un-interruptible
- fixed added the 1s you suggested for the if(period_locked) logic
- added setup of the channel_enabled shadowing
- fixed the period reporting for the negedge == posedge case in
  get_state() I had to add the enabled check, as otherwise it broke
  setting the period for the first time out of reset.
- added a test for invalid PERIOD_STEPS values, in which case we abort
  if we cannot fix the period

Changes from v6:
- Dropped an unused variable that I'd missed
- Actually check the return values of the mutex lock()s
- Re-rebased on -next for the MAINTAINERS patch (again...)

Changes from v5:
- switched to a mutex b/c we must sleep with the lock taken
- simplified the locking in apply() and added locking to get_state()
- reworked apply() as requested
- removed the loop in the period calculation (thanks Uwe!)
- add a copy of the enable registers in the driver to save on reads.
- remove the second (useless) write to sync_update
- added some missing rounding in get_state()
- couple other minor cleanups as requested in:
https://lore.kernel.org/linux-riscv/[e-mail]/

Changes from v4:
- dropped some accidentally added files

Conor Dooley (2):
  pwm: add microchip soft ip corePWM driver
  MAINTAINERS: add pwm to PolarFire SoC entry

 MAINTAINERS                      |   1 +
 drivers/pwm/Kconfig              |  10 +
 drivers/pwm/Makefile             |   1 +
 drivers/pwm/pwm-microchip-core.c | 389 +++++++++++++++++++++++++++++++
 4 files changed, 401 insertions(+)
 create mode 100644 drivers/pwm/pwm-microchip-core.c

Comments

Conor Dooley Nov. 10, 2022, 9:38 a.m. UTC | #1

On 10/11/2022 09:35, Conor Dooley wrote:
>Re: [PATCH v12 0/2] Hey Uwe, all,

--cover-from-description=auto mistake, apologies.

Correct subject should have been: "Microchip soft ip corePWM driver".


> I've dropped the first two patches, as I applied them last night to my
> tree, so just the driver & maintainers change here now.
> 
> The pre 6.0-rc1 cover letter/series is here:
> https://lore.kernel.org/linux-pwm/[e-mail]
> 
> Thanks,
> Conor.
> 
> Changes since v11:
> - swap a "bare" multiply & divide for the corresponding helper to
>    prevent overflow
> - factor out duplicate clk rate acquisition & period calculation
> - make the period calculation return void by checking the validity of
>    the clock rate in the caller
> 
> Changes since v10:
> - reword some comments
> - try to assign the period if a disable is requested
> - drop a cast around a u8 -> u16 conversion
> - fix a check on period_steps that should be on the hw_ variant
> - split up the period calculation in get_state() to fix the result on
>    32 bit
> - add a rate variable in get_state() to only call get_rate() once
> - redo the locking as suggested to make it more straightforward.
> - stop checking for enablement in get_state() that was working around
>   intended behaviour of the sysfs interface
> 
> Changes since v9:
> - fixed the missing unlock that Dan reported
> 
> Changes since v8:
> - fixed a(nother) raw 64 bit division (& built it for riscv32!)
> - added a check to make sure we don't try to sleep for 0 us
> 
> Changes since v7:
> - rebased on 6.0-rc1
> - reworded comments you highlighted in v7
> - fixed the overkill sleeping
> - removed the unused variables in calc_duty
> - added some extra comments to explain behaviours you questioned in v7
> - make the mutexes un-interruptible
> - fixed added the 1s you suggested for the if(period_locked) logic
> - added setup of the channel_enabled shadowing
> - fixed the period reporting for the negedge == posedge case in
>    get_state() I had to add the enabled check, as otherwise it broke
>    setting the period for the first time out of reset.
> - added a test for invalid PERIOD_STEPS values, in which case we abort
>    if we cannot fix the period
> 
> Changes from v6:
> - Dropped an unused variable that I'd missed
> - Actually check the return values of the mutex lock()s
> - Re-rebased on -next for the MAINTAINERS patch (again...)
> 
> Changes from v5:
> - switched to a mutex b/c we must sleep with the lock taken
> - simplified the locking in apply() and added locking to get_state()
> - reworked apply() as requested
> - removed the loop in the period calculation (thanks Uwe!)
> - add a copy of the enable registers in the driver to save on reads.
> - remove the second (useless) write to sync_update
> - added some missing rounding in get_state()
> - couple other minor cleanups as requested in:
> https://lore.kernel.org/linux-riscv/[e-mail]/
> 
> Changes from v4:
> - dropped some accidentally added files
> 
> Conor Dooley (2):
>    pwm: add microchip soft ip corePWM driver
>    MAINTAINERS: add pwm to PolarFire SoC entry
> 
>   MAINTAINERS                      |   1 +
>   drivers/pwm/Kconfig              |  10 +
>   drivers/pwm/Makefile             |   1 +
>   drivers/pwm/pwm-microchip-core.c | 389 +++++++++++++++++++++++++++++++
>   4 files changed, 401 insertions(+)
>   create mode 100644 drivers/pwm/pwm-microchip-core.c
>