mbox series

[v1,0/6] dt-bindings: riscv: cpus: switch to unevaluatedProperties: false

Message ID 20230610-snaking-version-81ae5abb7573@spud (mailing list archive)
Headers show
Series dt-bindings: riscv: cpus: switch to unevaluatedProperties: false | expand

Message

Conor Dooley June 10, 2023, 5:24 p.m. UTC
From: Conor Dooley <conor.dooley@microchip.com>

Do the various bits needed to drop the additionalProperties: true that
we currently have in riscv/cpu.yaml, to permit actually enforcing what
people put in cpus nodes.

CC: Rob Herring <robh+dt@kernel.org>
CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC: Paul Walmsley <paul.walmsley@sifive.com>
CC: Palmer Dabbelt <palmer@dabbelt.com>
CC: linux-riscv@lists.infradead.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org

Conor Dooley (6):
  dt-bindings: riscv: cpus: add a ref the common cpu schema
  dt-bindings: riscv: cpus: allow clocks property
  dt-bindings: riscv: cpus: add a ref to thermal-cooling-cells
  dt-bindings: riscv: cpus: permit operating-points-v2
  dt-bindings: riscv: cpus: document cpu-supply
  dt-bindings: riscv: cpus: switch to unevaluatedProperties: false

 .../devicetree/bindings/riscv/cpus.yaml         | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

Comments

Rob Herring (Arm) June 15, 2023, 5:47 p.m. UTC | #1
On Sat, Jun 10, 2023 at 06:24:47PM +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> Do the various bits needed to drop the additionalProperties: true that
> we currently have in riscv/cpu.yaml, to permit actually enforcing what
> people put in cpus nodes.

Arm needs pretty much all the same properties. I started on adding them 
to cpu.yaml a while back. Let me finish that up.

> 
> CC: Rob Herring <robh+dt@kernel.org>
> CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> CC: Paul Walmsley <paul.walmsley@sifive.com>
> CC: Palmer Dabbelt <palmer@dabbelt.com>
> CC: linux-riscv@lists.infradead.org
> CC: devicetree@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> 
> Conor Dooley (6):
>   dt-bindings: riscv: cpus: add a ref the common cpu schema
>   dt-bindings: riscv: cpus: allow clocks property

I just have 'clocks: true', so if you want to keep this setting it to 1 
clock that's fine. But I imagine that it's just a matter of time until 
someone wants more clocks.

>   dt-bindings: riscv: cpus: add a ref to thermal-cooling-cells
>   dt-bindings: riscv: cpus: permit operating-points-v2
>   dt-bindings: riscv: cpus: document cpu-supply
>   dt-bindings: riscv: cpus: switch to unevaluatedProperties: false
> 
>  .../devicetree/bindings/riscv/cpus.yaml         | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> -- 
> 2.39.2
>
Conor Dooley June 15, 2023, 9:46 p.m. UTC | #2
On Thu, Jun 15, 2023 at 11:47:34AM -0600, Rob Herring wrote:
> On Sat, Jun 10, 2023 at 06:24:47PM +0100, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> > 
> > Do the various bits needed to drop the additionalProperties: true that
> > we currently have in riscv/cpu.yaml, to permit actually enforcing what
> > people put in cpus nodes.
> 
> Arm needs pretty much all the same properties. I started on adding them 
> to cpu.yaml a while back. Let me finish that up.

Cool, I see you've already updated dt-schema. I'll go update mine & cull
whatever is no longer needed here.

> > CC: Rob Herring <robh+dt@kernel.org>
> > CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> > CC: Paul Walmsley <paul.walmsley@sifive.com>
> > CC: Palmer Dabbelt <palmer@dabbelt.com>
> > CC: linux-riscv@lists.infradead.org
> > CC: devicetree@vger.kernel.org
> > CC: linux-kernel@vger.kernel.org
> > 
> > Conor Dooley (6):
> >   dt-bindings: riscv: cpus: add a ref the common cpu schema
> >   dt-bindings: riscv: cpus: allow clocks property
> 
> I just have 'clocks: true', so if you want to keep this setting it to 1 
> clock that's fine. But I imagine that it's just a matter of time until 
> someone wants more clocks.

Yeah, I said something to that affect in the commit message. I don't
doubt that it'll show up at some point, was just enabling the minimum
that I know of SoCs requiring at the moment. "clocks: true" WFM.

Cheers,
Conor.

> >   dt-bindings: riscv: cpus: add a ref to thermal-cooling-cells
> >   dt-bindings: riscv: cpus: permit operating-points-v2
> >   dt-bindings: riscv: cpus: document cpu-supply
> >   dt-bindings: riscv: cpus: switch to unevaluatedProperties: false
> > 
> >  .../devicetree/bindings/riscv/cpus.yaml         | 17 ++++++++++++++++-
> >  1 file changed, 16 insertions(+), 1 deletion(-)
> > 
> > -- 
> > 2.39.2
> >