[v1,0/2] Add ethernet nodes for StarFive JH7110 SoC

Message

Guo Samin July 14, 2023, 10:45 a.m. UTC

This series adds ethernet nodes for StarFive JH7110 RISC-V SoC,
and has been tested on StarFive VisionFive-2 v1.2A and v1.3B SBC boards.

The first patch adds ethernet nodes for jh7110 SoC, the second patch
adds ethernet nodes for visionfive 2 SBCs.

This series relies on xingyu's syscon patch[1].
For more information and support, you can visit RVspace wiki[2].

[1]: https://patchwork.kernel.org/project/linux-riscv/patch/[e-mail]
[2]: https://wiki.rvspace.org


Samin Guo (2):
  riscv: dts: starfive: jh7110: Add ethernet device nodes
  riscv: dts: starfive: visionfive 2: Add configuration of gmac and phy

 .../jh7110-starfive-visionfive-2-v1.2a.dts    | 13 ++++
 .../jh7110-starfive-visionfive-2-v1.3b.dts    | 31 +++++++++
 .../jh7110-starfive-visionfive-2.dtsi         | 34 +++++++++
 arch/riscv/boot/dts/starfive/jh7110.dtsi      | 69 +++++++++++++++++++
 4 files changed, 147 insertions(+)


base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
prerequisite-patch-id: 06c3560d00fe0f65a09c09002b46cd7c1c59facc

Comments

Conor Dooley July 20, 2023, 4:29 p.m. UTC | #1

From: Conor Dooley <[e-mail]>

On Fri, 14 Jul 2023 18:45:19 +0800, Samin Guo wrote:
> This series adds ethernet nodes for StarFive JH7110 RISC-V SoC,
> and has been tested on StarFive VisionFive-2 v1.2A and v1.3B SBC boards.
> 
> The first patch adds ethernet nodes for jh7110 SoC, the second patch
> adds ethernet nodes for visionfive 2 SBCs.
> 
> This series relies on xingyu's syscon patch[1].
> For more information and support, you can visit RVspace wiki[2].
> 
> [...]

Applied to riscv-dt-for-next, thanks!

[1/2] riscv: dts: starfive: jh7110: Add ethernet device nodes
      https://git.kernel.org/conor/c/1ff166c97972
[2/2] riscv: dts: starfive: visionfive 2: Add configuration of gmac and phy
      https://git.kernel.org/conor/c/b15a73c358d1

Thanks,
Conor.

Guo Samin July 21, 2023, 2:09 a.m. UTC | #2

-------- 原始信息 --------
主题: Re: [PATCH v1 0/2] Add ethernet nodes for StarFive JH7110 SoC
From: Conor Dooley <[e-mail]>
收件人: Conor Dooley <[e-mail]>, Rob Herring <[e-mail]>, Krzysztof Kozlowski <[e-mail]>, Paul Walmsley <[e-mail]>, Palmer Dabbelt <[e-mail]>, Albert Ou <[e-mail]>, Hal Feng <[e-mail]>, [e-mail], [e-mail], [e-mail], [e-mail], Samin Guo <[e-mail]>
日期: 2023/7/21

> From: Conor Dooley <[e-mail]>
> 
> On Fri, 14 Jul 2023 18:45:19 +0800, Samin Guo wrote:
>> This series adds ethernet nodes for StarFive JH7110 RISC-V SoC,
>> and has been tested on StarFive VisionFive-2 v1.2A and v1.3B SBC boards.
>>
>> The first patch adds ethernet nodes for jh7110 SoC, the second patch
>> adds ethernet nodes for visionfive 2 SBCs.
>>
>> This series relies on xingyu's syscon patch[1].
>> For more information and support, you can visit RVspace wiki[2].
>>
>> [...]
> 
> Applied to riscv-dt-for-next, thanks!
> 
> [1/2] riscv: dts: starfive: jh7110: Add ethernet device nodes
>       https://git.kernel.org/conor/c/1ff166c97972
> [2/2] riscv: dts: starfive: visionfive 2: Add configuration of gmac and phy
>       https://git.kernel.org/conor/c/b15a73c358d1
> 
> Thanks,
> Conor.


Hi Conor，

Thank you so much！ 

There is a question about the configuration of phy that I would like to consult you.

Latest on motorcomm PHY V5[1]: Follow Rob Herring's advice
motorcomm,rx-xxx-driver-strength Changed to motorcomm,rx-xxx-drv-microamp .
V5 has already received a reviewed-by from Andrew Lunn, and it should not change again.

Should I submit another pacthes based on riscv-dt-for-next? 

[1] https://patchwork.kernel.org/project/netdevbpf/cover/[e-mail]

 
Best regards,
Samin

Conor Dooley July 21, 2023, 5:23 a.m. UTC | #3

On 21 July 2023 03:09:19 IST, Guo Samin <[e-mail]> wrote:
>
>
>-------- 原始信息 --------
>主题: Re: [PATCH v1 0/2] Add ethernet nodes for StarFive JH7110 SoC
>From: Conor Dooley <[e-mail]>
>收件人: Conor Dooley <[e-mail]>, Rob Herring <[e-mail]>, Krzysztof Kozlowski <[e-mail]>, Paul Walmsley <[e-mail]>, Palmer Dabbelt <[e-mail]>, Albert Ou <[e-mail]>, Hal Feng <[e-mail]>, [e-mail], [e-mail], [e-mail], [e-mail], Samin Guo <[e-mail]>
>日期: 2023/7/21
>
>> From: Conor Dooley <[e-mail]>
>> 
>> On Fri, 14 Jul 2023 18:45:19 +0800, Samin Guo wrote:
>>> This series adds ethernet nodes for StarFive JH7110 RISC-V SoC,
>>> and has been tested on StarFive VisionFive-2 v1.2A and v1.3B SBC boards.
>>>
>>> The first patch adds ethernet nodes for jh7110 SoC, the second patch
>>> adds ethernet nodes for visionfive 2 SBCs.
>>>
>>> This series relies on xingyu's syscon patch[1].
>>> For more information and support, you can visit RVspace wiki[2].
>>>
>>> [...]
>> 
>> Applied to riscv-dt-for-next, thanks!
>> 
>> [1/2] riscv: dts: starfive: jh7110: Add ethernet device nodes
>>       https://git.kernel.org/conor/c/1ff166c97972
>> [2/2] riscv: dts: starfive: visionfive 2: Add configuration of gmac and phy
>>       https://git.kernel.org/conor/c/b15a73c358d1
>> 
>> Thanks,
>> Conor.
>
>
>Hi Conor，
>
>Thank you so much！ 
>
>There is a question about the configuration of phy that I would like to consult you.
>
>Latest on motorcomm PHY V5[1]: Follow Rob Herring's advice
>motorcomm,rx-xxx-driver-strength Changed to motorcomm,rx-xxx-drv-microamp .
>V5 has already received a reviewed-by from Andrew Lunn, and it should not change again.
>
>Should I submit another pacthes based on riscv-dt-for-next? 

Huh, dtbs_check passed for these patches,
I didn't realise changes to the motorcomm stuff
were a dep. for this. I'll take a look later.

>
>[1] https://patchwork.kernel.org/project/netdevbpf/cover/[e-mail]
>
> 
>Best regards,
>Samin

Guo Samin July 21, 2023, 7:27 a.m. UTC | #4

-------- 原始信息 --------
主题: Re: [PATCH v1 0/2] Add ethernet nodes for StarFive JH7110 SoC
From: Conor Dooley <[e-mail]>
收件人: Guo Samin <[e-mail]>, Rob Herring <[e-mail]>, Krzysztof Kozlowski <[e-mail]>, Paul Walmsley <[e-mail]>, Palmer Dabbelt <[e-mail]>, Albert Ou <[e-mail]>, Hal Feng <[e-mail]>, [e-mail], [e-mail], [e-mail], [e-mail]
日期: 2023/7/21

> 
> 
> On 21 July 2023 03:09:19 IST, Guo Samin <[e-mail]> wrote:
>>
>>
>> -------- 原始信息 --------
>> 主题: Re: [PATCH v1 0/2] Add ethernet nodes for StarFive JH7110 SoC
>> From: Conor Dooley <[e-mail]>
>> 收件人: Conor Dooley <[e-mail]>, Rob Herring <[e-mail]>, Krzysztof Kozlowski <[e-mail]>, Paul Walmsley <[e-mail]>, Palmer Dabbelt <[e-mail]>, Albert Ou <[e-mail]>, Hal Feng <[e-mail]>, [e-mail], [e-mail], [e-mail], [e-mail], Samin Guo <[e-mail]>
>> 日期: 2023/7/21
>>
>>> From: Conor Dooley <[e-mail]>
>>>
>>> On Fri, 14 Jul 2023 18:45:19 +0800, Samin Guo wrote:
>>>> This series adds ethernet nodes for StarFive JH7110 RISC-V SoC,
>>>> and has been tested on StarFive VisionFive-2 v1.2A and v1.3B SBC boards.
>>>>
>>>> The first patch adds ethernet nodes for jh7110 SoC, the second patch
>>>> adds ethernet nodes for visionfive 2 SBCs.
>>>>
>>>> This series relies on xingyu's syscon patch[1].
>>>> For more information and support, you can visit RVspace wiki[2].
>>>>
>>>> [...]
>>>
>>> Applied to riscv-dt-for-next, thanks!
>>>
>>> [1/2] riscv: dts: starfive: jh7110: Add ethernet device nodes
>>>       https://git.kernel.org/conor/c/1ff166c97972
>>> [2/2] riscv: dts: starfive: visionfive 2: Add configuration of gmac and phy
>>>       https://git.kernel.org/conor/c/b15a73c358d1
>>>
>>> Thanks,
>>> Conor.
>>
>>
>> Hi Conor，
>>
>> Thank you so much！ 
>>
>> There is a question about the configuration of phy that I would like to consult you.
>>
>> Latest on motorcomm PHY V5[1]: Follow Rob Herring's advice
>> motorcomm,rx-xxx-driver-strength Changed to motorcomm,rx-xxx-drv-microamp .
>> V5 has already received a reviewed-by from Andrew Lunn, and it should not change again.
>>
>> Should I submit another pacthes based on riscv-dt-for-next? 
> 
> Huh, dtbs_check passed for these patches,
> I didn't realise changes to the motorcomm stuff
> were a dep. for this. I'll take a look later.
>
Hi Conor,

Thanks for taking the time to follow this.

After discussing with HAL, I have prepared the code and considered adding the following patch to 
Motorcomm's patchsetes v6. (To fix some spelling errors in v5[1])
which will then send patches based on linux-next. What do you think? @Andrew @Conor

[1] https://patchwork.kernel.org/project/netdevbpf/cover/[e-mail]



--- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dts
+++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dts
@@ -28,8 +28,8 @@
        motorcomm,tx-clk-adj-enabled;
        motorcomm,tx-clk-100-inverted;
        motorcomm,tx-clk-1000-inverted;
-       motorcomm,rx-clk-driver-strength = <3970>;
-       motorcomm,rx-data-driver-strength = <2910>;
+       motorcomm,rx-clk-drv-microamp = <3970>;
+       motorcomm,rx-data-drv-microamp = <2910>;
        rx-internal-delay-ps = <1500>;
        tx-internal-delay-ps = <1500>;
 };
@@ -37,8 +37,8 @@
 &phy1 {
        motorcomm,tx-clk-adj-enabled;
        motorcomm,tx-clk-100-inverted;
-       motorcomm,rx-clk-driver-strength = <3970>;
-       motorcomm,rx-data-driver-strength = <2910>;
+       motorcomm,rx-clk-drv-microamp = <3970>;
+       motorcomm,rx-data-drv-microamp = <2910>;
        rx-internal-delay-ps = <300>;
        tx-internal-delay-ps = <0>;
 };


Best regards,
Samin

>>
>> [1] https://patchwork.kernel.org/project/netdevbpf/cover/[e-mail]
>>
>>
>> Best regards,
>> Samin

Conor Dooley July 21, 2023, 9:16 a.m. UTC | #5

On Fri, Jul 21, 2023 at 03:27:33PM +0800, Guo Samin wrote:

> -------- 原始信息 --------
> 主题: Re: [PATCH v1 0/2] Add ethernet nodes for StarFive JH7110 SoC
> From: Conor Dooley <[e-mail]>

> 收件人: Guo Samin <[e-mail]>, Rob Herring <[e-mail]>, Krzysztof Kozlowski <[e-mail]>, Paul Walmsley <[e-mail]>, Palmer Dabbelt <[e-mail]>, Albert Ou <[e-mail]>, Hal Feng <[e-mail]>, [e-mail], [e-mail], [e-mail], [e-mail]
> 日期: 2023/7/21

btw, please try and remove this stuff from your mails.

> > On 21 July 2023 03:09:19 IST, Guo Samin <[e-mail]> wrote:

> >> There is a question about the configuration of phy that I would like to consult you.
> >>
> >> Latest on motorcomm PHY V5[1]: Follow Rob Herring's advice
> >> motorcomm,rx-xxx-driver-strength Changed to motorcomm,rx-xxx-drv-microamp .
> >> V5 has already received a reviewed-by from Andrew Lunn, and it should not change again.
> >>
> >> Should I submit another pacthes based on riscv-dt-for-next? 
> > 
> > Huh, dtbs_check passed for these patches,
> > I didn't realise changes to the motorcomm stuff
> > were a dep. for this. I'll take a look later.

> After discussing with HAL, I have prepared the code and considered adding the following patch to 
> Motorcomm's patchsetes v6. (To fix some spelling errors in v5[1])
> which will then send patches based on linux-next. What do you think? @Andrew @Conor

I think you are better off just sending the dts patch to me, adding a
dts patch that will not apply to net-next to your motorcomm driver series
will only really cause problems for the netdev patchwork automation.

> [1] https://patchwork.kernel.org/project/netdevbpf/cover/[e-mail]

I meant to ack this yesterday, but it wasn't in my dt-binding review
queue. I'll go do that now.

Guo Samin July 21, 2023, 9:35 a.m. UTC | #6

on 2023/7/21 17:16:41, Conor Dooley wrote:
> On Fri, Jul 21, 2023 at 03:27:33PM +0800, Guo Samin wrote:
> 
>> Re: [PATCH v1 0/2] Add ethernet nodes for StarFive JH7110 SoC
>> From: Conor Dooley <[e-mail]>
> 
>> to: Guo Samin <[e-mail]>, Rob Herring <[e-mail]>, Krzysztof Kozlowski <[e-mail]>, Paul Walmsley <[e-mail]>, Palmer Dabbelt <[e-mail]>, Albert Ou <[e-mail]>, Hal Feng <[e-mail]>, [e-mail], [e-mail], [e-mail], [e-mail]
>> data: 2023/7/21
> 
> btw, please try and remove this stuff from your mails.
>

Sure
 
>>> On 21 July 2023 03:09:19 IST, Guo Samin <[e-mail]> wrote:
> 
>>>> There is a question about the configuration of phy that I would like to consult you.
>>>>
>>>> Latest on motorcomm PHY V5[1]: Follow Rob Herring's advice
>>>> motorcomm,rx-xxx-driver-strength Changed to motorcomm,rx-xxx-drv-microamp .
>>>> V5 has already received a reviewed-by from Andrew Lunn, and it should not change again.
>>>>
>>>> Should I submit another pacthes based on riscv-dt-for-next? 
>>>
>>> Huh, dtbs_check passed for these patches,
>>> I didn't realise changes to the motorcomm stuff
>>> were a dep. for this. I'll take a look later.
> 
>> After discussing with HAL, I have prepared the code and considered adding the following patch to 
>> Motorcomm's patchsetes v6. (To fix some spelling errors in v5[1])
>> which will then send patches based on linux-next. What do you think? @Andrew @Conor
> 
> I think you are better off just sending the dts patch to me, adding a
> dts patch that will not apply to net-next to your motorcomm driver series
> will only really cause problems for the netdev patchwork automation.
>

Okay, I'll send you DTS separately.
 
>> [1] https://patchwork.kernel.org/project/netdevbpf/cover/[e-mail]
> 
> I meant to ack this yesterday, but it wasn't in my dt-binding review
> queue. I'll go do that now.


Best regards,
Samin