mbox series

[v2,0/3] RISC-V: Disable DWARF5 with known broken LLVM versions

Message ID 20231205-riscv-restrict-dwarf5-llvm-v2-0-aedf00a382ac@kernel.org (mailing list archive)
Headers show
Series RISC-V: Disable DWARF5 with known broken LLVM versions | expand

Message

Nathan Chancellor Dec. 5, 2023, 11:53 p.m. UTC
Hi all,

This series disables DWARF5 for LLVM versions where it is known to be
broken due to linker relaxation:

https://github.com/llvm/llvm-project/commit/bbc0f99f3bc96f1db16f649fc21dd18e5b0918f6

If I understand correctly, it sounds like GNU binutils has a similar
issue but I am not sure of the status of the fixes and such, so I did
not bother with checking for it but it should be easy to add if so
desired.

---
Changes in v2:
- Added patch 3 with Fangrui's suggested improvements around
  CONFIG_AS_HAS_NON_CONST_LEB128.
- Pick up Fangrui's Reviewed-by on patch 1.
- Link to v1: https://lore.kernel.org/r/20231129-riscv-restrict-dwarf5-llvm-v1-0-ec0d368fb538@kernel.org

---
Nathan Chancellor (3):
      riscv: Hoist linker relaxation disabling logic into Kconfig
      riscv: Restrict DWARF5 when building with LLVM to known working versions
      lib/Kconfig.debug: Update AS_HAS_NON_CONST_LEB128 comment and name

 arch/riscv/Kconfig  | 14 ++++++++++++++
 arch/riscv/Makefile |  4 +---
 lib/Kconfig.debug   | 12 +++++++-----
 3 files changed, 22 insertions(+), 8 deletions(-)
---
base-commit: 2cc14f52aeb78ce3f29677c2de1f06c0e91471ab
change-id: 20231129-riscv-restrict-dwarf5-llvm-a9824bb974cb

Best regards,

Comments

Palmer Dabbelt Jan. 18, 2024, 2:11 a.m. UTC | #1
On Tue, 05 Dec 2023 15:53:49 PST (-0800), nathan@kernel.org wrote:
> Hi all,
>
> This series disables DWARF5 for LLVM versions where it is known to be
> broken due to linker relaxation:
>
> https://github.com/llvm/llvm-project/commit/bbc0f99f3bc96f1db16f649fc21dd18e5b0918f6
>
> If I understand correctly, it sounds like GNU binutils has a similar
> issue but I am not sure of the status of the fixes and such, so I did
> not bother with checking for it but it should be easy to add if so
> desired.

Do you have any more info?  All I know is this add/sub/set mess we've 
got, but that's a cross linking problem.

I queued this up for testing, should show up on for-next soon.  Thanks!

> ---
> Changes in v2:
> - Added patch 3 with Fangrui's suggested improvements around
>   CONFIG_AS_HAS_NON_CONST_LEB128.
> - Pick up Fangrui's Reviewed-by on patch 1.
> - Link to v1: https://lore.kernel.org/r/20231129-riscv-restrict-dwarf5-llvm-v1-0-ec0d368fb538@kernel.org
>
> ---
> Nathan Chancellor (3):
>       riscv: Hoist linker relaxation disabling logic into Kconfig
>       riscv: Restrict DWARF5 when building with LLVM to known working versions
>       lib/Kconfig.debug: Update AS_HAS_NON_CONST_LEB128 comment and name
>
>  arch/riscv/Kconfig  | 14 ++++++++++++++
>  arch/riscv/Makefile |  4 +---
>  lib/Kconfig.debug   | 12 +++++++-----
>  3 files changed, 22 insertions(+), 8 deletions(-)
> ---
> base-commit: 2cc14f52aeb78ce3f29677c2de1f06c0e91471ab
> change-id: 20231129-riscv-restrict-dwarf5-llvm-a9824bb974cb
>
> Best regards,
patchwork-bot+linux-riscv@kernel.org Jan. 20, 2024, 9:09 p.m. UTC | #2
Hello:

This series was applied to riscv/linux.git (fixes)
by Palmer Dabbelt <palmer@rivosinc.com>:

On Tue, 05 Dec 2023 16:53:49 -0700 you wrote:
> Hi all,
> 
> This series disables DWARF5 for LLVM versions where it is known to be
> broken due to linker relaxation:
> 
> https://github.com/llvm/llvm-project/commit/bbc0f99f3bc96f1db16f649fc21dd18e5b0918f6
> 
> [...]

Here is the summary with links:
  - [v2,1/3] riscv: Hoist linker relaxation disabling logic into Kconfig
    https://git.kernel.org/riscv/c/55b71d2ce133
  - [v2,2/3] riscv: Restrict DWARF5 when building with LLVM to known working versions
    https://git.kernel.org/riscv/c/ae84ff9a14a5
  - [v2,3/3] lib/Kconfig.debug: Update AS_HAS_NON_CONST_LEB128 comment and name
    https://git.kernel.org/riscv/c/a4426641f00c

You are awesome, thank you!