mbox series

[RFC,v1,0/2] riscv: Cache Population Code Refactoring for ACPI and DT Support

Message ID 20240129075957.116033-1-jeeheng.sia@starfivetech.com (mailing list archive)
Headers show
Series riscv: Cache Population Code Refactoring for ACPI and DT Support | expand

Message

JeeHeng Sia Jan. 29, 2024, 7:59 a.m. UTC 
This series of patches refactors the cache population function to
seamlessly accommodate both DT and ACPI-based platforms. Additionally,
to streamline the code, the unused parameter in the ci_leaf_init()
function has been removed.

Sia Jee Heng (2):
  riscv: cacheinfo: Remove unused parameter
  riscv: cacheinfo: Refactor populate_cache_leaves()

 arch/riscv/kernel/cacheinfo.c | 50 ++++++++++++++---------------------
 1 file changed, 20 insertions(+), 30 deletions(-)


base-commit: 41bccc98fb7931d63d03f326a746ac4d429c1dd3

Comments

Conor Dooley Jan. 29, 2024, 11:50 a.m. UTC | #1 
On Sun, Jan 28, 2024 at 11:59:55PM -0800, Sia Jee Heng wrote:
> This series of patches refactors the cache population function to
> seamlessly accommodate both DT and ACPI-based platforms. Additionally,
> to streamline the code, the unused parameter in the ci_leaf_init()
> function has been removed.

Why's this an RFC? I don't see any mention of why.

Thanks,
Conor.

> 
> Sia Jee Heng (2):
>   riscv: cacheinfo: Remove unused parameter
>   riscv: cacheinfo: Refactor populate_cache_leaves()
> 
>  arch/riscv/kernel/cacheinfo.c | 50 ++++++++++++++---------------------
>  1 file changed, 20 insertions(+), 30 deletions(-)
> 
> 
> base-commit: 41bccc98fb7931d63d03f326a746ac4d429c1dd3
> -- 
> 2.34.1
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
JeeHeng Sia Jan. 30, 2024, 5:09 a.m. UTC | #2 
> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Monday, January 29, 2024 7:50 PM
> To: JeeHeng Sia <jeeheng.sia@starfivetech.com>
> Cc: linux-kernel@vger.kernel.org; linux-riscv@lists.infradead.org; paul.walmsley@sifive.com; palmer@dabbelt.com;
> aou@eecs.berkeley.edu; sudeep.holla@arm.com; robh@kernel.org; conor.dooley@microchip.com; suagrfillet@gmail.com
> Subject: Re: [RFC v1 0/2] riscv: Cache Population Code Refactoring for ACPI and DT Support
> 
> On Sun, Jan 28, 2024 at 11:59:55PM -0800, Sia Jee Heng wrote:
> > This series of patches refactors the cache population function to
> > seamlessly accommodate both DT and ACPI-based platforms. Additionally,
> > to streamline the code, the unused parameter in the ci_leaf_init()
> > function has been removed.
> 
> Why's this an RFC? I don't see any mention of why.
My bad, I should have mentioned the reason in the cover letter.
Btw, the reason treating this as RFC patch is because I am seeking for more
opinions as it is the first try for riscv acpi based cacheinfo.
> 
> Thanks,
> Conor.
> 
> >
> > Sia Jee Heng (2):
> >   riscv: cacheinfo: Remove unused parameter
> >   riscv: cacheinfo: Refactor populate_cache_leaves()
> >
> >  arch/riscv/kernel/cacheinfo.c | 50 ++++++++++++++---------------------
> >  1 file changed, 20 insertions(+), 30 deletions(-)
> >
> >
> > base-commit: 41bccc98fb7931d63d03f326a746ac4d429c1dd3
> > --
> > 2.34.1
> >
> >
> > _______________________________________________
> > linux-riscv mailing list
> > linux-riscv@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-riscv