| Message ID | 20240627-k1-01-basic-dt-v2-0-cc06c7555f07@gentoo.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | riscv: add initial support for SpacemiT K1 | expand |
On Thu, Jun 27, 2024 at 03:31:14PM +0000, Yixun Lan wrote: > SpacemiT K1 is an ideal chip for some new extension such as RISC-V Vector > 1.0 and Zicond evaluation now. Add initial support for it to allow more > people to participate in building drivers to mainline for it. > > This kernel has been tested upon Banana Pi BPI-F3 board on vendor U-Boot > bootflow generated by Armbian SDK[1] and patched OpenSBI[2] to enable > Zicboz, which does not in the vendor dts on its U-Boot. Then successfully > booted to busybox on initrd with this log[3]. > > As previous discussion in patch v1[4], maintainer expect more basic drivers > ready before really merging it, which would be fine. For other follow-up patches, > that are clk, pinctrl/gpio, reset.. My current goal would target at a headless > system including SD card, emmc, and ethernet. > > P.S: talked to Yangyu, I will help and take care of this patch series, thanks > --- > Changes in v2: > - fix timebase-frequency according to current setting > - add other uart dt nodes, fix input frequency > - introduce new uart compatible for K1 SoC > - add 'k1' prefix to bananapi-f3.dts > - fix k1-clint compatible > - fix some typos > - Link to v1: https://lore.kernel.org/r/tencent_BC64B7B1876F5D10479BD19112F73F262505@qq.com I will take a closer look at this series later, but there's a few patches here missing Acks that I gave alongside some nitpick remarks. Could you look at v1 again and add those to whatever other comments I leave when I take a closer look? Thanks, Conor.
Hi Conor: On 16:39 Thu 27 Jun , Conor Dooley wrote: > On Thu, Jun 27, 2024 at 03:31:14PM +0000, Yixun Lan wrote: > > SpacemiT K1 is an ideal chip for some new extension such as RISC-V Vector > > 1.0 and Zicond evaluation now. Add initial support for it to allow more > > people to participate in building drivers to mainline for it. > > > > This kernel has been tested upon Banana Pi BPI-F3 board on vendor U-Boot > > bootflow generated by Armbian SDK[1] and patched OpenSBI[2] to enable > > Zicboz, which does not in the vendor dts on its U-Boot. Then successfully > > booted to busybox on initrd with this log[3]. > > > > As previous discussion in patch v1[4], maintainer expect more basic drivers > > ready before really merging it, which would be fine. For other follow-up patches, > > that are clk, pinctrl/gpio, reset.. My current goal would target at a headless > > system including SD card, emmc, and ethernet. > > > > P.S: talked to Yangyu, I will help and take care of this patch series, thanks > > --- > > Changes in v2: > > - fix timebase-frequency according to current setting > > - add other uart dt nodes, fix input frequency > > - introduce new uart compatible for K1 SoC > > - add 'k1' prefix to bananapi-f3.dts > > - fix k1-clint compatible > > - fix some typos > > - Link to v1: https://lore.kernel.org/r/tencent_BC64B7B1876F5D10479BD19112F73F262505@qq.com > > I will take a closer look at this series later, but there's a few > patches here missing Acks that I gave alongside some nitpick remarks. > Could you look at v1 again and add those to whatever other comments I > leave when I take a closer look? > sure, thanks for your quick reply, I will do this tomorrow, and potentially wait all reviews, combine all tags I receive in v2, and address them in v3..
On Thu, 27 Jun 2024 15:31:14 +0000, Yixun Lan wrote: > SpacemiT K1 is an ideal chip for some new extension such as RISC-V Vector > 1.0 and Zicond evaluation now. Add initial support for it to allow more > people to participate in building drivers to mainline for it. > > This kernel has been tested upon Banana Pi BPI-F3 board on vendor U-Boot > bootflow generated by Armbian SDK[1] and patched OpenSBI[2] to enable > Zicboz, which does not in the vendor dts on its U-Boot. Then successfully > booted to busybox on initrd with this log[3]. > > As previous discussion in patch v1[4], maintainer expect more basic drivers > ready before really merging it, which would be fine. For other follow-up patches, > that are clk, pinctrl/gpio, reset.. My current goal would target at a headless > system including SD card, emmc, and ethernet. > > P.S: talked to Yangyu, I will help and take care of this patch series, thanks > --- > Changes in v2: > - fix timebase-frequency according to current setting > - add other uart dt nodes, fix input frequency > - introduce new uart compatible for K1 SoC > - add 'k1' prefix to bananapi-f3.dts > - fix k1-clint compatible > - fix some typos > - Link to v1: https://lore.kernel.org/r/tencent_BC64B7B1876F5D10479BD19112F73F262505@qq.com > > Link: https://github.com/BPI-SINOVOIP/armbian-build/tree/v24.04.30 [1] > Link: https://gist.github.com/cyyself/a07096e6e99c949ed13f8fa16d884402 [2] > Link: https://gist.github.com/cyyself/a2201c01f5c8955a119641f97b7d0280 [3] > Link: https://lore.kernel.org/r/20240618-hardwood-footrest-ab5ec5bce3cf@wendy [4] > > To: Rob Herring <robh@kernel.org> > To: Krzysztof Kozlowski <krzk+dt@kernel.org> > To: Conor Dooley <conor+dt@kernel.org> > To: Conor Dooley <conor@kernel.org> > To: Paul Walmsley <paul.walmsley@sifive.com> > To: Palmer Dabbelt <palmer@dabbelt.com> > To: Albert Ou <aou@eecs.berkeley.edu> > To: Daniel Lezcano <daniel.lezcano@linaro.org> > To: Thomas Gleixner <tglx@linutronix.de> > To: Samuel Holland <samuel.holland@sifive.com> > To: Anup Patel <anup@brainfault.org> > To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > To: Jiri Slaby <jirislaby@kernel.org> > To: Lubomir Rintel <lkundrak@v3.sk> > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Palmer Dabbelt <palmer@sifive.com> > Cc: linux-riscv@lists.infradead.org > Cc: linux-serial@vger.kernel.org > Cc: Inochi Amaoto <inochiama@outlook.com> > Cc: Meng Zhang <zhangmeng.kevin@spacemit.com> > > Signed-off-by: Yangyu Chen <cyy@cyyself.name> > Signed-off-by: Yixun Lan <dlan@gentoo.org> > > --- > Yangyu Chen (9): > dt-bindings: vendor-prefixes: add spacemit > dt-bindings: riscv: Add SpacemiT X60 compatibles > dt-bindings: riscv: add SpacemiT K1 bindings > dt-bindings: timer: Add SpacemiT K1 CLINT > dt-bindings: interrupt-controller: Add SpacemiT K1 PLIC > riscv: add SpacemiT SOC family Kconfig support > riscv: dts: add initial SpacemiT K1 SoC device tree > riscv: dts: spacemit: add Banana Pi BPI-F3 board device tree > riscv: defconfig: enable SpacemiT SoC > > Yixun Lan (1): > dt-bindings: serial: 8250: Add SpacemiT K1 uart compatible > > .../interrupt-controller/sifive,plic-1.0.0.yaml | 5 +- > Documentation/devicetree/bindings/riscv/cpus.yaml | 1 + > .../devicetree/bindings/riscv/spacemit.yaml | 24 ++ > Documentation/devicetree/bindings/serial/8250.yaml | 4 +- > .../devicetree/bindings/timer/sifive,clint.yaml | 1 + > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > arch/riscv/Kconfig.socs | 5 + > arch/riscv/boot/dts/Makefile | 1 + > arch/riscv/boot/dts/spacemit/Makefile | 2 + > arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 19 ++ > arch/riscv/boot/dts/spacemit/k1.dtsi | 378 +++++++++++++++++++++ > arch/riscv/configs/defconfig | 1 + > 12 files changed, 441 insertions(+), 2 deletions(-) > --- > base-commit: f2661062f16b2de5d7b6a5c42a9a5c96326b8454 > change-id: 20240626-k1-01-basic-dt-1aa31eeebcd2 > > Best regards, > -- > Yixun Lan <dlan@gentoo.org> > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y spacemit/k1-bananapi-f3.dtb' for 20240627-k1-01-basic-dt-v2-0-cc06c7555f07@gentoo.org: arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dtb: uart@d4017100: $nodename:0: 'uart@d4017100' does not match '^serial(@.*)?$' from schema $id: http://devicetree.org/schemas/serial/8250.yaml# arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dtb: uart@d4017200: $nodename:0: 'uart@d4017200' does not match '^serial(@.*)?$' from schema $id: http://devicetree.org/schemas/serial/8250.yaml# arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dtb: uart@d4017300: $nodename:0: 'uart@d4017300' does not match '^serial(@.*)?$' from schema $id: http://devicetree.org/schemas/serial/8250.yaml# arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dtb: uart@d4017400: $nodename:0: 'uart@d4017400' does not match '^serial(@.*)?$' from schema $id: http://devicetree.org/schemas/serial/8250.yaml# arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dtb: uart@d4017500: $nodename:0: 'uart@d4017500' does not match '^serial(@.*)?$' from schema $id: http://devicetree.org/schemas/serial/8250.yaml# arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dtb: uart@d4017600: $nodename:0: 'uart@d4017600' does not match '^serial(@.*)?$' from schema $id: http://devicetree.org/schemas/serial/8250.yaml# arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dtb: uart@d4017700: $nodename:0: 'uart@d4017700' does not match '^serial(@.*)?$' from schema $id: http://devicetree.org/schemas/serial/8250.yaml# arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dtb: uart@d4017800: $nodename:0: 'uart@d4017800' does not match '^serial(@.*)?$' from schema $id: http://devicetree.org/schemas/serial/8250.yaml#