mbox series

[v4,0/6] Add some validation for vector, vector crypto and fp stuff

Message ID 20250312-abide-pancreas-3576b8c44d2c@spud (mailing list archive)
Headers show
Series Add some validation for vector, vector crypto and fp stuff | expand

Message

Conor Dooley March 12, 2025, 1:11 p.m. UTC
From: Conor Dooley <conor.dooley@microchip.com>

Yo,

This series is partly leveraging Clement's work adding a validate
callback in the extension detection code so that things like checking
for whether a vector crypto extension is usable can be done like:
	has_extension(<vector crypto>)
rather than
	has_vector() && has_extension(<vector crypto>)
which Eric pointed out was a poor design some months ago.

The rest of this is adding some requirements to the bindings that
prevent combinations of extensions disallowed by the ISA.

There's a bunch of over-long lines in here, but I thought that the
over-long lines were clearer than breaking them up.

Cheers,
Conor.

(I've been unintentionally sitting on this for a month, hope I
haven't omitted anything as a result)

v4:
- Zvbb -> vector_crypto_validate()
- remove copy-pasta section of commit messages
- Add commentary justifying !EPROBE_DEFER cases
- EPROBE_DEFER where possible (one instance, zve32x check)

v3:
- rebase on v6.14-rc1
- split vector crypto validation patch into vector validation and vector
  crypto validation
- fix zve64x requiring extension list to match Eric's PR

v2:
- Fix an inverted clause Clément pointed out
- Add Zvbb validation, that I had missed accidentally
- Drop the todo about checking the number of validation rounds,
  I tried in w/ qemu's max cpu and things looked right

CC: Eric Biggers <ebiggers@kernel.org>
CC: Conor Dooley <conor@kernel.org>
CC: Rob Herring <robh@kernel.org>
CC: Krzysztof Kozlowski <krzk+dt@kernel.org>
CC: Paul Walmsley <paul.walmsley@sifive.com>
CC: Palmer Dabbelt <palmer@dabbelt.com>
CC: "Clément Léger" <cleger@rivosinc.com>
CC: Andy Chiu <andybnac@gmail.com>
CC: linux-riscv@lists.infradead.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org

Conor Dooley (6):
  RISC-V: add vector extension validation checks
  RISC-V: add vector crypto extension validation checks
  RISC-V: add f & d extension validation checks
  dt-bindings: riscv: d requires f
  dt-bindings: riscv: add vector sub-extension dependencies
  dt-bindings: riscv: document vector crypto requirements

 .../devicetree/bindings/riscv/extensions.yaml |  85 +++++++++++
 arch/riscv/include/asm/cpufeature.h           |   3 +
 arch/riscv/kernel/cpufeature.c                | 140 +++++++++++++-----
 3 files changed, 190 insertions(+), 38 deletions(-)

Comments

patchwork-bot+linux-riscv@kernel.org April 3, 2025, 4:20 p.m. UTC | #1
Hello:

This series was applied to riscv/linux.git (for-next)
by Alexandre Ghiti <alexghiti@rivosinc.com>:

On Wed, 12 Mar 2025 13:11:43 +0000 you wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> Yo,
> 
> This series is partly leveraging Clement's work adding a validate
> callback in the extension detection code so that things like checking
> for whether a vector crypto extension is usable can be done like:
> 	has_extension(<vector crypto>)
> rather than
> 	has_vector() && has_extension(<vector crypto>)
> which Eric pointed out was a poor design some months ago.
> 
> [...]

Here is the summary with links:
  - [v4,1/6] RISC-V: add vector extension validation checks
    https://git.kernel.org/riscv/c/9324571e9eea
  - [v4,2/6] RISC-V: add vector crypto extension validation checks
    https://git.kernel.org/riscv/c/38077ec8fc11
  - [v4,3/6] RISC-V: add f & d extension validation checks
    https://git.kernel.org/riscv/c/12e7fbb6a84e
  - [v4,4/6] dt-bindings: riscv: d requires f
    https://git.kernel.org/riscv/c/534d813a0620
  - [v4,5/6] dt-bindings: riscv: add vector sub-extension dependencies
    https://git.kernel.org/riscv/c/e9f1d61a5e18
  - [v4,6/6] dt-bindings: riscv: document vector crypto requirements
    https://git.kernel.org/riscv/c/a0d857205756

You are awesome, thank you!