| Message ID | 1588072608-7747-5-git-send-email-sagar.kadam@sifive.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fix macb phy probe failure if phy-reset is not handled | expand |
On Tue, Apr 28, 2020 at 04:16:48AM -0700, Sagar Shrikant Kadam wrote: > Adding a OUI (Organizationally Unique Identifier) for VSC8541-01 > device to dt node requires a corresponding dt-binding entry as well > so that checkpatch doesn't complain with a warning: > > DT compatible string "ethernet-phy-id0007.0771" appears un-documented > > Here extend the existing dt binding of VSC8531 device to include > VSC8541 device example. Checkpatch.pl is just dumb here and can be ignored. We have the regex that documents this compatible. We don't need every VID/PID listed. > > Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com> > --- > Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > index 5ff37c6..774448a 100644 > --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > @@ -68,3 +68,6 @@ Example: > vsc8531,led-0-mode = <LINK_1000_ACTIVITY>; > vsc8531,led-1-mode = <LINK_100_ACTIVITY>; > }; > + vsc8541_0: ethernet-phy@0 { > + compatible = "ethernet-phy-id0007.0771"; > + }; > -- > 2.7.4 >
Hello Rob, > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Tuesday, May 12, 2020 7:42 AM > To: Sagar Kadam <sagar.kadam@sifive.com> > Cc: linux-kernel@vger.kernel.org; linux-riscv@lists.infradead.org; > palmer@dabbelt.com; Paul Walmsley <paul.walmsley@sifive.com>; > atish.patra@wdc.com; devicetree@vger.kernel.org > Subject: Re: [RFC PATCH 4/4] dt-bindings: net: phy: extend dt binding for > VSC8541 ethernet-phy > > [External Email] Do not click links or attachments unless you recognize the > sender and know the content is safe > > On Tue, Apr 28, 2020 at 04:16:48AM -0700, Sagar Shrikant Kadam wrote: > > Adding a OUI (Organizationally Unique Identifier) for VSC8541-01 > > device to dt node requires a corresponding dt-binding entry as well > > so that checkpatch doesn't complain with a warning: > > > > DT compatible string "ethernet-phy-id0007.0771" appears un-documented > > > > Here extend the existing dt binding of VSC8531 device to include > > VSC8541 device example. > > Checkpatch.pl is just dumb here and can be ignored. We have the regex > that documents this compatible. We don't need every VID/PID listed. > Thank you for the information. We can then drop this patch to handle un-documented warning. BR, Sagar Kadam > > > > Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com> > > --- > > Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > > index 5ff37c6..774448a 100644 > > --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > > +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > > @@ -68,3 +68,6 @@ Example: > > vsc8531,led-0-mode = <LINK_1000_ACTIVITY>; > > vsc8531,led-1-mode = <LINK_100_ACTIVITY>; > > }; > > + vsc8541_0: ethernet-phy@0 { > > + compatible = "ethernet-phy-id0007.0771"; > > + }; > > -- > > 2.7.4 > >
diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt index 5ff37c6..774448a 100644 --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt @@ -68,3 +68,6 @@ Example: vsc8531,led-0-mode = <LINK_1000_ACTIVITY>; vsc8531,led-1-mode = <LINK_100_ACTIVITY>; }; + vsc8541_0: ethernet-phy@0 { + compatible = "ethernet-phy-id0007.0771"; + };
Adding a OUI (Organizationally Unique Identifier) for VSC8541-01 device to dt node requires a corresponding dt-binding entry as well so that checkpatch doesn't complain with a warning: DT compatible string "ethernet-phy-id0007.0771" appears un-documented Here extend the existing dt binding of VSC8531 device to include VSC8541 device example. Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com> --- Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 3 +++ 1 file changed, 3 insertions(+)