| Message ID | 20190119055625.100054-3-anup@brainfault.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | IRQ affinity support in PLIC driver | expand |
On Sat, Jan 19, 2019 at 11:26:22AM +0530, Anup Patel wrote: > The plic_toggle() uses raw_spin_lock() and plic_irq_toggle has a > for loop so both these functions are not suitable for being inline > hence this patch removes the inline keyword. I still very much disagree. Very strongly with the above rationale, but also (less strongly) with the decision not to inline here.
On Tue, Feb 12, 2019 at 12:39 PM Christoph Hellwig <hch@infradead.org> wrote: > > On Sat, Jan 19, 2019 at 11:26:22AM +0530, Anup Patel wrote: > > The plic_toggle() uses raw_spin_lock() and plic_irq_toggle has a > > for loop so both these functions are not suitable for being inline > > hence this patch removes the inline keyword. > > I still very much disagree. Very strongly with the above rationale, > but also (less strongly) with the decision not to inline here. No issues. I will drop this patch since you "very much disagree". Regards, Anup
diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c index c23a293a2aae..01bbbbffbcae 100644 --- a/drivers/irqchip/irq-sifive-plic.c +++ b/drivers/irqchip/irq-sifive-plic.c @@ -69,8 +69,8 @@ struct plic_handler { }; static DEFINE_PER_CPU(struct plic_handler, plic_handlers); -static inline void plic_toggle(struct plic_handler *handler, - int hwirq, int enable) +static void plic_toggle(struct plic_handler *handler, + int hwirq, int enable) { u32 __iomem *reg = handler->enable_base + (hwirq / 32) * sizeof(u32); u32 hwirq_mask = 1 << (hwirq % 32); @@ -83,7 +83,7 @@ static inline void plic_toggle(struct plic_handler *handler, raw_spin_unlock(&handler->enable_lock); } -static inline void plic_irq_toggle(struct irq_data *d, int enable) +static void plic_irq_toggle(struct irq_data *d, int enable) { int cpu;
The plic_toggle() uses raw_spin_lock() and plic_irq_toggle has a for loop so both these functions are not suitable for being inline hence this patch removes the inline keyword. Signed-off-by: Anup Patel <anup@brainfault.org> --- drivers/irqchip/irq-sifive-plic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)