| Message ID | 20190211133554.30055-2-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/12] mfd/sm501: depend on HAS_DMA | expand |
On Mon, 11 Feb 2019, Christoph Hellwig wrote: > Currently the sm501 mfd driver can be compiled without any dependencies, > but through the use of dma_declare_coherent it really depends on > having DMA and iomem support. Normally we don't explicitly require DMA > support as we have stubs for it if on UML, but in this case the driver > selects support for dma_declare_coherent and thus also requires > memmap support. Guard this by an explicit dependency. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/mfd/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index f461460a2aeb..f15f6489803d 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1066,6 +1066,7 @@ config MFD_SI476X_CORE > > config MFD_SM501 > tristate "Silicon Motion SM501" > + depends on HAS_DMA > ---help--- > This is the core driver for the Silicon Motion SM501 multimedia > companion chip. This device is a multifunction device which may I would normally have taken this, but I fear it will conflict with [PATCH 06/12]. For that reason, just take my: Acked-by: Lee Jones <lee.jones@linaro.org>
On Wed, Feb 13, 2019 at 07:29:31AM +0000, Lee Jones wrote: > I would normally have taken this, but I fear it will conflict with > [PATCH 06/12]. For that reason, just take my: > > Acked-by: Lee Jones <lee.jones@linaro.org> Yes, I'll need it for the later patches in the series. Thanks for the review.
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index f461460a2aeb..f15f6489803d 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -1066,6 +1066,7 @@ config MFD_SI476X_CORE config MFD_SM501 tristate "Silicon Motion SM501" + depends on HAS_DMA ---help--- This is the core driver for the Silicon Motion SM501 multimedia companion chip. This device is a multifunction device which may
Currently the sm501 mfd driver can be compiled without any dependencies, but through the use of dma_declare_coherent it really depends on having DMA and iomem support. Normally we don't explicitly require DMA support as we have stubs for it if on UML, but in this case the driver selects support for dma_declare_coherent and thus also requires memmap support. Guard this by an explicit dependency. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)