| Message ID | 20191028024101.26655-2-nickhu@andestech.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KASAN support for RISC-V | expand |
Hello Andrey, Alexander, Dmitry, On Mon, 28 Oct 2019, Nick Hu wrote: > If archs don't have memmove then the C implementation from lib/string.c is used, > and then it's instrumented by compiler. So there is no need to add KASAN's > memmove to manual checks. > > Signed-off-by: Nick Hu <nickhu@andestech.com> If you're happy with this revision of this patch, could you please ack it so we can merge it as part of the RISC-V KASAN patch set? Or if you'd prefer to take this patch yourself, please let me know. - Paul > --- > mm/kasan/common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 6814d6d6a023..897f9520bab3 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -107,6 +107,7 @@ void *memset(void *addr, int c, size_t len) > return __memset(addr, c, len); > } > > +#ifdef __HAVE_ARCH_MEMMOVE > #undef memmove > void *memmove(void *dest, const void *src, size_t len) > { > @@ -115,6 +116,7 @@ void *memmove(void *dest, const void *src, size_t len) > > return __memmove(dest, src, len); > } > +#endif > > #undef memcpy > void *memcpy(void *dest, const void *src, size_t len) > -- > 2.17.0 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv > - Paul
On Sun, Nov 17, 2019 at 5:58 AM Paul Walmsley <paul.walmsley@sifive.com> wrote: > > Hello Andrey, Alexander, Dmitry, > > On Mon, 28 Oct 2019, Nick Hu wrote: > > > If archs don't have memmove then the C implementation from lib/string.c is used, > > and then it's instrumented by compiler. So there is no need to add KASAN's > > memmove to manual checks. > > > > Signed-off-by: Nick Hu <nickhu@andestech.com> > > If you're happy with this revision of this patch, could you please ack it > so we can merge it as part of the RISC-V KASAN patch set? > > Or if you'd prefer to take this patch yourself, please let me know. Hi Paul, Acked-by: Dmitry Vyukov <dvyukov@google.com> We don't have separate tree for kasan. Merging this via RISC-V tree should be fine. Thanks > - > > > --- > > mm/kasan/common.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > > index 6814d6d6a023..897f9520bab3 100644 > > --- a/mm/kasan/common.c > > +++ b/mm/kasan/common.c > > @@ -107,6 +107,7 @@ void *memset(void *addr, int c, size_t len) > > return __memset(addr, c, len); > > } > > > > +#ifdef __HAVE_ARCH_MEMMOVE > > #undef memmove > > void *memmove(void *dest, const void *src, size_t len) > > { > > @@ -115,6 +116,7 @@ void *memmove(void *dest, const void *src, size_t len) > > > > return __memmove(dest, src, len); > > } > > +#endif > > > > #undef memcpy > > void *memcpy(void *dest, const void *src, size_t len) > > -- > > 2.17.0 > > > > > > _______________________________________________ > > linux-riscv mailing list > > linux-riscv@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-riscv > > > > > - Paul
On 10/28/19 5:40 AM, Nick Hu wrote: > If archs don't have memmove then the C implementation from lib/string.c is used, > and then it's instrumented by compiler. So there is no need to add KASAN's > memmove to manual checks. > > Signed-off-by: Nick Hu <nickhu@andestech.com> > --- Acked-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
diff --git a/mm/kasan/common.c b/mm/kasan/common.c index 6814d6d6a023..897f9520bab3 100644 --- a/mm/kasan/common.c +++ b/mm/kasan/common.c @@ -107,6 +107,7 @@ void *memset(void *addr, int c, size_t len) return __memset(addr, c, len); } +#ifdef __HAVE_ARCH_MEMMOVE #undef memmove void *memmove(void *dest, const void *src, size_t len) { @@ -115,6 +116,7 @@ void *memmove(void *dest, const void *src, size_t len) return __memmove(dest, src, len); } +#endif #undef memcpy void *memcpy(void *dest, const void *src, size_t len)
If archs don't have memmove then the C implementation from lib/string.c is used, and then it's instrumented by compiler. So there is no need to add KASAN's memmove to manual checks. Signed-off-by: Nick Hu <nickhu@andestech.com> --- mm/kasan/common.c | 2 ++ 1 file changed, 2 insertions(+)