diff mbox series

[1/2] riscv: dts: unleashed: Add gpio card detect to mmc-spi-slot

Message ID 20210616074645.429578-1-bmeng.cn@gmail.com (mailing list archive)
State New, archived
Headers show
Series [1/2] riscv: dts: unleashed: Add gpio card detect to mmc-spi-slot | expand

Commit Message

Bin Meng June 16, 2021, 7:46 a.m. UTC
From: Bin Meng <bin.meng@windriver.com>

Per HiFive Unleashed schematics, the card detect signal of the
micro SD card is connected to gpio pin #11, which should be
reflected in the DT via the <gpios> property, as described in
Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt.

[1] https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf

Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

 arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Bin Meng July 8, 2021, 1:40 p.m. UTC | #1
On Wed, Jun 16, 2021 at 3:46 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bin.meng@windriver.com>
>
> Per HiFive Unleashed schematics, the card detect signal of the
> micro SD card is connected to gpio pin #11, which should be
> reflected in the DT via the <gpios> property, as described in
> Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt.
>
> [1] https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
>  arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 +
>  1 file changed, 1 insertion(+)
>

Ping?
Palmer Dabbelt Nov. 24, 2021, 4:58 p.m. UTC | #2
On Thu, 08 Jul 2021 06:40:03 PDT (-0700), bmeng.cn@gmail.com wrote:
> On Wed, Jun 16, 2021 at 3:46 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>>
>> From: Bin Meng <bin.meng@windriver.com>
>>
>> Per HiFive Unleashed schematics, the card detect signal of the
>> micro SD card is connected to gpio pin #11, which should be
>> reflected in the DT via the <gpios> property, as described in
>> Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt.
>>
>> [1] https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf
>>
>> Signed-off-by: Bin Meng <bin.meng@windriver.com>
>> ---
>>
>>  arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 +
>>  1 file changed, 1 insertion(+)
>>
>
> Ping?

Sorry I missed these, and thanks to David for pointing them out.  
They're on fixes.
diff mbox series

Patch

diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
index 60846e88ae4b..22f971e97161 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
@@ -80,6 +80,7 @@  mmc@0 {
 		spi-max-frequency = <20000000>;
 		voltage-ranges = <3300 3300>;
 		disable-wp;
+		gpios = <&gpio 11 GPIO_ACTIVE_LOW>;
 	};
 };