diff mbox series

[1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1

Message ID 20210702014319.1265766-1-bmeng.cn@gmail.com (mailing list archive)
State New, archived
Headers show
Series [1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1 | expand

Commit Message

Bin Meng July 2, 2021, 1:43 a.m. UTC
From: Bin Meng <bin.meng@windriver.com>

Per the DT spec, 'local-mac-address' is used to specify MAC address
that was assigned to the network device, while 'mac-address' is used
to specify the MAC address that was last used by the boot program,
and shall be used only if the value differs from 'local-mac-address'
property value.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

 arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bin Meng July 8, 2021, 1:40 p.m. UTC | #1
On Fri, Jul 2, 2021 at 9:42 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bin.meng@windriver.com>
>
> Per the DT spec, 'local-mac-address' is used to specify MAC address
> that was assigned to the network device, while 'mac-address' is used
> to specify the MAC address that was last used by the boot program,
> and shall be used only if the value differs from 'local-mac-address'
> property value.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
>  arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Ping?
Conor Dooley July 9, 2021, 9:20 a.m. UTC | #2
On 08/07/2021 14:40, Bin Meng wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Fri, Jul 2, 2021 at 9:42 AM Bin Meng<bmeng.cn@gmail.com>  wrote:
>> From: Bin Meng<bin.meng@windriver.com>
>>
>> Per the DT spec, 'local-mac-address' is used to specify MAC address
>> that was assigned to the network device, while 'mac-address' is used
>> to specify the MAC address that was last used by the boot program,
>> and shall be used only if the value differs from 'local-mac-address'
>> property value.
>>
>> Signed-off-by: Bin Meng<bin.meng@windriver.com>
>> ---
>>
>>   arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
> Ping?
Yeah, thats fine.
Reviewed-by: conor dooley <conor.dooley@microchip.com>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
diff mbox series

Patch

diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
index 0659068b62f7..a9c558366d61 100644
--- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
+++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
@@ -317,7 +317,7 @@  emac1: ethernet@20112000 {
 			reg = <0x0 0x20112000 0x0 0x2000>;
 			interrupt-parent = <&plic>;
 			interrupts = <70 71 72 73>;
-			mac-address = [00 00 00 00 00 00];
+			local-mac-address = [00 00 00 00 00 00];
 			clocks = <&clkcfg 5>, <&clkcfg 2>;
 			status = "disabled";
 			clock-names = "pclk", "hclk";