| Message ID | 20211012153432.2817285-1-guoren@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V2,1/2] dt-bindings: update riscv plic compatible string | expand |
Hi, Am Dienstag, 12. Oktober 2021, 17:34:31 CEST schrieb guoren@kernel.org: > From: Guo Ren <guoren@linux.alibaba.com> > > Add the compatible string "thead,c9xx-plic" to the riscv plic > bindings to support SOCs with thead,c9xx processor cores. > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > Cc: Rob Herring <robh@kernel.org> > Cc: Palmer Dabbelt <palmerdabbelt@google.com> > Cc: Anup Patel <anup@brainfault.org> > Cc: Atish Patra <atish.patra@wdc.com> > --- > .../bindings/interrupt-controller/sifive,plic-1.0.0.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > index 08d5a57ce00f..202eb7666f9b 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > @@ -46,6 +46,7 @@ properties: > - enum: > - sifive,fu540-c000-plic > - canaan,k210-plic > + - thead,c9xx-plic Devicetree bindings shouldn't use asterisks (the xx-part). Instead you want (probably) + - thead,c906-plic + - thead,c910-plic to name the specific SoCs that plic is used on Heiko > - const: sifive,plic-1.0.0 > > reg: >
On Tue, Oct 12, 2021 at 8:35 AM <guoren@kernel.org> wrote: > > From: Guo Ren <guoren@linux.alibaba.com> > > Add the compatible string "thead,c9xx-plic" to the riscv plic > bindings to support SOCs with thead,c9xx processor cores. > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > Cc: Rob Herring <robh@kernel.org> > Cc: Palmer Dabbelt <palmerdabbelt@google.com> > Cc: Anup Patel <anup@brainfault.org> > Cc: Atish Patra <atish.patra@wdc.com> > --- > .../bindings/interrupt-controller/sifive,plic-1.0.0.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > index 08d5a57ce00f..202eb7666f9b 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > @@ -46,6 +46,7 @@ properties: > - enum: > - sifive,fu540-c000-plic > - canaan,k210-plic > + - thead,c9xx-plic I think it would be better to document the difference between sifive plic and thead plic in the description section. > - const: sifive,plic-1.0.0 > > reg: > -- > 2.25.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
On Tue, Oct 12, 2021 at 11:41 PM Heiko Stübner <heiko@sntech.de> wrote: > > Hi, > > Am Dienstag, 12. Oktober 2021, 17:34:31 CEST schrieb guoren@kernel.org: > > From: Guo Ren <guoren@linux.alibaba.com> > > > > Add the compatible string "thead,c9xx-plic" to the riscv plic > > bindings to support SOCs with thead,c9xx processor cores. > > > > Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > > Cc: Rob Herring <robh@kernel.org> > > Cc: Palmer Dabbelt <palmerdabbelt@google.com> > > Cc: Anup Patel <anup@brainfault.org> > > Cc: Atish Patra <atish.patra@wdc.com> > > --- > > .../bindings/interrupt-controller/sifive,plic-1.0.0.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > > index 08d5a57ce00f..202eb7666f9b 100644 > > --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > > +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > > @@ -46,6 +46,7 @@ properties: > > - enum: > > - sifive,fu540-c000-plic > > - canaan,k210-plic > > + - thead,c9xx-plic > > Devicetree bindings shouldn't use asterisks (the xx-part). > Instead you want (probably) > > + - thead,c906-plic > + - thead,c910-plic Okay, remove xx-part. But I will use thread,c900-plic for all of them. > > to name the specific SoCs that plic is used on > > > Heiko > > > - const: sifive,plic-1.0.0 > > > > reg: > > > > > >
diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml index 08d5a57ce00f..202eb7666f9b 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml @@ -46,6 +46,7 @@ properties: - enum: - sifive,fu540-c000-plic - canaan,k210-plic + - thead,c9xx-plic - const: sifive,plic-1.0.0 reg: