| Message ID | 20220228152658.3367506-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | SoC: polarfire: fix build warning | expand |
I had sent a fix for the build warning on saturday morning - but I guess you missed it. Thanks for fixing it anyway :) Conor. On 28/02/2022 15:26, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The newly added driver causes a build warning because of a missing > prototype: > > drivers/soc/microchip/mpfs-sys-controller.c:76:6: warning: no previous prototype for function 'mpfs_sys_controller_put' [-Wmissing-prototypes] > > Link: https://lore.kernel.org/llvm/202202260947.F5T1YNao-lkp@intel.com/ > Reported-by: kernel test robot <lkp@intel.com> > Fixes: d0054a470c33 ("soc: add microchip polarfire soc system controller") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > I've applied this to the arm/drivers branch as a fixup > > include/soc/microchip/mpfs.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/soc/microchip/mpfs.h b/include/soc/microchip/mpfs.h > index 6466515262bd..969b5239521e 100644 > --- a/include/soc/microchip/mpfs.h > +++ b/include/soc/microchip/mpfs.h > @@ -38,6 +38,8 @@ int mpfs_blocking_transaction(struct mpfs_sys_controller *mpfs_client, struct mp > > struct mpfs_sys_controller *mpfs_sys_controller_get(struct device *dev); > > +void mpfs_sys_controller_put(void *data); > + > #endif /* if IS_ENABLED(CONFIG_POLARFIRE_SOC_SYS_CTRL) */ > > #endif /* __SOC_MPFS_H__ */
On Mon, Feb 28, 2022 at 4:35 PM Conor Dooley <mail@conchuod.ie> wrote: > > I had sent a fix for the build warning on saturday morning - but I guess > you missed it. > > Thanks for fixing it anyway :) Thank you for your quick reply. I had indeed missed that fix. You did the right thing here by sending it to Nicolas, but he hasn't had a chance to forward it to soc@kernel.org yet, so it was not visible in patchwork. As it turns out, your patch is correct and mine was wrong anyway, so I have now replaced my patch with yours. Nicolas, I hope that doesn't cause you extra work. If you have picked it up into your tree, you can drop it again from there. Arnd
On 28/02/2022 at 16:41, Arnd Bergmann wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Mon, Feb 28, 2022 at 4:35 PM Conor Dooley <mail@conchuod.ie> wrote: >> >> I had sent a fix for the build warning on saturday morning - but I guess >> you missed it. >> >> Thanks for fixing it anyway :) > > Thank you for your quick reply. I had indeed missed that fix. You did the > right thing here by sending it to Nicolas, but he hasn't had a chance to forward > it to soc@kernel.org yet, so it was not visible in patchwork. > > As it turns out, your patch is correct and mine was wrong anyway, so I > have now replaced my patch with yours. > > Nicolas, I hope that doesn't cause you extra work. If you have picked it > up into your tree, you can drop it again from there. No problem on my side: I was planning to add it to another PR to you but it's far easier if you already took it directly. Thanks Arnd, best regards, Nicolas
diff --git a/include/soc/microchip/mpfs.h b/include/soc/microchip/mpfs.h index 6466515262bd..969b5239521e 100644 --- a/include/soc/microchip/mpfs.h +++ b/include/soc/microchip/mpfs.h @@ -38,6 +38,8 @@ int mpfs_blocking_transaction(struct mpfs_sys_controller *mpfs_client, struct mp struct mpfs_sys_controller *mpfs_sys_controller_get(struct device *dev); +void mpfs_sys_controller_put(void *data); + #endif /* if IS_ENABLED(CONFIG_POLARFIRE_SOC_SYS_CTRL) */ #endif /* __SOC_MPFS_H__ */