| Message ID | 20221011160744.2167025-1-conor@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | RISC-V Patchwork | expand |
On Tue, 11 Oct 2022 09:07:45 PDT (-0700), Conor Dooley wrote: > Hey, > > As one or two people have already noticed, we've resurrected the > patchwork for the RISC-V list @ > https://patchwork.kernel.org/project/linux-riscv/list/ > > The patchwork bot should let people know when their patches have been > applied. Hopefully it'll help people track what the status of their > patches are a little better and try to prevent stuff falling through > the cracks in Palmer's inbox. > > As an FYI, the statuses that are intended to be used are: > - New: No action has been taken yet > - Under Review: The maintainer is waiting for review comments from others > - Changes Requested: Either the maintainer or a reviewer requested > changes in the patch. The patch author is expected to submit a new > version > - Superseded: There's a new version of the patch available > - Not Applicable: The patch is not intended for the RISC-V tree > - Accepted: The patch has been applied > - Rejected: The patch has been rejected, with reasons stated in an > email > > I reset patchwork and marked all patches as archived so we would have a > fresh start. If your patch has been archived & not applied by the end of > this merge window, feel free to resend it. > > Thanks, > Conor. > > @Palmer: hopefully I did the scissors thing correctly.. b4 doesn't like it, but my old scripts just picked up the whole thing as a patch. I tossed the above bits, LMK if something went off the rails. > > -- >8 -- > From f886e8a9def4bd3f2fa8a0a4d7e92c94fe72ea72 Mon Sep 17 00:00:00 2001 > From: Conor Dooley <conor.dooley@microchip.com> > Date: Tue, 11 Oct 2022 16:49:53 +0100 > Subject: [PATCH] MAINTAINERS: add RISC-V's patchwork > > The RISC-V patchwork instance on kernel.org has had some necromancy > performed on it & will be used going forward. The statuses that are > intended to be used are: > - New: No action has been taken yet > - Under Review: The maintainer is waiting for review comments from others > - Changes Requested: Either the maintainer or a reviewer requested > changes in the patch. The patch author is expected to submit a new > version > - Superseded: There's a new version of the patch available > - Not Applicable: The patch is not intended for the RISC-V tree > - Accepted: The patch has been applied > - Rejected: The patch has been rejected, with reasons stated in an > email > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8a5012ba6ff9..e2882dc703d8 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -17516,6 +17516,7 @@ M: Palmer Dabbelt <palmer@dabbelt.com> > M: Albert Ou <aou@eecs.berkeley.edu> > L: linux-riscv@lists.infradead.org > S: Supported > +Q: https://patchwork.kernel.org/project/linux-riscv/list/ > P: Documentation/riscv/patch-acceptance.rst > T: git git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git > F: arch/riscv/
On Thu, Oct 13, 2022 at 04:14:39PM -0700, Palmer Dabbelt wrote: > On Tue, 11 Oct 2022 09:07:45 PDT (-0700), Conor Dooley wrote: > > Hey, > > > > As one or two people have already noticed, we've resurrected the > > patchwork for the RISC-V list @ > > https://patchwork.kernel.org/project/linux-riscv/list/ > > > > The patchwork bot should let people know when their patches have been > > applied. Hopefully it'll help people track what the status of their > > patches are a little better and try to prevent stuff falling through > > the cracks in Palmer's inbox. > > > > As an FYI, the statuses that are intended to be used are: > > - New: No action has been taken yet > > - Under Review: The maintainer is waiting for review comments from others > > - Changes Requested: Either the maintainer or a reviewer requested > > changes in the patch. The patch author is expected to submit a new > > version > > - Superseded: There's a new version of the patch available > > - Not Applicable: The patch is not intended for the RISC-V tree > > - Accepted: The patch has been applied > > - Rejected: The patch has been rejected, with reasons stated in an > > email > > > > I reset patchwork and marked all patches as archived so we would have a > > fresh start. If your patch has been archived & not applied by the end of > > this merge window, feel free to resend it. > > > > Thanks, > > Conor. > > > > @Palmer: hopefully I did the scissors thing correctly.. > > b4 doesn't like it, but my old scripts just picked up the whole thing as a > patch. I tossed the above bits, LMK if something went off the rails. I just copied the suggested scissors format from the git-mailinfo man page and pasted that. I didn't know this prior to 5 mins ago, but `b4 mbox` splits it on the scissors line, into a patch and an email inside the mbox - but for w/e reason, `git am` (or `b4 shazam`) then seems to try and apply the email instead of the patch? Or else pasting the patch into mutt was a terrible idea? Maybe it's worth mentioning to Konstantin that things get messed up here, I'll do it tomorrow if I remember. Unlikely I'll ever really send many more patches with this format so w/e at the end of the day. Thanks, Conor. > > > > > -- >8 -- > > From f886e8a9def4bd3f2fa8a0a4d7e92c94fe72ea72 Mon Sep 17 00:00:00 2001 > > From: Conor Dooley <conor.dooley@microchip.com> > > Date: Tue, 11 Oct 2022 16:49:53 +0100 > > Subject: [PATCH] MAINTAINERS: add RISC-V's patchwork > > > > The RISC-V patchwork instance on kernel.org has had some necromancy > > performed on it & will be used going forward. The statuses that are > > intended to be used are: > > - New: No action has been taken yet > > - Under Review: The maintainer is waiting for review comments from others > > - Changes Requested: Either the maintainer or a reviewer requested > > changes in the patch. The patch author is expected to submit a new > > version > > - Superseded: There's a new version of the patch available > > - Not Applicable: The patch is not intended for the RISC-V tree > > - Accepted: The patch has been applied > > - Rejected: The patch has been rejected, with reasons stated in an > > email > > > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 8a5012ba6ff9..e2882dc703d8 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -17516,6 +17516,7 @@ M: Palmer Dabbelt <palmer@dabbelt.com> > > M: Albert Ou <aou@eecs.berkeley.edu> > > L: linux-riscv@lists.infradead.org > > S: Supported > > +Q: https://patchwork.kernel.org/project/linux-riscv/list/ > > P: Documentation/riscv/patch-acceptance.rst > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git > > F: arch/riscv/ > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv >
On Thu, 13 Oct 2022 16:29:35 PDT (-0700), Conor Dooley wrote: > On Thu, Oct 13, 2022 at 04:14:39PM -0700, Palmer Dabbelt wrote: >> On Tue, 11 Oct 2022 09:07:45 PDT (-0700), Conor Dooley wrote: >> > Hey, >> > >> > As one or two people have already noticed, we've resurrected the >> > patchwork for the RISC-V list @ >> > https://patchwork.kernel.org/project/linux-riscv/list/ >> > >> > The patchwork bot should let people know when their patches have been >> > applied. Hopefully it'll help people track what the status of their >> > patches are a little better and try to prevent stuff falling through >> > the cracks in Palmer's inbox. >> > >> > As an FYI, the statuses that are intended to be used are: >> > - New: No action has been taken yet >> > - Under Review: The maintainer is waiting for review comments from others >> > - Changes Requested: Either the maintainer or a reviewer requested >> > changes in the patch. The patch author is expected to submit a new >> > version >> > - Superseded: There's a new version of the patch available >> > - Not Applicable: The patch is not intended for the RISC-V tree >> > - Accepted: The patch has been applied >> > - Rejected: The patch has been rejected, with reasons stated in an >> > email >> > >> > I reset patchwork and marked all patches as archived so we would have a >> > fresh start. If your patch has been archived & not applied by the end of >> > this merge window, feel free to resend it. >> > >> > Thanks, >> > Conor. >> > >> > @Palmer: hopefully I did the scissors thing correctly.. >> >> b4 doesn't like it, but my old scripts just picked up the whole thing as a >> patch. I tossed the above bits, LMK if something went off the rails. > > I just copied the suggested scissors format from the git-mailinfo man > page and pasted that. I didn't know this prior to 5 mins ago, but > `b4 mbox` splits it on the scissors line, into a patch and an email > inside the mbox - but for w/e reason, `git am` (or `b4 shazam`) then > seems to try and apply the email instead of the patch? Or else pasting > the patch into mutt was a terrible idea? Maybe it's worth mentioning to > Konstantin that things get messed up here, I'll do it tomorrow if I > remember. If the man pages suggest doing this but the tools fail then it's worth fixing something, even if it's just the man page ;) > Unlikely I'll ever really send many more patches with this format so w/e > at the end of the day. > Thanks, > Conor. > >> >> > >> > -- >8 -- >> > From f886e8a9def4bd3f2fa8a0a4d7e92c94fe72ea72 Mon Sep 17 00:00:00 2001 >> > From: Conor Dooley <conor.dooley@microchip.com> >> > Date: Tue, 11 Oct 2022 16:49:53 +0100 >> > Subject: [PATCH] MAINTAINERS: add RISC-V's patchwork >> > >> > The RISC-V patchwork instance on kernel.org has had some necromancy >> > performed on it & will be used going forward. The statuses that are >> > intended to be used are: >> > - New: No action has been taken yet >> > - Under Review: The maintainer is waiting for review comments from others >> > - Changes Requested: Either the maintainer or a reviewer requested >> > changes in the patch. The patch author is expected to submit a new >> > version >> > - Superseded: There's a new version of the patch available >> > - Not Applicable: The patch is not intended for the RISC-V tree >> > - Accepted: The patch has been applied >> > - Rejected: The patch has been rejected, with reasons stated in an >> > email >> > >> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> >> > --- >> > MAINTAINERS | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/MAINTAINERS b/MAINTAINERS >> > index 8a5012ba6ff9..e2882dc703d8 100644 >> > --- a/MAINTAINERS >> > +++ b/MAINTAINERS >> > @@ -17516,6 +17516,7 @@ M: Palmer Dabbelt <palmer@dabbelt.com> >> > M: Albert Ou <aou@eecs.berkeley.edu> >> > L: linux-riscv@lists.infradead.org >> > S: Supported >> > +Q: https://patchwork.kernel.org/project/linux-riscv/list/ >> > P: Documentation/riscv/patch-acceptance.rst >> > T: git git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git >> > F: arch/riscv/ >> >> _______________________________________________ >> linux-riscv mailing list >> linux-riscv@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-riscv >>
On Fri, Oct 14, 2022 at 09:15:04AM -0700, Palmer Dabbelt wrote: > On Thu, 13 Oct 2022 16:29:35 PDT (-0700), Conor Dooley wrote: > > On Thu, Oct 13, 2022 at 04:14:39PM -0700, Palmer Dabbelt wrote: > > > On Tue, 11 Oct 2022 09:07:45 PDT (-0700), Conor Dooley wrote: > > > > Hey, > > > > > > > > As one or two people have already noticed, we've resurrected the > > > > patchwork for the RISC-V list @ > > > > https://patchwork.kernel.org/project/linux-riscv/list/ > > > > > > > > The patchwork bot should let people know when their patches have been > > > > applied. Hopefully it'll help people track what the status of their > > > > patches are a little better and try to prevent stuff falling through > > > > the cracks in Palmer's inbox. > > > > > > > > As an FYI, the statuses that are intended to be used are: > > > > - New: No action has been taken yet > > > > - Under Review: The maintainer is waiting for review comments from others > > > > - Changes Requested: Either the maintainer or a reviewer requested > > > > changes in the patch. The patch author is expected to submit a new > > > > version > > > > - Superseded: There's a new version of the patch available > > > > - Not Applicable: The patch is not intended for the RISC-V tree > > > > - Accepted: The patch has been applied > > > > - Rejected: The patch has been rejected, with reasons stated in an > > > > email > > > > > > > > I reset patchwork and marked all patches as archived so we would have a > > > > fresh start. If your patch has been archived & not applied by the end of > > > > this merge window, feel free to resend it. > > > > > > > > Thanks, > > > > Conor. > > > > > > > > @Palmer: hopefully I did the scissors thing correctly.. > > > > > > b4 doesn't like it, but my old scripts just picked up the whole thing as a > > > patch. I tossed the above bits, LMK if something went off the rails. > > > > I just copied the suggested scissors format from the git-mailinfo man > > page and pasted that. I didn't know this prior to 5 mins ago, but > > `b4 mbox` splits it on the scissors line, into a patch and an email > > inside the mbox - but for w/e reason, `git am` (or `b4 shazam`) then > > seems to try and apply the email instead of the patch? Or else pasting > > the patch into mutt was a terrible idea? Maybe it's worth mentioning to > > Konstantin that things get messed up here, I'll do it tomorrow if I > > remember. > > If the man pages suggest doing this but the tools fail then it's worth > fixing something, even if it's just the man page ;) Konstantin, perhaps you can shed some light on what's happening here? FWIW I see this on 0.10.0-dev-d8d41. Thanks, Conor. > > > Unlikely I'll ever really send many more patches with this format so w/e > > at the end of the day. > > Thanks, > > Conor. > > > > > > > > > > > > > -- >8 -- > > > > From f886e8a9def4bd3f2fa8a0a4d7e92c94fe72ea72 Mon Sep 17 00:00:00 2001 > > > > From: Conor Dooley <conor.dooley@microchip.com> > > > > Date: Tue, 11 Oct 2022 16:49:53 +0100 > > > > Subject: [PATCH] MAINTAINERS: add RISC-V's patchwork > > > > > > > > The RISC-V patchwork instance on kernel.org has had some necromancy > > > > performed on it & will be used going forward. The statuses that are > > > > intended to be used are: > > > > - New: No action has been taken yet > > > > - Under Review: The maintainer is waiting for review comments from others > > > > - Changes Requested: Either the maintainer or a reviewer requested > > > > changes in the patch. The patch author is expected to submit a new > > > > version > > > > - Superseded: There's a new version of the patch available > > > > - Not Applicable: The patch is not intended for the RISC-V tree > > > > - Accepted: The patch has been applied > > > > - Rejected: The patch has been rejected, with reasons stated in an > > > > email > > > > > > > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > > > --- > > > > MAINTAINERS | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > index 8a5012ba6ff9..e2882dc703d8 100644 > > > > --- a/MAINTAINERS > > > > +++ b/MAINTAINERS > > > > @@ -17516,6 +17516,7 @@ M: Palmer Dabbelt <palmer@dabbelt.com> > > > > M: Albert Ou <aou@eecs.berkeley.edu> > > > > L: linux-riscv@lists.infradead.org > > > > S: Supported > > > > +Q: https://patchwork.kernel.org/project/linux-riscv/list/ > > > > P: Documentation/riscv/patch-acceptance.rst > > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git > > > > F: arch/riscv/ > > > > > > _______________________________________________ > > > linux-riscv mailing list > > > linux-riscv@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-riscv > > > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
On Tue, Oct 11, 2022 at 05:07:45PM +0100, Conor Dooley wrote: > Hey, > > As one or two people have already noticed, we've resurrected the > patchwork for the RISC-V list @ > https://patchwork.kernel.org/project/linux-riscv/list/ > > The patchwork bot should let people know when their patches have been > applied. Hopefully it'll help people track what the status of their > patches are a little better and try to prevent stuff falling through > the cracks in Palmer's inbox. > > As an FYI, the statuses that are intended to be used are: > - New: No action has been taken yet > - Under Review: The maintainer is waiting for review comments from others We had the first patchwork sync meeting thing today & one of the things that came up was the lack of granularity of the "Under Review" status. Currently, things that Palmer needs to look at were marked as "Under Review" & delegated to him. There's no way with that "strategy" to determine at a glance which patches were low-hanging fruit or important fixes etc, versus things that need his input to progress but are not applicable yet. Since the number of statuses that mean a patch shows up in the "Action Required" state is rather limited, we're going to try modifying the use of "New" and "Under Review". What we will give a go is: - New & no delegate: No action has been taken yet & the patch is not likely to land for the upcoming release nor is a fix. - New & delegated to Palmer: The patch is not likely to land for the upcoming release nor is a fix, but Palmer's input on it is required to make progress. - Under Review & delegated to Palmer: Trivial changes, urgent fixes for this release & content that is likely ready to be merged for this window. - Under Review & no delegate: Fixes or content that is likely to be ready for this window, but is waiting for review comments from others. Hopefully I've accurately captured what was said, scream if I have not. A new status was also adopted: - Needs Ack: The patch is not intended for the RISC-V tree, but an Ack from Palmer is needed. If anyone wants to come along to the patchwork sync calls, check out Palmer's invite email: https://lore.kernel.org/linux-riscv/mhng-775d4068-6c1e-48a4-a1dc-b4a76ff26bb3@palmer-ri-x1c9a/ > - Changes Requested: Either the maintainer or a reviewer requested > changes in the patch. The patch author is expected to submit a new > version > - Superseded: There's a new version of the patch available > - Not Applicable: The patch is not intended for the RISC-V tree > - Accepted: The patch has been applied > - Rejected: The patch has been rejected, with reasons stated in an > email
On Fri, Oct 14, 2022 at 07:18:46PM +0100, Conor Dooley wrote: > > > I just copied the suggested scissors format from the git-mailinfo man > > > page and pasted that. I didn't know this prior to 5 mins ago, but > > > `b4 mbox` splits it on the scissors line, into a patch and an email > > > inside the mbox - but for w/e reason, `git am` (or `b4 shazam`) then > > > seems to try and apply the email instead of the patch? Or else pasting > > > the patch into mutt was a terrible idea? Maybe it's worth mentioning to > > > Konstantin that things get messed up here, I'll do it tomorrow if I > > > remember. > > > > If the man pages suggest doing this but the tools fail then it's worth > > fixing something, even if it's just the man page ;) > > Konstantin, perhaps you can shed some light on what's happening here? > FWIW I see this on 0.10.0-dev-d8d41. Sorry, just going through my old mail and I noticed that I never followed up on this. We added full ability to support scissors with b4-0.11. Cheers, -K
diff --git a/MAINTAINERS b/MAINTAINERS index 8a5012ba6ff9..e2882dc703d8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17516,6 +17516,7 @@ M: Palmer Dabbelt <palmer@dabbelt.com> M: Albert Ou <aou@eecs.berkeley.edu> L: linux-riscv@lists.infradead.org S: Supported +Q: https://patchwork.kernel.org/project/linux-riscv/list/ P: Documentation/riscv/patch-acceptance.rst T: git git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git F: arch/riscv/