diff mbox series

riscv: defconfig: add SERIAL_8250_DW

Message ID 20221119121953.3897171-1-clabbe@baylibre.com (mailing list archive)
State Not Applicable
Delegated to: Palmer Dabbelt
Headers show
Series riscv: defconfig: add SERIAL_8250_DW | expand

Checks

Context Check Description
conchuod/tree_selection fail Guessing tree name failed

Commit Message

Corentin LABBE Nov. 19, 2022, 12:19 p.m. UTC
jh7100-starfive-visionfive-v1 DTB was recently added, but all my try to
boot it in kernelCI failed.
This is due to a missing serial driver in defconfig.
So let's add CONFIG_SERIAL_8250_DW which is needed.

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 arch/riscv/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Conor Dooley Nov. 19, 2022, 12:28 p.m. UTC | #1
On Sat, Nov 19, 2022 at 12:19:53PM +0000, Corentin Labbe wrote:
> jh7100-starfive-visionfive-v1 DTB was recently added, but all my try to
> boot it in kernelCI failed.
> This is due to a missing serial driver in defconfig.
> So let's add CONFIG_SERIAL_8250_DW which is needed.
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

See here also, StarFive guys posted the same patch:
https://lore.kernel.org/linux-riscv/Y3d0tL6UoAbdhHKE@spud/

I'll try to harangue Palmer into picking up one for v6.2 & if it
happens to be this one:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  arch/riscv/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> index f7f32448f160..9a35ff88bec2 100644
> --- a/arch/riscv/configs/defconfig
> +++ b/arch/riscv/configs/defconfig
> @@ -123,6 +123,7 @@ CONFIG_MICROSEMI_PHY=y
>  CONFIG_INPUT_MOUSEDEV=y
>  CONFIG_SERIAL_8250=y
>  CONFIG_SERIAL_8250_CONSOLE=y
> +CONFIG_SERIAL_8250_DW=y
>  CONFIG_SERIAL_OF_PLATFORM=y
>  CONFIG_SERIAL_SH_SCI=y
>  CONFIG_VIRTIO_CONSOLE=y
> -- 
> 2.37.4
>
Ben Dooks Nov. 21, 2022, 8:13 a.m. UTC | #2
On 19/11/2022 12:19, Corentin Labbe wrote:
> jh7100-starfive-visionfive-v1 DTB was recently added, but all my try to
> boot it in kernelCI failed.
> This is due to a missing serial driver in defconfig.
> So let's add CONFIG_SERIAL_8250_DW which is needed.

This block is an extended 16550, so not sure why the 16550/8250
driver isn't being used as a backup in case the DesingWare variant
isn't there.
diff mbox series

Patch

diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
index f7f32448f160..9a35ff88bec2 100644
--- a/arch/riscv/configs/defconfig
+++ b/arch/riscv/configs/defconfig
@@ -123,6 +123,7 @@  CONFIG_MICROSEMI_PHY=y
 CONFIG_INPUT_MOUSEDEV=y
 CONFIG_SERIAL_8250=y
 CONFIG_SERIAL_8250_CONSOLE=y
+CONFIG_SERIAL_8250_DW=y
 CONFIG_SERIAL_OF_PLATFORM=y
 CONFIG_SERIAL_SH_SCI=y
 CONFIG_VIRTIO_CONSOLE=y