diff mbox series

[v5,07/12] dt-bindings: net: starfive,jh7110-dwmac: Add starfive,syscon

Message ID 20230303085928.4535-8-samin.guo@starfivetech.com (mailing list archive)
State Superseded
Headers show
Series Add Ethernet driver for StarFive JH7110 SoC | expand

Checks

Context Check Description
conchuod/tree_selection fail Failed to apply to next/pending-fixes or riscv/for-next

Commit Message

Guo Samin March 3, 2023, 8:59 a.m. UTC
A phandle to syscon with two arguments that configure phy mode.

Signed-off-by: Samin Guo <samin.guo@starfivetech.com>
---
 .../bindings/net/starfive,jh7110-dwmac.yaml         | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Rob Herring (Arm) March 8, 2023, 10:03 p.m. UTC | #1
On Fri, Mar 03, 2023 at 04:59:23PM +0800, Samin Guo wrote:
> A phandle to syscon with two arguments that configure phy mode.

This change belongs in patch 4.

> 
> Signed-off-by: Samin Guo <samin.guo@starfivetech.com>
> ---
>  .../bindings/net/starfive,jh7110-dwmac.yaml         | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> index ca49f08d50dd..79ae635db0a5 100644
> --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> @@ -58,6 +58,18 @@ properties:
>        Tx clock is provided by external rgmii clock.
>      type: boolean
>  
> +  starfive,syscon:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    items:
> +      - items:
> +          - description: phandle to syscon that configures phy mode
> +          - description: Offset of phy mode selection
> +          - description: Mask of phy mode selection
> +    description:
> +      A phandle to syscon with two arguments that configure phy mode.
> +      The argument one is the offset of phy mode selection, the
> +      argument two is the mask of phy mode selection.
> +
>  allOf:
>    - $ref: snps,dwmac.yaml#
>  
> @@ -96,6 +108,7 @@ examples:
>          snps,en-tx-lpi-clockgating;
>          snps,txpbl = <16>;
>          snps,rxpbl = <16>;
> +        starfive,syscon = <&aon_syscon 0xc 0x1c0000>;
>          phy-handle = <&phy0>;
>  
>          mdio {
> -- 
> 2.17.1
>
Guo Samin March 9, 2023, 1:16 a.m. UTC | #2
-------- 原始信息 --------
主题: Re: [PATCH v5 07/12] dt-bindings: net: starfive,jh7110-dwmac: Add starfive,syscon
From: Rob Herring <robh@kernel.org>

> On Fri, Mar 03, 2023 at 04:59:23PM +0800, Samin Guo wrote:
>> A phandle to syscon with two arguments that configure phy mode.
> 
> This change belongs in patch 4.
> 
Thank you for pointing out that the next version will be merged into patch4


Best regards,
Samin

>>
>> Signed-off-by: Samin Guo <samin.guo@starfivetech.com>
>> ---
>>  .../bindings/net/starfive,jh7110-dwmac.yaml         | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
>> index ca49f08d50dd..79ae635db0a5 100644
>> --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
>> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
>> @@ -58,6 +58,18 @@ properties:
>>        Tx clock is provided by external rgmii clock.
>>      type: boolean
>>  
>> +  starfive,syscon:
>> +    $ref: /schemas/types.yaml#/definitions/phandle-array
>> +    items:
>> +      - items:
>> +          - description: phandle to syscon that configures phy mode
>> +          - description: Offset of phy mode selection
>> +          - description: Mask of phy mode selection
>> +    description:
>> +      A phandle to syscon with two arguments that configure phy mode.
>> +      The argument one is the offset of phy mode selection, the
>> +      argument two is the mask of phy mode selection.
>> +
>>  allOf:
>>    - $ref: snps,dwmac.yaml#
>>  
>> @@ -96,6 +108,7 @@ examples:
>>          snps,en-tx-lpi-clockgating;
>>          snps,txpbl = <16>;
>>          snps,rxpbl = <16>;
>> +        starfive,syscon = <&aon_syscon 0xc 0x1c0000>;
>>          phy-handle = <&phy0>;
>>  
>>          mdio {
>> -- 
>> 2.17.1
>>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
index ca49f08d50dd..79ae635db0a5 100644
--- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
@@ -58,6 +58,18 @@  properties:
       Tx clock is provided by external rgmii clock.
     type: boolean
 
+  starfive,syscon:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    items:
+      - items:
+          - description: phandle to syscon that configures phy mode
+          - description: Offset of phy mode selection
+          - description: Mask of phy mode selection
+    description:
+      A phandle to syscon with two arguments that configure phy mode.
+      The argument one is the offset of phy mode selection, the
+      argument two is the mask of phy mode selection.
+
 allOf:
   - $ref: snps,dwmac.yaml#
 
@@ -96,6 +108,7 @@  examples:
         snps,en-tx-lpi-clockgating;
         snps,txpbl = <16>;
         snps,rxpbl = <16>;
+        starfive,syscon = <&aon_syscon 0xc 0x1c0000>;
         phy-handle = <&phy0>;
 
         mdio {