| Message ID | 20230329-dt-cpu-header-cleanups-v1-12-581e2605fe47@kernel.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | DT header disentangling, part 1 | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be for-next at HEAD e97be4fbc1b1 |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 1 and now 1 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 1 this patch: 1 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 19 this patch: 19 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 19 this patch: 19 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 3 this patch: 3 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 14 lines checked |
| conchuod/source_inline | success | Was 0 now: 0 |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On Wed, Mar 29, 2023 at 5:53 PM Rob Herring <robh@kernel.org> wrote: > > Now that of_cpu_device_node_get() is defined in of.h, of_device.h is just > implicitly including other includes, and is no longer needed. Adjust the > include files with what was implicitly included by of_device.h (cpu.h and > of.h) and drop including of_device.h. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Please ack and I will take the series via the DT tree. Acked-by: Rafael J. Wysocki <rafael@kernel.org> > --- > drivers/thermal/cpuidle_cooling.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/thermal/cpuidle_cooling.c b/drivers/thermal/cpuidle_cooling.c > index 4f41102e8b16..6f6daead485e 100644 > --- a/drivers/thermal/cpuidle_cooling.c > +++ b/drivers/thermal/cpuidle_cooling.c > @@ -7,12 +7,13 @@ > */ > #define pr_fmt(fmt) "cpuidle cooling: " fmt > > +#include <linux/cpu.h> > #include <linux/cpu_cooling.h> > #include <linux/cpuidle.h> > #include <linux/device.h> > #include <linux/err.h> > #include <linux/idle_inject.h> > -#include <linux/of_device.h> > +#include <linux/of.h> > #include <linux/slab.h> > #include <linux/thermal.h> > > > -- > 2.39.2 >
On 29/03/2023 17:52, Rob Herring wrote: > Now that of_cpu_device_node_get() is defined in of.h, of_device.h is just > implicitly including other includes, and is no longer needed. Adjust the > include files with what was implicitly included by of_device.h (cpu.h and > of.h) and drop including of_device.h. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Please ack and I will take the series via the DT tree. Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
diff --git a/drivers/thermal/cpuidle_cooling.c b/drivers/thermal/cpuidle_cooling.c index 4f41102e8b16..6f6daead485e 100644 --- a/drivers/thermal/cpuidle_cooling.c +++ b/drivers/thermal/cpuidle_cooling.c @@ -7,12 +7,13 @@ */ #define pr_fmt(fmt) "cpuidle cooling: " fmt +#include <linux/cpu.h> #include <linux/cpu_cooling.h> #include <linux/cpuidle.h> #include <linux/device.h> #include <linux/err.h> #include <linux/idle_inject.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/slab.h> #include <linux/thermal.h>
Now that of_cpu_device_node_get() is defined in of.h, of_device.h is just implicitly including other includes, and is no longer needed. Adjust the include files with what was implicitly included by of_device.h (cpu.h and of.h) and drop including of_device.h. Signed-off-by: Rob Herring <robh@kernel.org> --- Please ack and I will take the series via the DT tree. --- drivers/thermal/cpuidle_cooling.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)