| Message ID | 20230504185938.179661118@linutronix.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | cpu/hotplug, x86: Reworked parallel CPU bringup | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be for-next at HEAD c2d3c8441e3d |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 5 and now 5 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 8 this patch: 8 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 8 this patch: 8 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 5 this patch: 5 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| conchuod/source_inline | success | Was 0 now: 0 |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On 04/05/2023 8:02 pm, Thomas Gleixner wrote: > From: Thomas Gleixner <tglx@linutronix.de> > > The early detection stores the extended topology leaf number which is > required for parallel hotplug. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> It occurs to me that this and the previous patch are stale given that we no longer look at CPUID in the trampoline. They're probably useful changes in isolation, but the commit messages want adjusting to remove the association with parallel boot. ~Andrew
On Fri, May 05 2023 at 00:04, Andrew Cooper wrote: > On 04/05/2023 8:02 pm, Thomas Gleixner wrote: >> From: Thomas Gleixner <tglx@linutronix.de> >> >> The early detection stores the extended topology leaf number which is >> required for parallel hotplug. >> >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > > It occurs to me that this and the previous patch are stale given that we > no longer look at CPUID in the trampoline. > > They're probably useful changes in isolation, but the commit messages > want adjusting to remove the association with parallel boot. Duh. Indeed. Completely forgot about that.
--- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -692,6 +692,8 @@ static void early_init_amd(struct cpuinf } } + detect_extended_topology_early(c); + if (cpu_has(c, X86_FEATURE_TOPOEXT)) smp_num_siblings = ((cpuid_ebx(0x8000001e) >> 8) & 0xff) + 1; }