| Message ID | 20230519060854.214138-1-suagrfillet@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 650ea2a1dd964ca0a9c55f68dcb614d359c6b7d7 |
| Headers | show |
| Series | riscv: hibernation: Replace jalr with jr before suspend_restore_regs | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Single patches do not need cover letters |
| conchuod/tree_selection | success | Guessed tree name to be for-next at HEAD ac9a78681b92 |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 6 and now 6 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 14 this patch: 14 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 28 this patch: 28 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 3 this patch: 3 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 14 lines checked |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
looks good to me. Thanks Regards Jee Heng > -----Original Message----- > From: Song Shuai <suagrfillet@gmail.com> > Sent: Friday, May 19, 2023 2:09 PM > To: paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu; JeeHeng Sia <jeeheng.sia@starfivetech.com>; Mason > Huo <mason.huo@starfivetech.com>; conor.dooley@microchip.com > Cc: linux-riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Song Shuai <suagrfillet@gmail.com> > Subject: [PATCH] riscv: hibernation: Replace jalr with jr before suspend_restore_regs > > No need to link the x1/ra reg via jalr before suspend_restore_regs > So it's better to replace jalr with jr. > > Signed-off-by: Song Shuai <suagrfillet@gmail.com> > --- > arch/riscv/kernel/hibernate-asm.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/kernel/hibernate-asm.S b/arch/riscv/kernel/hibernate-asm.S > index effaf5ca5da0..5c76671c7e15 100644 > --- a/arch/riscv/kernel/hibernate-asm.S > +++ b/arch/riscv/kernel/hibernate-asm.S > @@ -50,7 +50,7 @@ ENTRY(hibernate_restore_image) > REG_L s4, restore_pblist > REG_L a1, relocated_restore_code > > - jalr a1 > + jr a1 > END(hibernate_restore_image) > > /* > @@ -73,5 +73,5 @@ ENTRY(hibernate_core_restore_code) > REG_L s4, HIBERN_PBE_NEXT(s4) > bnez s4, .Lcopy > > - jalr s2 > + jr s2 I am content with these changes, as they do not involve a return after the jump > END(hibernate_core_restore_code) > -- > 2.20.1
> -----Original Message----- > From: JeeHeng Sia > Sent: Friday, May 19, 2023 6:45 PM > To: 'Song Shuai' <suagrfillet@gmail.com>; paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu; Mason Huo > <mason.huo@starfivetech.com>; conor.dooley@microchip.com > Cc: linux-riscv@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: RE: [PATCH] riscv: hibernation: Replace jalr with jr before suspend_restore_regs > > looks good to me. > > Thanks > Regards > Jee Heng > > -----Original Message----- > > From: Song Shuai <suagrfillet@gmail.com> > > Sent: Friday, May 19, 2023 2:09 PM > > To: paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu; JeeHeng Sia <jeeheng.sia@starfivetech.com>; > Mason > > Huo <mason.huo@starfivetech.com>; conor.dooley@microchip.com > > Cc: linux-riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Song Shuai <suagrfillet@gmail.com> > > Subject: [PATCH] riscv: hibernation: Replace jalr with jr before suspend_restore_regs > > > > No need to link the x1/ra reg via jalr before suspend_restore_regs > > So it's better to replace jalr with jr. > > > > Signed-off-by: Song Shuai <suagrfillet@gmail.com> > > --- > > arch/riscv/kernel/hibernate-asm.S | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/riscv/kernel/hibernate-asm.S b/arch/riscv/kernel/hibernate-asm.S > > index effaf5ca5da0..5c76671c7e15 100644 > > --- a/arch/riscv/kernel/hibernate-asm.S > > +++ b/arch/riscv/kernel/hibernate-asm.S > > @@ -50,7 +50,7 @@ ENTRY(hibernate_restore_image) > > REG_L s4, restore_pblist > > REG_L a1, relocated_restore_code > > > > - jalr a1 > > + jr a1 > > END(hibernate_restore_image) > > > > /* > > @@ -73,5 +73,5 @@ ENTRY(hibernate_core_restore_code) > > REG_L s4, HIBERN_PBE_NEXT(s4) > > bnez s4, .Lcopy > > > > - jalr s2 > > + jr s2 > I am content with these changes, as they do not involve a return after the jump Reviewed-by: JeeHeng Sia <jeeheng.sia@starfivetech.com > Thanks Regards Jee Heng > > END(hibernate_core_restore_code) > > -- > > 2.20.1
On Fri, 19 May 2023 14:08:54 +0800, Song Shuai wrote: > No need to link the x1/ra reg via jalr before suspend_restore_regs > So it's better to replace jalr with jr. > > Applied, thanks! [1/1] riscv: hibernation: Replace jalr with jr before suspend_restore_regs https://git.kernel.org/palmer/c/650ea2a1dd96 Best regards,
Hello: This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <palmer@rivosinc.com>: On Fri, 19 May 2023 14:08:54 +0800 you wrote: > No need to link the x1/ra reg via jalr before suspend_restore_regs > So it's better to replace jalr with jr. > > Signed-off-by: Song Shuai <suagrfillet@gmail.com> > --- > arch/riscv/kernel/hibernate-asm.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Here is the summary with links: - riscv: hibernation: Replace jalr with jr before suspend_restore_regs https://git.kernel.org/riscv/c/650ea2a1dd96 You are awesome, thank you!
diff --git a/arch/riscv/kernel/hibernate-asm.S b/arch/riscv/kernel/hibernate-asm.S index effaf5ca5da0..5c76671c7e15 100644 --- a/arch/riscv/kernel/hibernate-asm.S +++ b/arch/riscv/kernel/hibernate-asm.S @@ -50,7 +50,7 @@ ENTRY(hibernate_restore_image) REG_L s4, restore_pblist REG_L a1, relocated_restore_code - jalr a1 + jr a1 END(hibernate_restore_image) /* @@ -73,5 +73,5 @@ ENTRY(hibernate_core_restore_code) REG_L s4, HIBERN_PBE_NEXT(s4) bnez s4, .Lcopy - jalr s2 + jr s2 END(hibernate_core_restore_code)
No need to link the x1/ra reg via jalr before suspend_restore_regs So it's better to replace jalr with jr. Signed-off-by: Song Shuai <suagrfillet@gmail.com> --- arch/riscv/kernel/hibernate-asm.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)