| Message ID | 20230626-skydiver-frown-659b982a43ad@wendy (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | RISC-V: Probe DT extension support using riscv,isa-extensions & riscv,isa-base | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be for-next at HEAD 488833ccdcac |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 6 and now 6 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 8 this patch: 8 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 9 this patch: 9 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 20 this patch: 20 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On Mon, Jun 26, 2023 at 12:19:40PM +0100, Conor Dooley wrote: > isa_ext_arr cannot be empty, as some of the extensions within it are > always built into the kernel. This is only true since commit 07edc32779e3 ("RISC-V: always report presence of extensions formerly part of the base ISA"), right? If so, it might be nice to call that commit out in this commit message. > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > arch/riscv/kernel/cpu.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/riscv/kernel/cpu.c b/arch/riscv/kernel/cpu.c > index 742bb42e7e86..01f7e5c62997 100644 > --- a/arch/riscv/kernel/cpu.c > +++ b/arch/riscv/kernel/cpu.c > @@ -233,10 +233,6 @@ static void print_isa_ext(struct seq_file *f) > > arr_sz = ARRAY_SIZE(isa_ext_arr) - 1; > > - /* No extension support available */ > - if (arr_sz <= 0) > - return; > - > for (i = 0; i <= arr_sz; i++) { > edata = &isa_ext_arr[i]; > if (!__riscv_isa_extension_available(NULL, edata->isa_ext_id)) > -- > 2.40.1 > Otherwise, Reviewed-by: Andrew Jones <ajones@ventanamicro.com> Thanks, drew
On Mon, Jun 26, 2023 at 05:19:08PM +0200, Andrew Jones wrote: > On Mon, Jun 26, 2023 at 12:19:40PM +0100, Conor Dooley wrote: > > isa_ext_arr cannot be empty, as some of the extensions within it are > > always built into the kernel. > > This is only true since commit 07edc32779e3 ("RISC-V: always report > presence of extensions formerly part of the base ISA"), right? If > so, it might be nice to call that commit out in this commit message. Per my last mail, where I commented on the origins of some of this code, there were no multi-letter extensions when this code was first added. When the first multi-letter ones did get added, it was Sscofpmf - that doesn't have a Kconfig symbol to disable it, so I think this has been redundant for a long time. Apart from the ones I recently added, there's a fair few others that are not gated & should always be present. It's probably not clear from the comment, but this check is for whether the kernel supports extensions, not whether the system it is running on does. I guess I should expand on that in my commit message. Thanks, Conor. > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > --- > > arch/riscv/kernel/cpu.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/arch/riscv/kernel/cpu.c b/arch/riscv/kernel/cpu.c > > index 742bb42e7e86..01f7e5c62997 100644 > > --- a/arch/riscv/kernel/cpu.c > > +++ b/arch/riscv/kernel/cpu.c > > @@ -233,10 +233,6 @@ static void print_isa_ext(struct seq_file *f) > > > > arr_sz = ARRAY_SIZE(isa_ext_arr) - 1; > > > > - /* No extension support available */ > > - if (arr_sz <= 0) > > - return; > > - > > for (i = 0; i <= arr_sz; i++) { > > edata = &isa_ext_arr[i]; > > if (!__riscv_isa_extension_available(NULL, edata->isa_ext_id)) > > -- > > 2.40.1 > > > > Otherwise, > > Reviewed-by: Andrew Jones <ajones@ventanamicro.com> > > Thanks, > drew
On Mon, Jun 26, 2023 at 05:08:28PM +0100, Conor Dooley wrote: > On Mon, Jun 26, 2023 at 05:19:08PM +0200, Andrew Jones wrote: > > On Mon, Jun 26, 2023 at 12:19:40PM +0100, Conor Dooley wrote: > > > isa_ext_arr cannot be empty, as some of the extensions within it are > > > always built into the kernel. > > > > This is only true since commit 07edc32779e3 ("RISC-V: always report > > presence of extensions formerly part of the base ISA"), right? If > > so, it might be nice to call that commit out in this commit message. > > Per my last mail, where I commented on the origins of some of this code, > there were no multi-letter extensions when this code was first added. > When the first multi-letter ones did get added, it was Sscofpmf - that > doesn't have a Kconfig symbol to disable it, so I think this has been > redundant for a long time. > > Apart from the ones I recently added, there's a fair few others that > are not gated & should always be present. > It's probably not clear from the comment, but this check is for whether > the kernel supports extensions, not whether the system it is running on > does. I guess I should expand on that in my commit message. That part I understood, but I was thinking it'd be nice to call out when the first extension was added which cannot be disabled by a config to provide extra evidence that it's safe to remove the check. Thanks, drew
diff --git a/arch/riscv/kernel/cpu.c b/arch/riscv/kernel/cpu.c index 742bb42e7e86..01f7e5c62997 100644 --- a/arch/riscv/kernel/cpu.c +++ b/arch/riscv/kernel/cpu.c @@ -233,10 +233,6 @@ static void print_isa_ext(struct seq_file *f) arr_sz = ARRAY_SIZE(isa_ext_arr) - 1; - /* No extension support available */ - if (arr_sz <= 0) - return; - for (i = 0; i <= arr_sz; i++) { edata = &isa_ext_arr[i]; if (!__riscv_isa_extension_available(NULL, edata->isa_ext_id))
isa_ext_arr cannot be empty, as some of the extensions within it are always built into the kernel. Signed-off-by: Conor Dooley <conor.dooley@microchip.com> --- arch/riscv/kernel/cpu.c | 4 ---- 1 file changed, 4 deletions(-)