| Message ID | 20230704092200.85401-2-william.qiu@starfivetech.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add SPI module for StarFive JH7110 SoC | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be for-next at HEAD 488833ccdcac |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 6 and now 6 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 8 this patch: 8 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 8 this patch: 8 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 20 this patch: 20 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 26 lines checked |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On 04/07/2023 11:21, William Qiu wrote: > The SPI controller only need apb_pclk clock to work properly on JH7110 SoC, > so there add minItems whose value is equal to 1. Other platforms do not > have this constraint. > > Signed-off-by: William Qiu <william.qiu@starfivetech.com> I don't get why this is resent, but subject prefix is still wrong. It's dt-bindings. > --- > Documentation/devicetree/bindings/spi/spi-pl022.yaml | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > index 91e540a92faf..42bb34c39971 100644 > --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > @@ -11,6 +11,7 @@ maintainers: > > allOf: > - $ref: spi-controller.yaml# > + - $ref: /schemas/arm/primecell.yaml# This looks unrelated, so keep it as separate commit with its own rationale. > > # We need a select here so we don't match all nodes with 'arm,primecell' > select: > @@ -34,12 +35,16 @@ properties: > maxItems: 1 > > clocks: > + minItems: 1 > maxItems: 2 > > clock-names: > - items: > - - const: sspclk > - - const: apb_pclk > + oneOf: > + - items: > + - const: apb_pclk > + - items: > + - const: sspclk > + - const: apb_pclk Are you sure that your clock is APB pclk in such case? Best regards, Krzysztof
On 2023/7/4 17:38, Krzysztof Kozlowski wrote: > On 04/07/2023 11:21, William Qiu wrote: >> The SPI controller only need apb_pclk clock to work properly on JH7110 SoC, >> so there add minItems whose value is equal to 1. Other platforms do not >> have this constraint. >> >> Signed-off-by: William Qiu <william.qiu@starfivetech.com> > > I don't get why this is resent, but subject prefix is still wrong. It's > dt-bindings. > Will update. >> --- >> Documentation/devicetree/bindings/spi/spi-pl022.yaml | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml >> index 91e540a92faf..42bb34c39971 100644 >> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml >> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml >> @@ -11,6 +11,7 @@ maintainers: >> >> allOf: >> - $ref: spi-controller.yaml# >> + - $ref: /schemas/arm/primecell.yaml# > > This looks unrelated, so keep it as separate commit with its own rationale. > Because "arm,primecell-periphid" is need in JH7110 SoC, so I added them in one commit, so do I need to put them in two commit? >> >> # We need a select here so we don't match all nodes with 'arm,primecell' >> select: >> @@ -34,12 +35,16 @@ properties: >> maxItems: 1 >> >> clocks: >> + minItems: 1 >> maxItems: 2 >> >> clock-names: >> - items: >> - - const: sspclk >> - - const: apb_pclk >> + oneOf: >> + - items: >> + - const: apb_pclk >> + - items: >> + - const: sspclk >> + - const: apb_pclk > > Are you sure that your clock is APB pclk in such case? > Yes, in JH7110 SoC is APB pclk in such case. Thanks for taking time to review this patch series. > Best regards, > Krzysztof >
On 05/07/2023 05:37, William Qiu wrote: >>> --- >>> Documentation/devicetree/bindings/spi/spi-pl022.yaml | 11 ++++++++--- >>> 1 file changed, 8 insertions(+), 3 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml >>> index 91e540a92faf..42bb34c39971 100644 >>> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml >>> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml >>> @@ -11,6 +11,7 @@ maintainers: >>> >>> allOf: >>> - $ref: spi-controller.yaml# >>> + - $ref: /schemas/arm/primecell.yaml# >> >> This looks unrelated, so keep it as separate commit with its own rationale. >> > Because "arm,primecell-periphid" is need in JH7110 SoC, so I added them in > one commit, so do I need to put them in two commit? You need to provide rationale why this is needed. I would assume this is needed for every primecell, not only JH7110, right? Best regards, Krzysztof
On 2023/7/5 14:00, Krzysztof Kozlowski wrote: > On 05/07/2023 05:37, William Qiu wrote: >>>> --- >>>> Documentation/devicetree/bindings/spi/spi-pl022.yaml | 11 ++++++++--- >>>> 1 file changed, 8 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml >>>> index 91e540a92faf..42bb34c39971 100644 >>>> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml >>>> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml >>>> @@ -11,6 +11,7 @@ maintainers: >>>> >>>> allOf: >>>> - $ref: spi-controller.yaml# >>>> + - $ref: /schemas/arm/primecell.yaml# >>> >>> This looks unrelated, so keep it as separate commit with its own rationale. >>> >> Because "arm,primecell-periphid" is need in JH7110 SoC, so I added them in >> one commit, so do I need to put them in two commit? > > You need to provide rationale why this is needed. I would assume this is > needed for every primecell, not only JH7110, right? > > All right, I'll keep it as separate commit. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml index 91e540a92faf..42bb34c39971 100644 --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml @@ -11,6 +11,7 @@ maintainers: allOf: - $ref: spi-controller.yaml# + - $ref: /schemas/arm/primecell.yaml# # We need a select here so we don't match all nodes with 'arm,primecell' select: @@ -34,12 +35,16 @@ properties: maxItems: 1 clocks: + minItems: 1 maxItems: 2 clock-names: - items: - - const: sspclk - - const: apb_pclk + oneOf: + - items: + - const: apb_pclk + - items: + - const: sspclk + - const: apb_pclk pl022,autosuspend-delay: description: delay in ms following transfer completion before the
The SPI controller only need apb_pclk clock to work properly on JH7110 SoC, so there add minItems whose value is equal to 1. Other platforms do not have this constraint. Signed-off-by: William Qiu <william.qiu@starfivetech.com> --- Documentation/devicetree/bindings/spi/spi-pl022.yaml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) -- 2.34.1