| Message ID | 20230803085734.340-2-nylon.chen@sifive.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Conor Dooley |
| Headers | show |
| Series | Change PWM-controlled LED pin active mode and algorithm | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be for-next at HEAD 471aba2e4760 |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 4 and now 4 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 9 this patch: 9 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 9 this patch: 9 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 3 this patch: 3 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 54 lines checked |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On Thu, Aug 03, 2023 at 04:57:34PM +0800, Nylon Chen wrote: > This removes the active-low properties of the PWM-controlled LEDs in > the HiFive Unmatched device tree. > > The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematics-v3.pdf[1]. > > Link: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf [0] > Link: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f4192_hifive-unmatched-schematics-v3.pdf [1] > > Acked-by: Conor Dooley <conor.dooley@microchip.com> Since there is no PWM driver patch for this to go along with, this ack doesn't mean anything anymore. Please drop it if you resubmit.
Hi Conor, I apologize for forgetting about this update earlier. Just now, I tried to pull rebase master and noticed that other developers seem to have made some fixes to the algorithm. Upon closer inspection, I found that they addressed the part we previously discussed with Emil and Uwe, such as "first pwm_apply_state." Therefore, my instinct tells me that they have already taken care of the issues we discussed before. I will review the conflicting parts in the pwm-sifive.c code in my v4 version once again to ensure there are no omissions. If I find any, I will submit v5 accordingly. Conor Dooley <conor.dooley@microchip.com> 於 2023年8月3日 週四 下午5:19寫道： > > On Thu, Aug 03, 2023 at 04:57:34PM +0800, Nylon Chen wrote: > > This removes the active-low properties of the PWM-controlled LEDs in > > the HiFive Unmatched device tree. > > > > The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematics-v3.pdf[1]. > > > > Link: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8698_hifive-unleashed-a00-schematics-1.pdf [0] > > Link: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f4192_hifive-unmatched-schematics-v3.pdf [1] > > > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Since there is no PWM driver patch for this to go along with, this ack > doesn't mean anything anymore. Please drop it if you resubmit. >
diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts index 900a50526d77..7a9f336a391c 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts @@ -50,7 +50,6 @@ led-controller { led-d1 { pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; - active-low; color = <LED_COLOR_ID_GREEN>; max-brightness = <255>; label = "d1"; @@ -58,7 +57,6 @@ led-d1 { led-d2 { pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; - active-low; color = <LED_COLOR_ID_GREEN>; max-brightness = <255>; label = "d2"; @@ -66,7 +64,6 @@ led-d2 { led-d3 { pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; - active-low; color = <LED_COLOR_ID_GREEN>; max-brightness = <255>; label = "d3"; @@ -74,7 +71,6 @@ led-d3 { led-d4 { pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; - active-low; color = <LED_COLOR_ID_GREEN>; max-brightness = <255>; label = "d4"; diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts index 07387f9c135c..11f08a545ee6 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts @@ -52,7 +52,6 @@ led-controller-1 { led-d12 { pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; - active-low; color = <LED_COLOR_ID_GREEN>; max-brightness = <255>; label = "d12"; @@ -69,19 +68,16 @@ multi-led { led-red { pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; - active-low; color = <LED_COLOR_ID_RED>; }; led-green { pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; - active-low; color = <LED_COLOR_ID_GREEN>; }; led-blue { pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; - active-low; color = <LED_COLOR_ID_BLUE>; }; };