diff mbox series

RISC-V: Remove unused "size" in ptrace

Message ID 20230830203754.24940-1-palmer@rivosinc.com (mailing list archive)
State Accepted
Commit 899230bac3b2888625fb33f9ca9169c50aba3007
Headers show
Series RISC-V: Remove unused "size" in ptrace | expand

Checks

Context Check Description
conchuod/cover_letter success Single patches do not need cover letters
conchuod/tree_selection success Guessed tree name to be for-next at HEAD a5554064723a
conchuod/fixes_present success Fixes tag not required for -next series
conchuod/maintainers_pattern success MAINTAINERS pattern errors before the patch: 4 and now 4
conchuod/verify_signedoff success Signed-off-by tag matches author and committer
conchuod/kdoc success Errors and warnings before: 0 this patch: 0
conchuod/build_rv64_clang_allmodconfig success Errors and warnings before: 9 this patch: 9
conchuod/module_param success Was 0 now: 0
conchuod/build_rv64_gcc_allmodconfig success Errors and warnings before: 10 this patch: 9
conchuod/build_rv32_defconfig success Build OK
conchuod/dtb_warn_rv64 success Errors and warnings before: 12 this patch: 12
conchuod/header_inline success No static functions without inline keyword in header files
conchuod/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
conchuod/build_rv64_nommu_k210_defconfig success Build OK
conchuod/verify_fixes success Fixes tag looks correct
conchuod/build_rv64_nommu_virt_defconfig success Build OK

Commit Message

Palmer Dabbelt Aug. 30, 2023, 8:37 p.m. UTC
Looks like this just got lost somewhere in the respins.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308310306.tOrkoBmI-lkp@intel.com/
Fixes: dbe46b094026 ("RISC-V: Add ptrace support for vectors")
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
---
 arch/riscv/kernel/ptrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Conor Dooley Aug. 31, 2023, 4:31 p.m. UTC | #1
On Wed, Aug 30, 2023 at 01:37:54PM -0700, Palmer Dabbelt wrote:
> Looks like this just got lost somewhere in the respins.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308310306.tOrkoBmI-lkp@intel.com/
> Fixes: dbe46b094026 ("RISC-V: Add ptrace support for vectors")
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>

Huh, wonder how the patchwork automation missed that. Probably as good a
reminder as any to update the toolchains in use there.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.
Nick Desaulniers Aug. 31, 2023, 5:19 p.m. UTC | #2
On Wed, Aug 30, 2023 at 01:37:54PM -0700, Palmer Dabbelt wrote:
> Looks like this just got lost somewhere in the respins.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308310306.tOrkoBmI-lkp@intel.com/
> Fixes: dbe46b094026 ("RISC-V: Add ptrace support for vectors")
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reported-by: "kernelci.org bot" <bot@kernelci.org>
Closes: https://lore.kernel.org/linux-next/64f03ea1.170a0220.d3dbf.11fd@mx.google.com/

> ---
>  arch/riscv/kernel/ptrace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/kernel/ptrace.c b/arch/riscv/kernel/ptrace.c
> index 9a87e5d490b5..2afe460de16a 100644
> --- a/arch/riscv/kernel/ptrace.c
> +++ b/arch/riscv/kernel/ptrace.c
> @@ -120,7 +120,7 @@ static int riscv_vr_set(struct task_struct *target,
>  			unsigned int pos, unsigned int count,
>  			const void *kbuf, const void __user *ubuf)
>  {
> -	int ret, size;
> +	int ret;
>  	struct __riscv_v_ext_state *vstate = &target->thread.vstate;
>  	struct __riscv_v_regset_state ptrace_vstate;
>  
> -- 
> 2.41.0
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
Palmer Dabbelt Aug. 31, 2023, 9:58 p.m. UTC | #3
On Wed, 30 Aug 2023 13:37:54 -0700, Palmer Dabbelt wrote:
> Looks like this just got lost somewhere in the respins.
> 
> 

Applied, thanks!

[1/1] RISC-V: Remove unused "size" in ptrace
      https://git.kernel.org/palmer/c/899230bac3b2

Best regards,
patchwork-bot+linux-riscv@kernel.org Aug. 31, 2023, 10 p.m. UTC | #4
Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:

On Wed, 30 Aug 2023 13:37:54 -0700 you wrote:
> Looks like this just got lost somewhere in the respins.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308310306.tOrkoBmI-lkp@intel.com/
> Fixes: dbe46b094026 ("RISC-V: Add ptrace support for vectors")
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> 
> [...]

Here is the summary with links:
  - RISC-V: Remove unused "size" in ptrace
    https://git.kernel.org/riscv/c/899230bac3b2

You are awesome, thank you!
Palmer Dabbelt Aug. 31, 2023, 10:02 p.m. UTC | #5
On Thu, 31 Aug 2023 14:58:26 PDT (-0700), Palmer Dabbelt wrote:
>
> On Wed, 30 Aug 2023 13:37:54 -0700, Palmer Dabbelt wrote:
>> Looks like this just got lost somewhere in the respins.
>>
>>
>
> Applied, thanks!

I'm just squashing it in, as the offending patch was pretty much tip of 
the tree.

>
> [1/1] RISC-V: Remove unused "size" in ptrace
>       https://git.kernel.org/palmer/c/899230bac3b2
>
> Best regards,
diff mbox series

Patch

diff --git a/arch/riscv/kernel/ptrace.c b/arch/riscv/kernel/ptrace.c
index 9a87e5d490b5..2afe460de16a 100644
--- a/arch/riscv/kernel/ptrace.c
+++ b/arch/riscv/kernel/ptrace.c
@@ -120,7 +120,7 @@  static int riscv_vr_set(struct task_struct *target,
 			unsigned int pos, unsigned int count,
 			const void *kbuf, const void __user *ubuf)
 {
-	int ret, size;
+	int ret;
 	struct __riscv_v_ext_state *vstate = &target->thread.vstate;
 	struct __riscv_v_regset_state ptrace_vstate;