| Message ID | 20231129060043.368874-3-jeeheng.sia@starfivetech.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Initial device tree support for StarFive JH8100 SoC | expand |
On 29/11/2023 07:00, Sia Jee Heng wrote: > Add device tree bindings for the StarFive JH8100 RISC-V SoC. > > Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com> > Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > --- > Documentation/devicetree/bindings/riscv/starfive.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml > index cc4d92f0a1bf..7e2da9eef3db 100644 > --- a/Documentation/devicetree/bindings/riscv/starfive.yaml > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml > @@ -29,7 +29,10 @@ properties: > - starfive,visionfive-2-v1.2a > - starfive,visionfive-2-v1.3b > - const: starfive,jh7110 > - > + - items: > + - enum: > + - starfive,jh8100-evb > + - const: starfive,jh8100 Why did you remove the blank line? No need for doing that. > additionalProperties: true > > ... Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Wednesday, November 29, 2023 4:27 PM > To: JeeHeng Sia <jeeheng.sia@starfivetech.com>; kernel@esmil.dk; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > krzk@kernel.org; conor+dt@kernel.org; paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu; > daniel.lezcano@linaro.org; tglx@linutronix.de; conor@kernel.org; anup@brainfault.org; gregkh@linuxfoundation.org; > jirislaby@kernel.org; michal.simek@amd.com; Michael Zhu <michael.zhu@starfivetech.com>; drew@beagleboard.org > Cc: devicetree@vger.kernel.org; linux-riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Leyfoon Tan > <leyfoon.tan@starfivetech.com> > Subject: Re: [PATCH v2 2/6] dt-bindings: riscv: Add StarFive JH8100 SoC > > On 29/11/2023 07:00, Sia Jee Heng wrote: > > Add device tree bindings for the StarFive JH8100 RISC-V SoC. > > > > Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com> > > Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > > --- > > Documentation/devicetree/bindings/riscv/starfive.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml > > index cc4d92f0a1bf..7e2da9eef3db 100644 > > --- a/Documentation/devicetree/bindings/riscv/starfive.yaml > > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml > > @@ -29,7 +29,10 @@ properties: > > - starfive,visionfive-2-v1.2a > > - starfive,visionfive-2-v1.3b > > - const: starfive,jh7110 > > - > > + - items: > > + - enum: > > + - starfive,jh8100-evb > > + - const: starfive,jh8100 > > Why did you remove the blank line? No need for doing that. Noted. Will fix it. > > > additionalProperties: true > > > > ... > > Best regards, > Krzysztof
On Wed, Nov 29, 2023 at 02:00:39PM +0800, Sia Jee Heng wrote: > Add device tree bindings for the StarFive JH8100 RISC-V SoC. > > Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com> > Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
On Wed, Nov 29, 2023 at 02:46:26PM +0000, Conor Dooley wrote: > On Wed, Nov 29, 2023 at 02:00:39PM +0800, Sia Jee Heng wrote: > > Add device tree bindings for the StarFive JH8100 RISC-V SoC. > > > > Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com> > > Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> (with the whitespace thing that Krzk pointed out fixed, just noticed that)
diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml index cc4d92f0a1bf..7e2da9eef3db 100644 --- a/Documentation/devicetree/bindings/riscv/starfive.yaml +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml @@ -29,7 +29,10 @@ properties: - starfive,visionfive-2-v1.2a - starfive,visionfive-2-v1.3b - const: starfive,jh7110 - + - items: + - enum: + - starfive,jh8100-evb + - const: starfive,jh8100 additionalProperties: true ...