[v10,1/4] dt-bindings: pwm: Add bindings for OpenCores PWM Controller

Commit Message

William Qiu Dec. 22, 2023, 9:45 a.m. UTC

Add bindings for OpenCores PWM Controller.

Signed-off-by: William Qiu <[e-mail]>
Reviewed-by: Hal Feng <[e-mail]>
Reviewed-by: Conor Dooley <[e-mail]>
---
 .../bindings/pwm/opencores,pwm.yaml           | 55 +++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/opencores,pwm.yaml

Comments

Uwe Kleine-König Jan. 4, 2024, 10:43 p.m. UTC | #1

Hello William,

On Fri, Dec 22, 2023 at 05:45:45PM +0800, William Qiu wrote:
> Add bindings for OpenCores PWM Controller.
> 
> Signed-off-by: William Qiu <[e-mail]>
> Reviewed-by: Hal Feng <[e-mail]>
> Reviewed-by: Conor Dooley <[e-mail]>

Looks fine to me. I'll assume you reiterate the series for patch #2 and
so I will mark this patch as deferred in patchwork.

Reviewed-by: Uwe Kleine-König <[e-mail]>

Best regards
Uwe

Uwe Kleine-König Jan. 8, 2024, 9:03 p.m. UTC | #2

Hello Conor,

On Thu, Jan 04, 2024 at 11:43:13PM +0100, Uwe Kleine-König wrote:
> On Fri, Dec 22, 2023 at 05:45:45PM +0800, William Qiu wrote:
> > Add bindings for OpenCores PWM Controller.
> > 
> > Signed-off-by: William Qiu <[e-mail]>
> > Reviewed-by: Hal Feng <[e-mail]>
> > Reviewed-by: Conor Dooley <[e-mail]>
> 
> Looks fine to me. I'll assume you reiterate the series for patch #2 and
> so I will mark this patch as deferred in patchwork.
> 
> Reviewed-by: Uwe Kleine-König <[e-mail]>

If you want, pick this patch up that it goes along with the dts changes.

To make this formal:

Acked-by: Uwe Kleine-König <[e-mail]>

Best regards
Uwe

Conor Dooley Jan. 9, 2024, 5:15 p.m. UTC | #3

On Mon, Jan 08, 2024 at 10:03:49PM +0100, Uwe Kleine-König wrote:
> Hello Conor,
> 
> On Thu, Jan 04, 2024 at 11:43:13PM +0100, Uwe Kleine-König wrote:
> > On Fri, Dec 22, 2023 at 05:45:45PM +0800, William Qiu wrote:
> > > Add bindings for OpenCores PWM Controller.
> > > 
> > > Signed-off-by: William Qiu <[e-mail]>
> > > Reviewed-by: Hal Feng <[e-mail]>
> > > Reviewed-by: Conor Dooley <[e-mail]>
> > 
> > Looks fine to me. I'll assume you reiterate the series for patch #2 and
> > so I will mark this patch as deferred in patchwork.
> > 
> > Reviewed-by: Uwe Kleine-König <[e-mail]>
> 
> If you want, pick this patch up that it goes along with the dts changes.
> 
> To make this formal:
> 
> Acked-by: Uwe Kleine-König <[e-mail]>

Cool. I'll do that after the merge window closes :)

Thanks!

Patch

diff --git a/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml b/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml
new file mode 100644
index 000000000000..0b85dd861dfd
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml
@@ -0,0 +1,55 @@ 
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/opencores,pwm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: OpenCores PWM controller
+
+maintainers:
+  - William Qiu <[e-mail]>
+
+description:
+  The OpenCores PTC ip core contains a PWM controller. When operating in PWM
+  mode, the PTC core generates binary signal with user-programmable low and
+  high periods. All PTC counters and registers are 32-bit.
+
+allOf:
+  - $ref: pwm.yaml#
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - starfive,jh7100-pwm
+          - starfive,jh7110-pwm
+      - const: opencores,pwm-v1
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  "#pwm-cells":
+    const: 3
+
+required:
+  - compatible
+  - reg
+  - clocks
+
+additionalProperties: false
+
+examples:
+  - |
+    pwm@12490000 {
+        compatible = "starfive,jh7110-pwm", "opencores,pwm-v1";
+        reg = <0x12490000 0x10000>;
+        clocks = <&clkgen 181>;
+        resets = <&rstgen 109>;
+        #pwm-cells = <3>;
+    };