Message ID | 20240703025850.2172008-2-quic_tengfan@quicinc.com (mailing list archive) |
---|---|
State | Handled Elsewhere |
Headers | show |
Series | arm64: qcom: dts: add QCS9100 support | expand |
Context | Check | Description |
---|---|---|
conchuod/vmtest-fixes-PR | fail | merge-conflict |
On 03/07/2024 04:58, Tengfei Fan wrote: > Document the QCS9100 SoC and RIDE board. > > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index ec1c10a12470..f06543f96026 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -45,6 +45,7 @@ description: | > qcs8550 > qcm2290 > qcm6490 > + qcs9100 > qdu1000 > qrb2210 > qrb4210 > @@ -894,7 +895,9 @@ properties: > > - items: > - enum: > + - qcom,qcs9100-ride > - qcom,sa8775p-ride > + - const: qcom,qcs9100 This changes existing compatible for sa8775p without any explanation in commit msg. Best regards, Krzysztof
On 7/3/2024 12:38 PM, Krzysztof Kozlowski wrote: > On 03/07/2024 04:58, Tengfei Fan wrote: >> Document the QCS9100 SoC and RIDE board. >> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- >> Documentation/devicetree/bindings/arm/qcom.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >> index ec1c10a12470..f06543f96026 100644 >> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >> @@ -45,6 +45,7 @@ description: | >> qcs8550 >> qcm2290 >> qcm6490 >> + qcs9100 >> qdu1000 >> qrb2210 >> qrb4210 >> @@ -894,7 +895,9 @@ properties: >> >> - items: >> - enum: >> + - qcom,qcs9100-ride >> - qcom,sa8775p-ride >> + - const: qcom,qcs9100 > > This changes existing compatible for sa8775p without any explanation in > commit msg. > > Best regards, > Krzysztof > In the next verion patch series, I will provide relevant explanatory information in this patch commit message.
On 03/07/2024 11:21, Tengfei Fan wrote: >>> - items: >>> - enum: >>> + - qcom,qcs9100-ride >>> - qcom,sa8775p-ride >>> + - const: qcom,qcs9100 >> >> This changes existing compatible for sa8775p without any explanation in >> commit msg. >> >> Best regards, >> Krzysztof >> > > In the next verion patch series, I will provide relevant explanatory > information in this patch commit message. TBH, I cannot think of any reasonable explanation for this, especially considering rest of the patchset which does not fix resulting dtbs_check warning. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index ec1c10a12470..f06543f96026 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -45,6 +45,7 @@ description: | qcs8550 qcm2290 qcm6490 + qcs9100 qdu1000 qrb2210 qrb4210 @@ -894,7 +895,9 @@ properties: - items: - enum: + - qcom,qcs9100-ride - qcom,sa8775p-ride + - const: qcom,qcs9100 - const: qcom,sa8775p - items:
Document the QCS9100 SoC and RIDE board. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- Documentation/devicetree/bindings/arm/qcom.yaml | 3 +++ 1 file changed, 3 insertions(+)