| Message ID | 20240904013344.2026738-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3cc754c237e9552ee0f2f6c2f37b3454bee39e67 |
| Headers | show |
| Series | [-next] riscv: Use LIST_HEAD() to simplify code | expand |
On Wed, Sep 04, 2024 at 09:33:44AM +0800, Jinjie Ruan wrote: > list_head can be initialized automatically with LIST_HEAD() > instead of calling INIT_LIST_HEAD(). > > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> > --- > arch/riscv/kernel/module.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c > index 906f9a3a5d65..1cd461f3d872 100644 > --- a/arch/riscv/kernel/module.c > +++ b/arch/riscv/kernel/module.c > @@ -787,8 +787,8 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab, > int res; > unsigned int num_relocations = sechdrs[relsec].sh_size / sizeof(*rel); > struct hlist_head *relocation_hashtable; > - struct list_head used_buckets_list; > unsigned int hashtable_bits; > + LIST_HEAD(used_buckets_list); > > hashtable_bits = initialize_relocation_hashtable(num_relocations, > &relocation_hashtable); > @@ -796,8 +796,6 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab, > if (!relocation_hashtable) > return -ENOMEM; > > - INIT_LIST_HEAD(&used_buckets_list); > - > pr_debug("Applying relocate section %u to %u\n", relsec, > sechdrs[relsec].sh_info); > > -- > 2.34.1 > Looks great! Tested-by: Charlie Jenkins <charlie@rivosinc.com> Reviewed-by: Charlie Jenkins <charlie@rivosinc.com>
Hello: This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <palmer@rivosinc.com>: On Wed, 4 Sep 2024 09:33:44 +0800 you wrote: > list_head can be initialized automatically with LIST_HEAD() > instead of calling INIT_LIST_HEAD(). > > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> > --- > arch/riscv/kernel/module.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Here is the summary with links: - [-next] riscv: Use LIST_HEAD() to simplify code https://git.kernel.org/riscv/c/3cc754c237e9 You are awesome, thank you!
diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c index 906f9a3a5d65..1cd461f3d872 100644 --- a/arch/riscv/kernel/module.c +++ b/arch/riscv/kernel/module.c @@ -787,8 +787,8 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab, int res; unsigned int num_relocations = sechdrs[relsec].sh_size / sizeof(*rel); struct hlist_head *relocation_hashtable; - struct list_head used_buckets_list; unsigned int hashtable_bits; + LIST_HEAD(used_buckets_list); hashtable_bits = initialize_relocation_hashtable(num_relocations, &relocation_hashtable); @@ -796,8 +796,6 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab, if (!relocation_hashtable) return -ENOMEM; - INIT_LIST_HEAD(&used_buckets_list); - pr_debug("Applying relocate section %u to %u\n", relsec, sechdrs[relsec].sh_info);
list_head can be initialized automatically with LIST_HEAD() instead of calling INIT_LIST_HEAD(). Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- arch/riscv/kernel/module.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)