| Message ID | 20241002-deliverer-recite-2c5a05f50721@spud (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add some validation for vector, vector crypto and fp stuff | expand |
On 02/10/2024 18:10, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > Per the specifications, the d extension for double-precision floating > point operations depends on the f extension for single-precious floating > point. Add that requirement to the bindings. This differs from the > Linux implementation, where single-precious only is not supported. Hey Conor, While floating point is precious to have, I don't think single-precious is the expected word here :). > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > Documentation/devicetree/bindings/riscv/extensions.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml > index a06dbc6b49289..779f5cfab806e 100644 > --- a/Documentation/devicetree/bindings/riscv/extensions.yaml > +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml > @@ -564,6 +564,12 @@ properties: > https://www.andestech.com/wp-content/uploads/AX45MP-1C-Rev.-5.0.0-Datasheet.pdf > > allOf: > + - if: > + contains: > + const: d > + then: > + contains: > + const: f > # Zcb depends on Zca > - if: > contains: Otherwise, looks good to me. Reviewed-by: Clément Léger <cleger@rivosinc.com> Clément
On Wed, Oct 02, 2024 at 05:10:56PM +0100, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > Per the specifications, the d extension for double-precision floating > point operations depends on the f extension for single-precious floating > point. Add that requirement to the bindings. This differs from the > Linux implementation, where single-precious only is not supported. > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > Documentation/devicetree/bindings/riscv/extensions.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) FWIW Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml index a06dbc6b49289..779f5cfab806e 100644 --- a/Documentation/devicetree/bindings/riscv/extensions.yaml +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml @@ -564,6 +564,12 @@ properties: https://www.andestech.com/wp-content/uploads/AX45MP-1C-Rev.-5.0.0-Datasheet.pdf allOf: + - if: + contains: + const: d + then: + contains: + const: f # Zcb depends on Zca - if: contains: