Message ID | 20241210142353.6457-2-yongxuan.wang@sifive.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | riscv: signal: fix the size of signal frame | expand |
Hi Young-Xuan, Yong-Xuan Wang <yongxuan.wang@sifive.com> 於 2024年12月10日 週二 下午10:24寫道: > > The signal context of certain RISC-V extensions will be appended after > struct __riscv_extra_ext_header, which already includes an empty context > header. Therefore, there is no need to preserve a separate hdr for the > END of signal context. > > Fixes: 8ee0b41898fa ("riscv: signal: Add sigcontext save/restore for vector") > Signed-off-by: Yong-Xuan Wang <yongxuan.wang@sifive.com> > Reviewed-by: Zong Li <zong.li@sifive.com> > --- > arch/riscv/kernel/signal.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/arch/riscv/kernel/signal.c b/arch/riscv/kernel/signal.c > index dcd282419456..c3c517b9eee5 100644 > --- a/arch/riscv/kernel/signal.c > +++ b/arch/riscv/kernel/signal.c > @@ -215,12 +215,6 @@ static size_t get_rt_frame_size(bool cal_all) > if (cal_all || riscv_v_vstate_query(task_pt_regs(current))) > total_context_size += riscv_v_sc_size; > } > - /* > - * Preserved a __riscv_ctx_hdr for END signal context header if an > - * extension uses __riscv_extra_ext_header > - */ > - if (total_context_size) > - total_context_size += sizeof(struct __riscv_ctx_hdr); > > frame_size += total_context_size; > > -- > 2.17.1 > Thanks for the findings Reviewed-by: Andy Chiu <AndybnAC@gmail.com>
diff --git a/arch/riscv/kernel/signal.c b/arch/riscv/kernel/signal.c index dcd282419456..c3c517b9eee5 100644 --- a/arch/riscv/kernel/signal.c +++ b/arch/riscv/kernel/signal.c @@ -215,12 +215,6 @@ static size_t get_rt_frame_size(bool cal_all) if (cal_all || riscv_v_vstate_query(task_pt_regs(current))) total_context_size += riscv_v_sc_size; } - /* - * Preserved a __riscv_ctx_hdr for END signal context header if an - * extension uses __riscv_extra_ext_header - */ - if (total_context_size) - total_context_size += sizeof(struct __riscv_ctx_hdr); frame_size += total_context_size;