diff mbox series

[1/4] dt-bindings: reset: sophgo: Add CV1800B support

Message ID 20250209122936.2338821-2-inochiama@gmail.com (mailing list archive)
State Handled Elsewhere
Headers show
Series riscv: sophgo: cv18xx: Add reset generator support | expand

Checks

Context Check Description
bjorn/pre-ci_am success Success
bjorn/build-rv32-defconfig success build-rv32-defconfig
bjorn/build-rv64-clang-allmodconfig success build-rv64-clang-allmodconfig
bjorn/build-rv64-gcc-allmodconfig success build-rv64-gcc-allmodconfig
bjorn/build-rv64-nommu-k210-defconfig success build-rv64-nommu-k210-defconfig
bjorn/build-rv64-nommu-k210-virt success build-rv64-nommu-k210-virt
bjorn/checkpatch success checkpatch
bjorn/dtb-warn-rv64 success dtb-warn-rv64
bjorn/header-inline success header-inline
bjorn/kdoc success kdoc
bjorn/module-param success module-param
bjorn/verify-fixes success verify-fixes
bjorn/verify-signedoff success verify-signedoff

Commit Message

Inochi Amaoto Feb. 9, 2025, 12:29 p.m. UTC
Add bindings for the reset generator on the SOPHGO CV1800B
RISC-V SoC.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
 .../devicetree/bindings/reset/sophgo,sg2042-reset.yaml        | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Chen Wang Feb. 10, 2025, 1 a.m. UTC | #1
On 2025/2/9 20:29, Inochi Amaoto wrote:
> Add bindings for the reset generator on the SOPHGO CV1800B
> RISC-V SoC.
>
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
>   .../devicetree/bindings/reset/sophgo,sg2042-reset.yaml        | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> index 76e1931f0908..73f8009698f3 100644
> --- a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> +++ b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> @@ -11,7 +11,9 @@ maintainers:
>   
>   properties:
>     compatible:
> -    const: sophgo,sg2042-reset
> +    enum:
> +      - sophgo,cv1800b-reset

I have a question, if this patchset is for all cv18xx products? If so, 
can we use "cv18xx" instead of "cv1800b"?


> +      - sophgo,sg2042-reset
>   
>     reg:
>       maxItems: 1
Inochi Amaoto Feb. 10, 2025, 4:44 a.m. UTC | #2
On Mon, Feb 10, 2025 at 09:00:24AM +0800, Chen Wang wrote:
> 
> On 2025/2/9 20:29, Inochi Amaoto wrote:
> > Add bindings for the reset generator on the SOPHGO CV1800B
> > RISC-V SoC.
> > 
> > Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> > ---
> >   .../devicetree/bindings/reset/sophgo,sg2042-reset.yaml        | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> > index 76e1931f0908..73f8009698f3 100644
> > --- a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> > +++ b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
> > @@ -11,7 +11,9 @@ maintainers:
> >   properties:
> >     compatible:
> > -    const: sophgo,sg2042-reset
> > +    enum:
> > +      - sophgo,cv1800b-reset
> 
> I have a question, if this patchset is for all cv18xx products? If so, can
> we use "cv18xx" instead of "cv1800b"?
> 

Negative, we can only use a real board compatiable for the device.
This is why I use cv1800b as a base.

Regards,
Inochi
Rob Herring Feb. 12, 2025, 7:49 p.m. UTC | #3
On Sun, 09 Feb 2025 20:29:32 +0800, Inochi Amaoto wrote:
> Add bindings for the reset generator on the SOPHGO CV1800B
> RISC-V SoC.
> 
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
>  .../devicetree/bindings/reset/sophgo,sg2042-reset.yaml        | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
index 76e1931f0908..73f8009698f3 100644
--- a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
+++ b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
@@ -11,7 +11,9 @@  maintainers:
 
 properties:
   compatible:
-    const: sophgo,sg2042-reset
+    enum:
+      - sophgo,cv1800b-reset
+      - sophgo,sg2042-reset
 
   reg:
     maxItems: 1