| Context |
Check |
Description |
| bjorn/pre-ci_am |
success
|
Success
|
| bjorn/build-rv32-defconfig |
success
|
build-rv32-defconfig
|
| bjorn/build-rv64-clang-allmodconfig |
success
|
build-rv64-clang-allmodconfig
|
| bjorn/build-rv64-gcc-allmodconfig |
success
|
build-rv64-gcc-allmodconfig
|
| bjorn/build-rv64-nommu-k210-defconfig |
success
|
build-rv64-nommu-k210-defconfig
|
| bjorn/build-rv64-nommu-k210-virt |
success
|
build-rv64-nommu-k210-virt
|
| bjorn/checkpatch |
success
|
checkpatch
|
| bjorn/dtb-warn-rv64 |
success
|
dtb-warn-rv64
|
| bjorn/header-inline |
success
|
header-inline
|
| bjorn/kdoc |
success
|
kdoc
|
| bjorn/module-param |
success
|
module-param
|
| bjorn/verify-fixes |
success
|
verify-fixes
|
| bjorn/verify-signedoff |
success
|
verify-signedoff
|
@@ -420,17 +420,8 @@ static int eqr_probe(struct auxiliary_device *adev,
int ret;
/*
- * We are an auxiliary device of clk-eyeq. We do not have an OF node by
- * default; let's reuse our parent's OF node.
- */
- WARN_ON(dev->of_node);
- device_set_of_node_from_dev(dev, dev->parent);
- if (!dev->of_node)
- return -ENODEV;
-
- /*
- * Using our newfound OF node, we can get match data. We cannot use
- * device_get_match_data() because it does not match reused OF nodes.
+ * Get match data. We cannot use device_get_match_data() because it does
+ * not accept reused OF nodes; see device_set_of_node_from_dev().
*/
match = of_match_node(dev->driver->of_match_table, dev->of_node);
if (!match || !match->data)
Our parent driver (clk-eyeq) now does the device_set_of_node_from_dev(dev, dev->parent) call through the newly introduced devm_auxiliary_device_create() helper. Doing it again in the reset-eyeq probe would be redundant. Drop both the WARN_ON() and the device_set_of_node_from_dev() call. Also fix the following comment that talks about "our newfound OF node". Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> --- drivers/reset/reset-eyeq.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-)