| Message ID | 20250213020900.745551-3-inochiama@gmail.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | reset: introduct generic bit reset controller | expand |
| Context | Check | Description |
|---|---|---|
| bjorn/pre-ci_am | success | Success |
| bjorn/build-rv32-defconfig | success | build-rv32-defconfig |
| bjorn/build-rv64-clang-allmodconfig | success | build-rv64-clang-allmodconfig |
| bjorn/build-rv64-gcc-allmodconfig | success | build-rv64-gcc-allmodconfig |
| bjorn/build-rv64-nommu-k210-defconfig | success | build-rv64-nommu-k210-defconfig |
| bjorn/build-rv64-nommu-k210-virt | success | build-rv64-nommu-k210-virt |
| bjorn/checkpatch | success | checkpatch |
| bjorn/dtb-warn-rv64 | success | dtb-warn-rv64 |
| bjorn/header-inline | success | header-inline |
| bjorn/kdoc | success | kdoc |
| bjorn/module-param | success | module-param |
| bjorn/verify-fixes | success | verify-fixes |
| bjorn/verify-signedoff | success | verify-signedoff |
On Thu, Feb 13, 2025 at 10:08:55AM +0800, Inochi Amaoto wrote: > Add support for generic bit reset device. > > Signed-off-by: Inochi Amaoto <inochiama@gmail.com> > --- > drivers/reset/reset-simple.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c > index 276067839830..a24f8fcc6a06 100644 > --- a/drivers/reset/reset-simple.c > +++ b/drivers/reset/reset-simple.c > @@ -148,6 +148,9 @@ static const struct of_device_id reset_simple_dt_ids[] = { > .data = &reset_simple_active_low }, > { .compatible = "brcm,bcm4908-misc-pcie-reset", > .data = &reset_simple_active_low }, > + { .compatible = "reset-simple-high" }, > + { .compatible = "reset-simple-low", > + .data = &reset_simple_active_low }, So what is the point of the binding? Best regards, Krzysztof
On Thu, Feb 13, 2025 at 10:36:14AM +0100, Krzysztof Kozlowski wrote: > On Thu, Feb 13, 2025 at 10:08:55AM +0800, Inochi Amaoto wrote: > > Add support for generic bit reset device. > > > > Signed-off-by: Inochi Amaoto <inochiama@gmail.com> > > --- > > drivers/reset/reset-simple.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c > > index 276067839830..a24f8fcc6a06 100644 > > --- a/drivers/reset/reset-simple.c > > +++ b/drivers/reset/reset-simple.c > > @@ -148,6 +148,9 @@ static const struct of_device_id reset_simple_dt_ids[] = { > > .data = &reset_simple_active_low }, > > { .compatible = "brcm,bcm4908-misc-pcie-reset", > > .data = &reset_simple_active_low }, > > + { .compatible = "reset-simple-high" }, > > + { .compatible = "reset-simple-low", > > + .data = &reset_simple_active_low }, > > So what is the point of the binding? > I wanted to add these comptaibles as a base to avoid adding too many compatible in driver. Regards, Inochi
diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c index 276067839830..a24f8fcc6a06 100644 --- a/drivers/reset/reset-simple.c +++ b/drivers/reset/reset-simple.c @@ -148,6 +148,9 @@ static const struct of_device_id reset_simple_dt_ids[] = { .data = &reset_simple_active_low }, { .compatible = "brcm,bcm4908-misc-pcie-reset", .data = &reset_simple_active_low }, + { .compatible = "reset-simple-high" }, + { .compatible = "reset-simple-low", + .data = &reset_simple_active_low }, { .compatible = "snps,dw-high-reset" }, { .compatible = "snps,dw-low-reset", .data = &reset_simple_active_low },
Add support for generic bit reset device. Signed-off-by: Inochi Amaoto <inochiama@gmail.com> --- drivers/reset/reset-simple.c | 3 +++ 1 file changed, 3 insertions(+)