[04/10] dt-bindings: riscv: Add SiFive HiFive Premier P550 board

Commit Message

Pinkesh Vaghela March 11, 2025, 7:34 a.m. UTC

From: Pritesh Patel <[e-mail]>

Add DT binding documentation for the ESWIN EIC7700 SoC and
HiFive Premier P550 Board

Signed-off-by: Pritesh Patel <[e-mail]>
Reviewed-by: Samuel Holland <[e-mail]>
Signed-off-by: Pinkesh Vaghela <[e-mail]>
---
 .../devicetree/bindings/riscv/eswin.yaml      | 29 +++++++++++++++++++
 MAINTAINERS                                   |  6 ++++
 2 files changed, 35 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/riscv/eswin.yaml

Comments

Matthias Brugger March 12, 2025, 12:03 p.m. UTC | #1

On Tue, Mar 11, 2025 at 01:04:26PM +0530, Pinkesh Vaghela wrote:
> From: Pritesh Patel <[e-mail]>
> 
> Add DT binding documentation for the ESWIN EIC7700 SoC and
> HiFive Premier P550 Board
> 
> Signed-off-by: Pritesh Patel <[e-mail]>
> Reviewed-by: Samuel Holland <[e-mail]>
> Signed-off-by: Pinkesh Vaghela <[e-mail]>
> ---
>  .../devicetree/bindings/riscv/eswin.yaml      | 29 +++++++++++++++++++
>  MAINTAINERS                                   |  6 ++++
>  2 files changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/riscv/eswin.yaml
> 
> diff --git a/Documentation/devicetree/bindings/riscv/eswin.yaml b/Documentation/devicetree/bindings/riscv/eswin.yaml
> new file mode 100644
> index 000000000000..c603c45eef22
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/riscv/eswin.yaml
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/riscv/eswin.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ESWIN SoC-based boards
> +
> +maintainers:
> +  - Min Lin <[e-mail]>
> +  - Pinkesh Vaghela <[e-mail]>
> +  - Pritesh Patel <[e-mail]>
> +
> +description:
> +  ESWIN SoC-based boards
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - sifive,hifive-premier-p550
> +          - const: eswin,eic7700

That should be the other way around. You could have, let's say eic7701
with different peripherals but smae p550 IP core. I don't expect a new
eic7700 with a CPU IP other then p550.

Regards,
Matthias

> +
> +additionalProperties: true
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 25c86f47353d..901d0e0adb25 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8572,6 +8572,12 @@ L:	[e-mail]
>  S:	Maintained
>  F:	drivers/net/can/usb/esd_usb.c
>  
> +ESWIN DEVICETREES
> +M:	Min Lin <[e-mail]>
> +M:	Pinkesh Vaghela <[e-mail]>
> +M:	Pritesh Patel <[e-mail]>
> +S:	Maintained
> +
>  ET131X NETWORK DRIVER
>  M:	Mark Einon <[e-mail]>
>  S:	Odd Fixes
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> linux-riscv mailing list
> [e-mail]
> http://lists.infradead.org/mailman/listinfo/linux-riscv

Conor Dooley March 12, 2025, 12:50 p.m. UTC | #2

On Wed, Mar 12, 2025 at 01:03:09PM +0100, Matthias Brugger wrote:
> On Tue, Mar 11, 2025 at 01:04:26PM +0530, Pinkesh Vaghela wrote:
> > From: Pritesh Patel <[e-mail]>
> > 
> > Add DT binding documentation for the ESWIN EIC7700 SoC and
> > HiFive Premier P550 Board
> > 
> > Signed-off-by: Pritesh Patel <[e-mail]>
> > Reviewed-by: Samuel Holland <[e-mail]>
> > Signed-off-by: Pinkesh Vaghela <[e-mail]>
> > ---
> >  .../devicetree/bindings/riscv/eswin.yaml      | 29 +++++++++++++++++++
> >  MAINTAINERS                                   |  6 ++++
> >  2 files changed, 35 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/riscv/eswin.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/riscv/eswin.yaml b/Documentation/devicetree/bindings/riscv/eswin.yaml
> > new file mode 100644
> > index 000000000000..c603c45eef22
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/riscv/eswin.yaml
> > @@ -0,0 +1,29 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/riscv/eswin.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ESWIN SoC-based boards
> > +
> > +maintainers:
> > +  - Min Lin <[e-mail]>
> > +  - Pinkesh Vaghela <[e-mail]>
> > +  - Pritesh Patel <[e-mail]>
> > +
> > +description:
> > +  ESWIN SoC-based boards
> > +
> > +properties:
> > +  $nodename:
> > +    const: '/'
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - sifive,hifive-premier-p550
> > +          - const: eswin,eic7700
> 
> That should be the other way around. You could have, let's say eic7701
> with different peripherals but smae p550 IP core. I don't expect a new
> eic7700 with a CPU IP other then p550.

No, this is correct. The SoC is made by Eswin (eic7700) and the board
(hifive premier) by SiFive. None of the compatibles listed here are for
the IP core.

If there's another SoC with different peripherals and the same p550 IP
core, I would expect a new SoC compatible /and/ a new board compatible.

Cheers,
Conor.

Matthias Brugger March 12, 2025, 12:52 p.m. UTC | #3

On 12/03/2025 13:50, Conor Dooley wrote:
> On Wed, Mar 12, 2025 at 01:03:09PM +0100, Matthias Brugger wrote:
>> On Tue, Mar 11, 2025 at 01:04:26PM +0530, Pinkesh Vaghela wrote:
>>> From: Pritesh Patel <[e-mail]>
>>>
>>> Add DT binding documentation for the ESWIN EIC7700 SoC and
>>> HiFive Premier P550 Board
>>>
>>> Signed-off-by: Pritesh Patel <[e-mail]>
>>> Reviewed-by: Samuel Holland <[e-mail]>
>>> Signed-off-by: Pinkesh Vaghela <[e-mail]>
>>> ---
>>>   .../devicetree/bindings/riscv/eswin.yaml      | 29 +++++++++++++++++++
>>>   MAINTAINERS                                   |  6 ++++
>>>   2 files changed, 35 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/riscv/eswin.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/riscv/eswin.yaml b/Documentation/devicetree/bindings/riscv/eswin.yaml
>>> new file mode 100644
>>> index 000000000000..c603c45eef22
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/riscv/eswin.yaml
>>> @@ -0,0 +1,29 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/riscv/eswin.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: ESWIN SoC-based boards
>>> +
>>> +maintainers:
>>> +  - Min Lin <[e-mail]>
>>> +  - Pinkesh Vaghela <[e-mail]>
>>> +  - Pritesh Patel <[e-mail]>
>>> +
>>> +description:
>>> +  ESWIN SoC-based boards
>>> +
>>> +properties:
>>> +  $nodename:
>>> +    const: '/'
>>> +  compatible:
>>> +    oneOf:
>>> +      - items:
>>> +          - enum:
>>> +              - sifive,hifive-premier-p550
>>> +          - const: eswin,eic7700
>>
>> That should be the other way around. You could have, let's say eic7701
>> with different peripherals but smae p550 IP core. I don't expect a new
>> eic7700 with a CPU IP other then p550.
> 
> No, this is correct. The SoC is made by Eswin (eic7700) and the board
> (hifive premier) by SiFive. None of the compatibles listed here are for
> the IP core.
> 
> If there's another SoC with different peripherals and the same p550 IP
> core, I would expect a new SoC compatible /and/ a new board compatible.
> 

Right I mixed up CPU IP core and SoC, so:

Reviewed-by: Matthias Brugger <[e-mail]>

Krzysztof Kozlowski March 12, 2025, 12:55 p.m. UTC | #4

On 11/03/2025 08:34, Pinkesh Vaghela wrote:
> From: Pritesh Patel <[e-mail]>
> 
> Add DT binding documentation for the ESWIN EIC7700 SoC and
> HiFive Premier P550 Board
> 
> Signed-off-by: Pritesh Patel <[e-mail]>
> Reviewed-by: Samuel Holland <[e-mail]>


This Rb tag appears everywhere, while this is a v1 and it was not given
on the lists, so I want to be sure this was not some blank tag added to
series because someone said "yeah, lgtm". Was it really review as in
*reviewers statement of oversight*?

> Signed-off-by: Pinkesh Vaghela <[e-mail]>
> ---
..


> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 25c86f47353d..901d0e0adb25 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8572,6 +8572,12 @@ L:	[e-mail]
>  S:	Maintained
>  F:	drivers/net/can/usb/esd_usb.c
>  
> +ESWIN DEVICETREES
> +M:	Min Lin <[e-mail]>
> +M:	Pinkesh Vaghela <[e-mail]>
> +M:	Pritesh Patel <[e-mail]>
> +S:	Maintained

If you add this entry here, then add the path for the eswin binding.

Best regards,
Krzysztof

Pinkesh Vaghela March 12, 2025, 2:25 p.m. UTC | #5

Hi Krzysztof,

On Tue, Mar 12, 2025 at 12:55:52PM +0530, Krzysztof Kozlowski wrote: 
> On 11/03/2025 08:34, Pinkesh Vaghela wrote:
> > From: Pritesh Patel <[e-mail]>
> >
> > Add DT binding documentation for the ESWIN EIC7700 SoC and HiFive
> > Premier P550 Board
> >
> > Signed-off-by: Pritesh Patel <[e-mail]>
> > Reviewed-by: Samuel Holland <[e-mail]>
> 
> 
> This Rb tag appears everywhere, while this is a v1 and it was not given on the
> lists, so I want to be sure this was not some blank tag added to series because
> someone said "yeah, lgtm". Was it really review as in *reviewers statement of
> oversight*?

The "Reviewed-by" tag was added because we had a thorough review of all the
patches from Samuel Holland before posting.

> 
> > Signed-off-by: Pinkesh Vaghela <[e-mail]>
> > ---
> ..
> 
> 
> > +
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS index
> > 25c86f47353d..901d0e0adb25 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -8572,6 +8572,12 @@ L:     [e-mail]
> >  S:   Maintained
> >  F:   drivers/net/can/usb/esd_usb.c
> >
> > +ESWIN DEVICETREES
> > +M:   Min Lin <[e-mail]>
> > +M:   Pinkesh Vaghela <[e-mail]>
> > +M:   Pritesh Patel <[e-mail]>
> > +S:   Maintained
> 
> If you add this entry here, then add the path for the eswin binding.

Thanks for the feedback. I will add this in v2.

Regards,
Pinkesh

> 
> Best regards,
> Krzysztof

Patch

diff --git a/Documentation/devicetree/bindings/riscv/eswin.yaml b/Documentation/devicetree/bindings/riscv/eswin.yaml
new file mode 100644
index 000000000000..c603c45eef22
--- /dev/null
+++ b/Documentation/devicetree/bindings/riscv/eswin.yaml
@@ -0,0 +1,29 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/riscv/eswin.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ESWIN SoC-based boards
+
+maintainers:
+  - Min Lin <[e-mail]>
+  - Pinkesh Vaghela <[e-mail]>
+  - Pritesh Patel <[e-mail]>
+
+description:
+  ESWIN SoC-based boards
+
+properties:
+  $nodename:
+    const: '/'
+  compatible:
+    oneOf:
+      - items:
+          - enum:
+              - sifive,hifive-premier-p550
+          - const: eswin,eic7700
+
+additionalProperties: true
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 25c86f47353d..901d0e0adb25 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8572,6 +8572,12 @@  L:	[e-mail]
 S:	Maintained
 F:	drivers/net/can/usb/esd_usb.c
 
+ESWIN DEVICETREES
+M:	Min Lin <[e-mail]>
+M:	Pinkesh Vaghela <[e-mail]>
+M:	Pritesh Patel <[e-mail]>
+S:	Maintained
+
 ET131X NETWORK DRIVER
 M:	Mark Einon <[e-mail]>
 S:	Odd Fixes