| Message ID | 20250411131423.3802611-4-guodong@riscstar.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | pwm: Update PWM_PXA driver for SpacemiT K1 | expand |
| Context | Check | Description |
|---|---|---|
| bjorn/pre-ci_am | fail | Failed to apply series |
On Fri, Apr 11, 2025 at 09:14:17PM +0800, Guodong Xu wrote: > Add "spacemit,k1-pwm" as a compatible string to support the PWM > controller on the SpacemiT K1 platform. > > Signed-off-by: Guodong Xu <guodong@riscstar.com> > --- > Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml > index 9640d4b627c2..1e3cabf6a89a 100644 > --- a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml > +++ b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml > @@ -19,6 +19,7 @@ properties: > - marvell,pxa270-pwm > - marvell,pxa168-pwm > - marvell,pxa910-pwm > + - spacemit,k1-pwm The driver doesn't appear to handle this differently to existing compatibles, why is a fallback not used? > > reg: > # Length should be 0x10 > -- > 2.43.0 >
On Sat, Apr 12, 2025 at 12:43 AM Conor Dooley <conor@kernel.org> wrote: > > On Fri, Apr 11, 2025 at 09:14:17PM +0800, Guodong Xu wrote: > > Add "spacemit,k1-pwm" as a compatible string to support the PWM > > controller on the SpacemiT K1 platform. > > > > Signed-off-by: Guodong Xu <guodong@riscstar.com> > > --- > > Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml > > index 9640d4b627c2..1e3cabf6a89a 100644 > > --- a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml > > +++ b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml > > @@ -19,6 +19,7 @@ properties: > > - marvell,pxa270-pwm > > - marvell,pxa168-pwm > > - marvell,pxa910-pwm > > + - spacemit,k1-pwm > > The driver doesn't appear to handle this differently to existing > compatibles, why is a fallback not used? > The only difference in the SpacemiT K1 PWM controller is the addition of a resets line. This property is not used by any existing PXA-based platforms. Since resets is defined as optional, I agree that continuing to use the existing marvell,pxa... compatible string is reasonable. I'll update the next version accordingly and include an explanation of this decision in the commit message. -Guodong > > > > reg: > > # Length should be 0x10 > > -- > > 2.43.0 > >
diff --git a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml index 9640d4b627c2..1e3cabf6a89a 100644 --- a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml @@ -19,6 +19,7 @@ properties: - marvell,pxa270-pwm - marvell,pxa168-pwm - marvell,pxa910-pwm + - spacemit,k1-pwm reg: # Length should be 0x10
Add "spacemit,k1-pwm" as a compatible string to support the PWM controller on the SpacemiT K1 platform. Signed-off-by: Guodong Xu <guodong@riscstar.com> --- Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml | 1 + 1 file changed, 1 insertion(+)