| Message ID | 20250412074423.38517-8-heylenay@4d2.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | Add clock controller support for SpacemiT K1 | expand |
| Context | Check | Description |
|---|---|---|
| bjorn/pre-ci_am | success | Success |
| bjorn/build-rv32-defconfig | success | build-rv32-defconfig |
| bjorn/build-rv64-clang-allmodconfig | success | build-rv64-clang-allmodconfig |
| bjorn/build-rv64-gcc-allmodconfig | success | build-rv64-gcc-allmodconfig |
| bjorn/build-rv64-nommu-k210-defconfig | success | build-rv64-nommu-k210-defconfig |
| bjorn/build-rv64-nommu-k210-virt | success | build-rv64-nommu-k210-virt |
| bjorn/checkpatch | success | checkpatch |
| bjorn/dtb-warn-rv64 | success | dtb-warn-rv64 |
| bjorn/header-inline | success | header-inline |
| bjorn/kdoc | success | kdoc |
| bjorn/module-param | success | module-param |
| bjorn/verify-fixes | success | verify-fixes |
| bjorn/verify-signedoff | success | verify-signedoff |
On 4/12/25 2:44 AM, Haylen Chu wrote: > Clock controller unit, or CCU, generates various clocks frequency for > peripherals integrated in SpacemiT K1 SoC and is essential for normal > operation. Let's enable it as built-in driver in defconfig. > > Signed-off-by: Haylen Chu <heylenay@4d2.org> I know Inochi wanted this to be "m", but you can see that SOPHGO sets it to "y". Meanwhile SIFIVE uses a default value for its CLK_SIFIVE and CLK_SIFIVE_PRCI config options. I'm not going to solve this, so I'll just say this looks good. Reviewed-by: Alex Elder <elder@riscstar.com> > --- > arch/riscv/configs/defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig > index 3c8e16d71e17..4888529df1d8 100644 > --- a/arch/riscv/configs/defconfig > +++ b/arch/riscv/configs/defconfig > @@ -250,6 +250,8 @@ CONFIG_CLK_SOPHGO_CV1800=y > CONFIG_CLK_SOPHGO_SG2042_PLL=y > CONFIG_CLK_SOPHGO_SG2042_CLKGEN=y > CONFIG_CLK_SOPHGO_SG2042_RPGATE=y > +CONFIG_SPACEMIT_CCU=y > +CONFIG_SPACEMIT_K1_CCU=y > CONFIG_SUN8I_DE2_CCU=m > CONFIG_SUN50I_IOMMU=y > CONFIG_RPMSG_CHAR=y
On Mon, Apr 14, 2025 at 01:12:32PM -0500, Alex Elder wrote: > On 4/12/25 2:44 AM, Haylen Chu wrote: > > Clock controller unit, or CCU, generates various clocks frequency for > > peripherals integrated in SpacemiT K1 SoC and is essential for normal > > operation. Let's enable it as built-in driver in defconfig. > > > > Signed-off-by: Haylen Chu <heylenay@4d2.org> > > I know Inochi wanted this to be "m", but you can see that > SOPHGO sets it to "y". Meanwhile SIFIVE uses a default > value for its CLK_SIFIVE and CLK_SIFIVE_PRCI config options. > > I'm not going to solve this, so I'll just say this looks good. > The clock and pinctrl are exceptions for me, It is OK for me to set "y" for these two device in defconfig. The thing I only asked for is a tristate entry in the kconfig, so we can go with a module if necessary. Regards, Inochi
diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig index 3c8e16d71e17..4888529df1d8 100644 --- a/arch/riscv/configs/defconfig +++ b/arch/riscv/configs/defconfig @@ -250,6 +250,8 @@ CONFIG_CLK_SOPHGO_CV1800=y CONFIG_CLK_SOPHGO_SG2042_PLL=y CONFIG_CLK_SOPHGO_SG2042_CLKGEN=y CONFIG_CLK_SOPHGO_SG2042_RPGATE=y +CONFIG_SPACEMIT_CCU=y +CONFIG_SPACEMIT_K1_CCU=y CONFIG_SUN8I_DE2_CCU=m CONFIG_SUN50I_IOMMU=y CONFIG_RPMSG_CHAR=y
Clock controller unit, or CCU, generates various clocks frequency for peripherals integrated in SpacemiT K1 SoC and is essential for normal operation. Let's enable it as built-in driver in defconfig. Signed-off-by: Haylen Chu <heylenay@4d2.org> --- arch/riscv/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+)