| Message ID | f73a0aead89e1426b146c4c64f797aa035868bf0.1643360419.git.geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: interrupt-controller: sifive, plic: Miscellaneous improvements | expand |
On Fri, Jan 28, 2022 at 2:34 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > The number of interrupts lacks an upper bound, thus assuming one, > causing properly grouped "interrupts-extended" properties to be flagged > as an error by "make dtbs_check". > > Fix this by adding the missing "maxItems", using the architectural > maximum of 15872 interrupts. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > Acked-by: Rob Herring <robh@kernel.org> Looks good to me. Reviewed-by: Anup Patel <anup@brainfault.org> Regards, Anup > --- > v4: > - Use architectural maximum instead of practical maximum of 9, > > v3: > - Add Acked-by, > > v2: > - Split in two patches, > - Improve patch description and document limit rationale. > --- > .../bindings/interrupt-controller/sifive,plic-1.0.0.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > index 28b6b17fe4b26778..57c06126c99502fa 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > @@ -62,6 +62,7 @@ properties: > > interrupts-extended: > minItems: 1 > + maxItems: 15872 > description: > Specifies which contexts are connected to the PLIC, with "-1" specifying > that a context is not present. Each node pointed to should be a > -- > 2.25.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
> The number of interrupts lacks an upper bound, thus assuming one, > causing properly grouped "interrupts-extended" properties to be flagged > as an error by "make dtbs_check". > > Fix this by adding the missing "maxItems", using the architectural > maximum of 15872 interrupts. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > Acked-by: Rob Herring <robh@kernel.org> > --- > v4: > - Use architectural maximum instead of practical maximum of 9, > > v3: > - Add Acked-by, > > v2: > - Split in two patches, > - Improve patch description and document limit rationale. > --- > .../bindings/interrupt-controller/sifive,plic-1.0.0.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > index 28b6b17fe4b26778..57c06126c99502fa 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml > @@ -62,6 +62,7 @@ properties: > > interrupts-extended: > minItems: 1 > + maxItems: 15872 > description: > Specifies which contexts are connected to the PLIC, with "-1" specifying > that a context is not present. Each node pointed to should be a > -- > 2.25.1 As with the clint - clears errors on the icicle dt, so fwiw: Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Fri, 28 Jan 2022 17:57:04 +0000, Conor Dooley <mail@conchuod.ie> wrote: > > [1 PGP/MIME version identification <application/pgp-encrypted (7bit)>] > [2 OpenPGP encrypted message <application/octet-stream (7bit)>] Please refrain from posting encrypted messages to the mailing lists. M.
On 28/01/2022 18:51, Marc Zyngier wrote: > On Fri, 28 Jan 2022 17:57:04 +0000, > Conor Dooley <mail@conchuod.ie> wrote: >> >> [1 PGP/MIME version identification <application/pgp-encrypted (7bit)>] >> [2 OpenPGP encrypted message <application/octet-stream (7bit)>] > > Please refrain from posting encrypted messages to the mailing lists. > > M. Apologies - not my usual mail client. It appears to have decided that you (and Rob) should get it encrypted even though I had that disabled. Actually doing so also would appear to be non trivial. I am hoping but not expecting to have fixed it. The mail to the list itself looks to be fine however. > > -- > Without deviation from the norm, progress is not possible.
diff --git a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml index 28b6b17fe4b26778..57c06126c99502fa 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml @@ -62,6 +62,7 @@ properties: interrupts-extended: minItems: 1 + maxItems: 15872 description: Specifies which contexts are connected to the PLIC, with "-1" specifying that a context is not present. Each node pointed to should be a