| Message ID | tencent_A5B50F1D87711D625443361A3BF996042B09@qq.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | riscv: add initial support for Canaan Kendryte K230 | expand |
On 07/04/2024 03:29, Yangyu Chen wrote: > The thead,c908 is a RISC-V CPU core from T-HEAD Semiconductor which used > in Canaan Kendryte K230 SoC. > > Signed-off-by: Yangyu Chen <cyy@cyyself.name> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline), work on fork of kernel (don't, instead use mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
> On Apr 8, 2024, at 00:01, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 07/04/2024 03:29, Yangyu Chen wrote: >> The thead,c908 is a RISC-V CPU core from T-HEAD Semiconductor which used >> in Canaan Kendryte K230 SoC. >> >> Signed-off-by: Yangyu Chen <cyy@cyyself.name> > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline), work on fork of kernel > (don't, instead use mainline) or you ignore some maintainers (really > don't). Just use b4 and everything should be fine, although remember > about `b4 prep --auto-to-cc` if you added new patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time. > > Please kindly resend and include all necessary To/Cc entries. > Sorry for the trouble caused. I accidentally removed some CC from the git send-email command in the v6 version of this series and sent the v7 and v8, including lkml and linux-dt list. I just want to remove linux-gpio and linux-clk list and the corresponding maintainer since I separate the patch in the v7 revision. I will check it more carefully the next time. Now, I have sent the patch v8 resend version. Link: https://lore.kernel.org/linux-riscv/tencent_22BA0425B4DF1CA1713B62E4423C1BFBF809@qq.com/ Thanks, Yangyu Chen > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/riscv/cpus.yaml b/Documentation/devicetree/bindings/riscv/cpus.yaml index d87dd50f1a4b..d067f2a468ee 100644 --- a/Documentation/devicetree/bindings/riscv/cpus.yaml +++ b/Documentation/devicetree/bindings/riscv/cpus.yaml @@ -47,6 +47,7 @@ properties: - sifive,u74 - sifive,u74-mc - thead,c906 + - thead,c908 - thead,c910 - thead,c920 - const: riscv