Message ID | 20220430121902.59895-7-krzysztof.kozlowski@linaro.org (mailing list archive) |
---|---|
State | Accepted |
Commit | d0b05d3820fa1b688b192699017f95f8a565523b |
Headers | show |
Series | ARM/arm64: dts: drop useless 'dma-channels/requests' properties | expand |
On Sat, 30 Apr 2022 14:18:59 +0200, Krzysztof Kozlowski wrote: > The pl330 DMA controller provides number of DMA channels and requests > through its registers, so duplicating this information (with a chance of > mistakes) in DTS is pointless. Additionally the DTS used always wrong > property names which causes DT schema check failures - the bindings > documented 'dma-channels' and 'dma-requests' properties without leading > hash sign. > > [...] Applied, thanks! [6/9] ARM: dts: s5pv210: drop useless 'dma-channels/requests' properties commit: d0b05d3820fa1b688b192699017f95f8a565523b Best regards,
diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi index ac281f42e8f5..f1b85aae8842 100644 --- a/arch/arm/boot/dts/s5pv210.dtsi +++ b/arch/arm/boot/dts/s5pv210.dtsi @@ -125,8 +125,6 @@ pdma0: dma-controller@e0900000 { clocks = <&clocks CLK_PDMA0>; clock-names = "apb_pclk"; #dma-cells = <1>; - #dma-channels = <8>; - #dma-requests = <32>; }; pdma1: dma-controller@e0a00000 { @@ -137,8 +135,6 @@ pdma1: dma-controller@e0a00000 { clocks = <&clocks CLK_PDMA1>; clock-names = "apb_pclk"; #dma-cells = <1>; - #dma-channels = <8>; - #dma-requests = <32>; }; adc: adc@e1700000 { @@ -526,8 +522,6 @@ mdma1: dma-controller@fa200000 { clocks = <&clocks CLK_MDMA>; clock-names = "apb_pclk"; #dma-cells = <1>; - #dma-channels = <8>; - #dma-requests = <1>; }; rotator: rotator@fa300000 {
The pl330 DMA controller provides number of DMA channels and requests through its registers, so duplicating this information (with a chance of mistakes) in DTS is pointless. Additionally the DTS used always wrong property names which causes DT schema check failures - the bindings documented 'dma-channels' and 'dma-requests' properties without leading hash sign. Reported-by: Rob Herring <robh@kernel.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm/boot/dts/s5pv210.dtsi | 6 ------ 1 file changed, 6 deletions(-)