| Message ID | 20230303145138.29233-2-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 56193b57cd8a65f942e064dbf499a7fa54ca5c74 |
| Headers | show |
| Series | drm: Add Samsung MIPI DSIM bridge | expand |
On 3/3/23 15:51, Jagan Teki wrote: > Exynos DSI already converted into a bridge driver, so bridge > detach will suppose happened during bridge chain removal done > by the bridge core. > > Drop the explicit call chain to detach the bridge. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Changes for v15, v13, v12, v11: > - none > Changes for v10: > - new patch > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > index 06d6513ddaae..df15501b1075 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > @@ -1531,8 +1531,6 @@ static int exynos_dsi_host_detach(struct mipi_dsi_host *host, > struct exynos_dsi *dsi = host_to_dsi(host); > struct drm_device *drm = dsi->encoder.dev; > > - if (dsi->out_bridge->funcs->detach) > - dsi->out_bridge->funcs->detach(dsi->out_bridge); > dsi->out_bridge = NULL; > > if (drm->mode_config.poll_enabled) Considering also the discussion in v15 12/16 Reviewed-by: Marek Vasut <marex@denx.de>
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 06d6513ddaae..df15501b1075 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1531,8 +1531,6 @@ static int exynos_dsi_host_detach(struct mipi_dsi_host *host, struct exynos_dsi *dsi = host_to_dsi(host); struct drm_device *drm = dsi->encoder.dev; - if (dsi->out_bridge->funcs->detach) - dsi->out_bridge->funcs->detach(dsi->out_bridge); dsi->out_bridge = NULL; if (drm->mode_config.poll_enabled)
Exynos DSI already converted into a bridge driver, so bridge detach will suppose happened during bridge chain removal done by the bridge core. Drop the explicit call chain to detach the bridge. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Changes for v15, v13, v12, v11: - none Changes for v10: - new patch drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 -- 1 file changed, 2 deletions(-)