mbox series

[0/7] qla2xxx patches for kernel v4.20

Message ID 20181018224546.189268-1-bvanassche@acm.org (mailing list archive)
Headers show
Series qla2xxx patches for kernel v4.20 | expand

Message

Bart Van Assche Oct. 18, 2018, 10:45 p.m. UTC
Hi Martin,

This is a series with mostly trivial patches for the qla2xxx driver. These
patches address warnings reported by gcc and by the smatch and sparse static
analyzers. Please consider these patches for kernel v4.20.

Thanks,

Bart.

Bart Van Assche (7):
  qla2xxx: Modify fall-through annotations
  qla2xxx: Improve several kernel-doc headers
  qla2xxx: Declare local functions 'static'
  qla2xxx: Make qla2x00_sysfs_write_nvram() easier to analyze
  qla2xxx: Remove a set-but-not-used variable
  qla2xxx: Make sure that qlafx00_ioctl_iosb_entry() initializes 'res'
  qla2xxx: Remove two arguments from qlafx00_error_entry()

 drivers/scsi/qla2xxx/qla_attr.c   |  2 +-
 drivers/scsi/qla2xxx/qla_init.c   |  7 ++++---
 drivers/scsi/qla2xxx/qla_iocb.c   |  4 ++--
 drivers/scsi/qla2xxx/qla_isr.c    |  6 +++---
 drivers/scsi/qla2xxx/qla_mbx.c    |  6 +++---
 drivers/scsi/qla2xxx/qla_mr.c     | 21 +++++++++------------
 drivers/scsi/qla2xxx/qla_nx.c     |  2 +-
 drivers/scsi/qla2xxx/qla_nx2.c    |  2 +-
 drivers/scsi/qla2xxx/qla_os.c     |  6 +++---
 drivers/scsi/qla2xxx/qla_sup.c    |  2 +-
 drivers/scsi/qla2xxx/qla_target.c |  8 ++++----
 11 files changed, 32 insertions(+), 34 deletions(-)

Comments

Madhani, Himanshu Oct. 19, 2018, 4:28 a.m. UTC | #1
Hello Bart, 

> On Oct 18, 2018, at 3:45 PM, Bart Van Assche <bvanassche@acm.org> wrote:
> 
> External Email
> 
> Hi Martin,
> 
> This is a series with mostly trivial patches for the qla2xxx driver. These
> patches address warnings reported by gcc and by the smatch and sparse static
> analyzers. Please consider these patches for kernel v4.20.
> 
> Thanks,
> 
> Bart.
> 
> Bart Van Assche (7):
>  qla2xxx: Modify fall-through annotations
>  qla2xxx: Improve several kernel-doc headers
>  qla2xxx: Declare local functions 'static'
>  qla2xxx: Make qla2x00_sysfs_write_nvram() easier to analyze
>  qla2xxx: Remove a set-but-not-used variable
>  qla2xxx: Make sure that qlafx00_ioctl_iosb_entry() initializes 'res'
>  qla2xxx: Remove two arguments from qlafx00_error_entry()
> 
> drivers/scsi/qla2xxx/qla_attr.c   |  2 +-
> drivers/scsi/qla2xxx/qla_init.c   |  7 ++++---
> drivers/scsi/qla2xxx/qla_iocb.c   |  4 ++--
> drivers/scsi/qla2xxx/qla_isr.c    |  6 +++---
> drivers/scsi/qla2xxx/qla_mbx.c    |  6 +++---
> drivers/scsi/qla2xxx/qla_mr.c     | 21 +++++++++------------
> drivers/scsi/qla2xxx/qla_nx.c     |  2 +-
> drivers/scsi/qla2xxx/qla_nx2.c    |  2 +-
> drivers/scsi/qla2xxx/qla_os.c     |  6 +++---
> drivers/scsi/qla2xxx/qla_sup.c    |  2 +-
> drivers/scsi/qla2xxx/qla_target.c |  8 ++++----
> 11 files changed, 32 insertions(+), 34 deletions(-)
> 
> --
> 2.19.1.568.g152ad8e336-goog
> 

Looks good. 

For the Series

Acked-by: Himanshu Madhani <himanshu.madhani@cavium.com>


Thanks,
- Himanshu
Martin K. Petersen Oct. 24, 2018, 1:32 a.m. UTC | #2
Bart,

> This is a series with mostly trivial patches for the qla2xxx
> driver. These patches address warnings reported by gcc and by the
> smatch and sparse static analyzers. Please consider these patches for
> kernel v4.20.

Applied to 4.20/scsi-queue. Thanks!