| Message ID | 20200614223921.5851-5-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | qla2xxx patches for kernel v5.9 | expand |
On Sun, Jun 14, 2020 at 03:39:16PM -0700, Bart Van Assche wrote: > The following code: > qla82xx_rom_fast_read(ha, 0, &n) > only initializes 'n' if it succeeds. Since 'n' may be reported in a debug > message even if no ROM reads succeeded, initialize 'n' to zero. > > This patch fixes the following sparse warning: > > qla_nx.c:1218: qla82xx_pinit_from_rom() error: uninitialized symbol 'n'. > > Cc: Nilesh Javali <njavali@marvell.com> > Cc: Quinn Tran <qutran@marvell.com> > Cc: Himanshu Madhani <himanshu.madhani@oracle.com> > Cc: Daniel Wagner <dwagner@suse.de> > Cc: Martin Wilck <mwilck@suse.com> > Cc: Roman Bolshakov <r.bolshakov@yadro.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Daniel Wagner <dwagner@suse.de>
Looks good. Reviewed-by: Shyam Sundar <ssundar@marvell.com> > On Jun 14, 2020, at 3:39 PM, Bart Van Assche <bvanassche@acm.org> wrote: > > The following code: > qla82xx_rom_fast_read(ha, 0, &n) > only initializes 'n' if it succeeds. Since 'n' may be reported in a debug > message even if no ROM reads succeeded, initialize 'n' to zero. > > This patch fixes the following sparse warning: > > qla_nx.c:1218: qla82xx_pinit_from_rom() error: uninitialized symbol 'n'. > > Cc: Nilesh Javali <njavali@marvell.com> > Cc: Quinn Tran <qutran@marvell.com> > Cc: Himanshu Madhani <himanshu.madhani@oracle.com> > Cc: Daniel Wagner <dwagner@suse.de> > Cc: Martin Wilck <mwilck@suse.com> > Cc: Roman Bolshakov <r.bolshakov@yadro.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/scsi/qla2xxx/qla_nx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c > index ff365b434a02..71273eb634d3 100644 > --- a/drivers/scsi/qla2xxx/qla_nx.c > +++ b/drivers/scsi/qla2xxx/qla_nx.c > @@ -1167,6 +1167,7 @@ qla82xx_pinit_from_rom(scsi_qla_host_t *vha) > * Offset 4: Offset and number of addr/value pairs > * that present in CRB initialize sequence > */ > + n = 0; > if (qla82xx_rom_fast_read(ha, 0, &n) != 0 || n != 0xcafecafeUL || > qla82xx_rom_fast_read(ha, 4, &n) != 0) { > ql_log(ql_log_fatal, vha, 0x006e,
diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c index ff365b434a02..71273eb634d3 100644 --- a/drivers/scsi/qla2xxx/qla_nx.c +++ b/drivers/scsi/qla2xxx/qla_nx.c @@ -1167,6 +1167,7 @@ qla82xx_pinit_from_rom(scsi_qla_host_t *vha) * Offset 4: Offset and number of addr/value pairs * that present in CRB initialize sequence */ + n = 0; if (qla82xx_rom_fast_read(ha, 0, &n) != 0 || n != 0xcafecafeUL || qla82xx_rom_fast_read(ha, 4, &n) != 0) { ql_log(ql_log_fatal, vha, 0x006e,
The following code: qla82xx_rom_fast_read(ha, 0, &n) only initializes 'n' if it succeeds. Since 'n' may be reported in a debug message even if no ROM reads succeeded, initialize 'n' to zero. This patch fixes the following sparse warning: qla_nx.c:1218: qla82xx_pinit_from_rom() error: uninitialized symbol 'n'. Cc: Nilesh Javali <njavali@marvell.com> Cc: Quinn Tran <qutran@marvell.com> Cc: Himanshu Madhani <himanshu.madhani@oracle.com> Cc: Daniel Wagner <dwagner@suse.de> Cc: Martin Wilck <mwilck@suse.com> Cc: Roman Bolshakov <r.bolshakov@yadro.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/scsi/qla2xxx/qla_nx.c | 1 + 1 file changed, 1 insertion(+)