diff mbox series

[14/14] qla2xxx: Update version to 10.02.06.100-k

Message ID 20210805102005.20183-15-njavali@marvell.com (mailing list archive)
State Superseded
Headers show
Series qla2xxx driver bug fixes | expand

Commit Message

Nilesh Javali Aug. 5, 2021, 10:20 a.m. UTC
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
 drivers/scsi/qla2xxx/qla_version.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Himanshu Madhani Aug. 5, 2021, 3:58 p.m. UTC | #1
> On Aug 5, 2021, at 5:20 AM, Nilesh Javali <njavali@marvell.com> wrote:
> 
> Signed-off-by: Nilesh Javali <njavali@marvell.com>
> ---
> drivers/scsi/qla2xxx/qla_version.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h
> index 2e05dd74b5cb..8b0ace50b52f 100644
> --- a/drivers/scsi/qla2xxx/qla_version.h
> +++ b/drivers/scsi/qla2xxx/qla_version.h
> @@ -6,9 +6,9 @@
> /*
>  * Driver version
>  */
> -#define QLA2XXX_VERSION      "10.02.00.107-k"
> +#define QLA2XXX_VERSION      "10.02.06.100-k"
> 
> #define QLA_DRIVER_MAJOR_VER	10
> #define QLA_DRIVER_MINOR_VER	2
> -#define QLA_DRIVER_PATCH_VER	0
> -#define QLA_DRIVER_BETA_VER	107
> +#define QLA_DRIVER_PATCH_VER	6
> +#define QLA_DRIVER_BETA_VER	100
> -- 
> 2.19.0.rc0
> 

Just curious.. 

Why bump Patch version for the driver? And numbering does not make sense.. please explain

--
Himanshu Madhani	 Oracle Linux Engineering
Nilesh Javali Aug. 5, 2021, 4:22 p.m. UTC | #2
> -----Original Message-----
> From: Himanshu Madhani <himanshu.madhani@oracle.com>
> Sent: Thursday, August 5, 2021 9:28 PM
> To: Nilesh Javali <njavali@marvell.com>
> Cc: Martin Petersen <martin.petersen@oracle.com>; linux-
> scsi@vger.kernel.org; GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> Upstream@marvell.com>
> Subject: [EXT] Re: [PATCH 14/14] qla2xxx: Update version to 10.02.06.100-k
> 
> External Email
> 
> ----------------------------------------------------------------------
> 
> 
> > On Aug 5, 2021, at 5:20 AM, Nilesh Javali <njavali@marvell.com> wrote:
> >
> > Signed-off-by: Nilesh Javali <njavali@marvell.com>
> > ---
> > drivers/scsi/qla2xxx/qla_version.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/scsi/qla2xxx/qla_version.h
> b/drivers/scsi/qla2xxx/qla_version.h
> > index 2e05dd74b5cb..8b0ace50b52f 100644
> > --- a/drivers/scsi/qla2xxx/qla_version.h
> > +++ b/drivers/scsi/qla2xxx/qla_version.h
> > @@ -6,9 +6,9 @@
> > /*
> >  * Driver version
> >  */
> > -#define QLA2XXX_VERSION      "10.02.00.107-k"
> > +#define QLA2XXX_VERSION      "10.02.06.100-k"
> >
> > #define QLA_DRIVER_MAJOR_VER	10
> > #define QLA_DRIVER_MINOR_VER	2
> > -#define QLA_DRIVER_PATCH_VER	0
> > -#define QLA_DRIVER_BETA_VER	107
> > +#define QLA_DRIVER_PATCH_VER	6
> > +#define QLA_DRIVER_BETA_VER	100
> > --
> > 2.19.0.rc0
> >
> 
> Just curious..
> 
> Why bump Patch version for the driver? And numbering does not make
> sense.. please explain

This is just for internalizing and identification purpose, to keep upstream driver version in sync with qla2x out-of-box driver.
The combination of major, minor, patch versions (10.02.06) would let us know association with respective OOB version whereas the beta version 
would tell the series number (100, 200,...) for that particular patch version. It's for internal tracking only. 

Thanks for reviewing the patches. I would send v2 for this series.

Thanks,
Nilesh
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h
index 2e05dd74b5cb..8b0ace50b52f 100644
--- a/drivers/scsi/qla2xxx/qla_version.h
+++ b/drivers/scsi/qla2xxx/qla_version.h
@@ -6,9 +6,9 @@ 
 /*
  * Driver version
  */
-#define QLA2XXX_VERSION      "10.02.00.107-k"
+#define QLA2XXX_VERSION      "10.02.06.100-k"
 
 #define QLA_DRIVER_MAJOR_VER	10
 #define QLA_DRIVER_MINOR_VER	2
-#define QLA_DRIVER_PATCH_VER	0
-#define QLA_DRIVER_BETA_VER	107
+#define QLA_DRIVER_PATCH_VER	6
+#define QLA_DRIVER_BETA_VER	100