diff mbox series

[06/14] qla2xxx: fix debug print of 64G link speed

Message ID 20210805102005.20183-7-njavali@marvell.com (mailing list archive)
State Superseded
Headers show
Series qla2xxx driver bug fixes | expand

Commit Message

Nilesh Javali Aug. 5, 2021, 10:19 a.m. UTC
From: Quinn Tran <qutran@marvell.com>

Fix debug print of 64G link speed.

Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
 drivers/scsi/qla2xxx/qla_isr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Himanshu Madhani Aug. 5, 2021, 3:28 p.m. UTC | #1
> On Aug 5, 2021, at 5:19 AM, Nilesh Javali <njavali@marvell.com> wrote:
> 
> From: Quinn Tran <qutran@marvell.com>
> 
> Fix debug print of 64G link speed.
> 

Not really fix .. you are adding 64G speed link.. 

Please fix the commit message

> Signed-off-by: Quinn Tran <qutran@marvell.com>
> Signed-off-by: Nilesh Javali <njavali@marvell.com>
> ---
> drivers/scsi/qla2xxx/qla_isr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index 8d4d174419bb..93ab686c7a30 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -648,7 +648,7 @@ const char *
> qla2x00_get_link_speed_str(struct qla_hw_data *ha, uint16_t speed)
> {
> 	static const char *const link_speeds[] = {
> -		"1", "2", "?", "4", "8", "16", "32", "10"
> +		"1", "2", "?", "4", "8", "16", "32", "64", "10"
> 	};
> #define	QLA_LAST_SPEED (ARRAY_SIZE(link_speeds) - 1)
> 
> -- 
> 2.19.0.rc0
> 

once you fix commit message, you can add 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 8d4d174419bb..93ab686c7a30 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -648,7 +648,7 @@  const char *
 qla2x00_get_link_speed_str(struct qla_hw_data *ha, uint16_t speed)
 {
 	static const char *const link_speeds[] = {
-		"1", "2", "?", "4", "8", "16", "32", "10"
+		"1", "2", "?", "4", "8", "16", "32", "64", "10"
 	};
 #define	QLA_LAST_SPEED (ARRAY_SIZE(link_speeds) - 1)