mbox series

[v3,0/3] Add devicetree support for SDX65 Modem and MTP

Message ID 1635552125-16407-1-git-send-email-quic_vamslank@quicinc.com (mailing list archive)
Headers show
Series Add devicetree support for SDX65 Modem and MTP | expand

Message

Vamsi Krishna Lanka Oct. 30, 2021, 12:02 a.m. UTC
From: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>

Hello,

Changes from v2:
 - Added cmd-db node to the sdx65 dtsi file

Changes from v1:
 - Addressed Bjorn's comments

This series adds devicetree support for Qualcomm SDX65 platform and MTP
board. This series functionally depends on Add Pdc, GCC and RPMh Clock support
series [1] and Add pinctrl support for SDX65 [2] which are under review.

With this current devicetree support, the MTP can boot into initramfs
shell.

Thanks,
Vamsi

Vamsi krishna Lanka (3):
  dt-bindings: arm: qcom: Document SDX65 platform and boards
  ARM: dts: qcom: Add SDX65 platform and MTP board support
  ARM: dts: qcom: sdx65: Add pincontrol node

 Documentation/devicetree/bindings/arm/qcom.yaml |   6 +
 arch/arm/boot/dts/Makefile                      |   3 +-
 arch/arm/boot/dts/qcom-sdx65-mtp.dts            |  25 +++
 arch/arm/boot/dts/qcom-sdx65.dtsi               | 222 ++++++++++++++++++++++++
 4 files changed, 255 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/qcom-sdx65-mtp.dts
 create mode 100644 arch/arm/boot/dts/qcom-sdx65.dtsi

Comments

Vamsi Krishna Lanka Dec. 2, 2021, 12:34 a.m. UTC | #1
On Fri, Oct 29, 2021 at 05:02:02PM -0700, quic_vamslank@quicinc.com wrote:
> From: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
> 
> Hello,
> 
> Changes from v2:
>  - Added cmd-db node to the sdx65 dtsi file
> 
> Changes from v1:
>  - Addressed Bjorn's comments
> 
> This series adds devicetree support for Qualcomm SDX65 platform and MTP
> board. This series functionally depends on Add Pdc, GCC and RPMh Clock support
> series [1] and Add pinctrl support for SDX65 [2] which are under review.
> 
> With this current devicetree support, the MTP can boot into initramfs
> shell.
> 
> Thanks,
> Vamsi

Can you please review this patch series. It's been pending since longtime now.

Thanks,
Vamsi
> 
> Vamsi krishna Lanka (3):
>   dt-bindings: arm: qcom: Document SDX65 platform and boards
>   ARM: dts: qcom: Add SDX65 platform and MTP board support
>   ARM: dts: qcom: sdx65: Add pincontrol node
> 
>  Documentation/devicetree/bindings/arm/qcom.yaml |   6 +
>  arch/arm/boot/dts/Makefile                      |   3 +-
>  arch/arm/boot/dts/qcom-sdx65-mtp.dts            |  25 +++
>  arch/arm/boot/dts/qcom-sdx65.dtsi               | 222 ++++++++++++++++++++++++
>  4 files changed, 255 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/boot/dts/qcom-sdx65-mtp.dts
>  create mode 100644 arch/arm/boot/dts/qcom-sdx65.dtsi
> 
> -- 
> 2.7.4
>
Bjorn Andersson Dec. 15, 2021, 10:27 p.m. UTC | #2
On Fri, 29 Oct 2021 17:02:02 -0700, quic_vamslank@quicinc.com wrote:
> From: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
> 
> Hello,
> 
> Changes from v2:
>  - Added cmd-db node to the sdx65 dtsi file
> 
> [...]

Applied, thanks!

[1/3] dt-bindings: arm: qcom: Document SDX65 platform and boards
      commit: 3b338c9a6a2afd6db46d5d8e39ae4f5eef420bf8
[2/3] ARM: dts: qcom: Add SDX65 platform and MTP board support
      commit: bae2f5979c6e537334c9099013b5407019e88c44
[3/3] ARM: dts: qcom: sdx65: Add pincontrol node
      commit: ff8b573a6ccf4deba10285abef072c577099e038

Best regards,
Stanislav Jakubek Dec. 23, 2021, 2:44 p.m. UTC | #3
Hi Bjorn, it seems to me like a patch similar to Patch 1/3 was applied
some time ago, see 61339f368d59d25e22401731f89de44e3215508b, and applying
this patch has caused the compatible to be documented twice.

Stanislav
Bjorn Andersson Dec. 23, 2021, 3:45 p.m. UTC | #4
On Thu 23 Dec 06:44 PST 2021, Stanislav Jakubek wrote:

> Hi Bjorn, it seems to me like a patch similar to Patch 1/3 was applied
> some time ago, see 61339f368d59d25e22401731f89de44e3215508b, and applying
> this patch has caused the compatible to be documented twice.
> 

I'm confused to why git allowed me to merge patch 1 without complaining,
but that obviously shouldn't have been merged twice. Thanks for
reporting this!

Let's clean that up, would you be interested in submitting a patch for
it?

Regards,
Bjorn