mbox series

[0/5] vexpress: modularize power reset driver

Message ID 20200527112608.3886105-1-anders.roxell@linaro.org (mailing list archive)
Headers show
Series vexpress: modularize power reset driver | expand

Message

Anders Roxell May 27, 2020, 11:26 a.m. UTC 
Hi,

This patchset contains a bugfixe, a cleanup and fixes allmodconfig build breakages
on arm and arm64. Also making the vexpress power reset driver a module.

Cheers,
Anders

Anders Roxell (5):
  power: vexpress: add suppress_bind_attrs to true
  power: vexpress: cleanup: use builtin_platform_driver
  Revert "ARM: vexpress: Don't select VEXPRESS_CONFIG"
  power: reset: vexpress: fix build issue
  power: vexpress: make the reset driver a module

 arch/arm/mach-vexpress/Kconfig          | 2 +-
 drivers/power/reset/Kconfig             | 3 ++-
 drivers/power/reset/vexpress-poweroff.c | 8 +++++++-
 3 files changed, 10 insertions(+), 3 deletions(-)

Comments

Rob Herring May 27, 2020, 1:34 p.m. UTC | #1 
On Wed, May 27, 2020 at 5:26 AM Anders Roxell <anders.roxell@linaro.org> wrote:
>
> Hi,
>
> This patchset contains a bugfixe, a cleanup and fixes allmodconfig build breakages
> on arm and arm64. Also making the vexpress power reset driver a module.
>
> Cheers,
> Anders
>
> Anders Roxell (5):
>   power: vexpress: add suppress_bind_attrs to true
>   power: vexpress: cleanup: use builtin_platform_driver
>   Revert "ARM: vexpress: Don't select VEXPRESS_CONFIG"
>   power: reset: vexpress: fix build issue
>   power: vexpress: make the reset driver a module

IMO, patches 3 and 4 should be applied to fix the kconfig issues.
Making the driver a module can be addressed separately.

Rob
Arnd Bergmann May 28, 2020, 10:34 a.m. UTC | #2 
On Wed, May 27, 2020 at 3:35 PM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, May 27, 2020 at 5:26 AM Anders Roxell <anders.roxell@linaro.org> wrote:
> >
> > Hi,
> >
> > This patchset contains a bugfixe, a cleanup and fixes allmodconfig build breakages
> > on arm and arm64. Also making the vexpress power reset driver a module.
> >
> > Cheers,
> > Anders
> >
> > Anders Roxell (5):
> >   power: vexpress: add suppress_bind_attrs to true
> >   power: vexpress: cleanup: use builtin_platform_driver
> >   Revert "ARM: vexpress: Don't select VEXPRESS_CONFIG"
> >   power: reset: vexpress: fix build issue
> >   power: vexpress: make the reset driver a module
>
> IMO, patches 3 and 4 should be applied to fix the kconfig issues.
> Making the driver a module can be addressed separately.

I've applied patches 1 through 4 now but left the last one.

If we can find someone to write and test a .remove callback,
I'll prefer that for v5.9, otherwise I'd consider taking Anders'
version instead.

     Arnd