| Message ID | 20230416101624.15866-1-aweber.kernel@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Re-introduce Exynos4212 support and add Samsung Galaxy Tab 3 8.0 boards | expand |
On 16/04/2023 12:16, Artur Weber wrote: > This patches re-introduces the Exynos4212 platform and adds support > for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it: > > - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) > - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) > - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) > > What works: > > - Display and backlight > - Touchscreen (without touchkeys) > - GPIO buttons, hall sensor > - WiFi and Bluetooth > - USB, fuel gauge, charging (partial) > - Accelerometer and magnetometer > - WiFi model only: light sensor This patchset depends on "[PATCH 0/3] Add Samsung S6D7AA0 panel controller driver" for the display panel support for the Samsung Galaxy 3 8.0 boards. > > Signed-off-by: Artur Weber <aweber.kernel@gmail.com> > > Artur Weber (12): > dt-bindings: soc: samsung: add Exynos4212 PMU compatible > dt-bindings: clock: add Exynos4212 clock compatible > ARM: exynos: Re-introduce Exynos4212 support > soc: samsung: Re-introduce Exynos4212 support > clk: samsung: Add Exynos4212 compatible to CLKOUT driver > clk: samsung: Re-add support for Exynos4212 CPU clock > Revert "media: exynos4-is: Remove dependency on obsolete SoC support" > Revert "phy: Remove SOC_EXYNOS4212 dep. from PHY_EXYNOS4X12_USB" > ARM: dts: Move common Exynos4x12 definitions to exynos4x12.dtsi > ARM: dts: Re-introduce Exynos4212 DTSI > dt-bindings: arm: samsung: Add Samsung Galaxy Tab3 family boards > ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards > > .../bindings/arm/samsung/samsung-boards.yaml | 10 + > .../bindings/clock/samsung,exynos-clock.yaml | 1 + > .../bindings/soc/samsung/exynos-pmu.yaml | 3 + > arch/arm/boot/dts/Makefile | 3 + > arch/arm/boot/dts/exynos4212-tab3-3g8.dts | 30 + > arch/arm/boot/dts/exynos4212-tab3-lte8.dts | 43 + > arch/arm/boot/dts/exynos4212-tab3-wifi8.dts | 25 + > arch/arm/boot/dts/exynos4212-tab3.dtsi | 1175 +++++++++++++++++ > arch/arm/boot/dts/exynos4212.dtsi | 157 +++ > arch/arm/boot/dts/exynos4412.dtsi | 645 +-------- > ...2-pinctrl.dtsi => exynos4x12-pinctrl.dtsi} | 4 +- > arch/arm/boot/dts/exynos4x12.dtsi | 665 ++++++++++ > arch/arm/mach-exynos/Kconfig | 5 + > arch/arm/mach-exynos/common.h | 8 + > arch/arm/mach-exynos/exynos.c | 2 + > arch/arm/mach-exynos/firmware.c | 8 +- > arch/arm/mach-exynos/pm.c | 2 +- > arch/arm/mach-exynos/suspend.c | 4 + > drivers/clk/samsung/clk-exynos-clkout.c | 3 + > drivers/clk/samsung/clk-exynos4.c | 44 +- > .../media/platform/samsung/exynos4-is/Kconfig | 2 +- > .../platform/samsung/exynos4-is/fimc-core.c | 2 +- > .../platform/samsung/exynos4-is/fimc-lite.c | 2 +- > drivers/phy/samsung/Kconfig | 2 +- > drivers/soc/samsung/exynos-pmu.c | 9 + > drivers/soc/samsung/exynos-pmu.h | 2 + > drivers/soc/samsung/exynos4-pmu.c | 13 +- > 27 files changed, 2213 insertions(+), 656 deletions(-) > create mode 100644 arch/arm/boot/dts/exynos4212-tab3-3g8.dts > create mode 100644 arch/arm/boot/dts/exynos4212-tab3-lte8.dts > create mode 100644 arch/arm/boot/dts/exynos4212-tab3-wifi8.dts > create mode 100644 arch/arm/boot/dts/exynos4212-tab3.dtsi > create mode 100644 arch/arm/boot/dts/exynos4212.dtsi > rename arch/arm/boot/dts/{exynos4412-pinctrl.dtsi => exynos4x12-pinctrl.dtsi} (99%) > create mode 100644 arch/arm/boot/dts/exynos4x12.dtsi >
On 16/04/2023 12:26, Artur Weber wrote: > On 16/04/2023 12:16, Artur Weber wrote: >> This patches re-introduces the Exynos4212 platform and adds support >> for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it: >> >> - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) >> - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) >> - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) >> >> What works: >> >> - Display and backlight >> - Touchscreen (without touchkeys) >> - GPIO buttons, hall sensor >> - WiFi and Bluetooth >> - USB, fuel gauge, charging (partial) >> - Accelerometer and magnetometer >> - WiFi model only: light sensor > > This patchset depends on "[PATCH 0/3] Add Samsung S6D7AA0 panel > controller driver" for the display panel support for the Samsung Galaxy > 3 8.0 boards. Why? DTS and ARM code cannot depend on driver changes. Please rework your patchsets to remove any of such dependencies. Best regards, Krzysztof
On 16/04/2023 12:34, Krzysztof Kozlowski wrote: > On 16/04/2023 12:26, Artur Weber wrote: >> On 16/04/2023 12:16, Artur Weber wrote: >>> This patches re-introduces the Exynos4212 platform and adds support >>> for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it: >>> >>> - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) >>> - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) >>> - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) >>> >>> What works: >>> >>> - Display and backlight >>> - Touchscreen (without touchkeys) >>> - GPIO buttons, hall sensor >>> - WiFi and Bluetooth >>> - USB, fuel gauge, charging (partial) >>> - Accelerometer and magnetometer >>> - WiFi model only: light sensor >> >> This patchset depends on "[PATCH 0/3] Add Samsung S6D7AA0 panel >> controller driver" for the display panel support for the Samsung Galaxy >> 3 8.0 boards. > > Why? DTS and ARM code cannot depend on driver changes. Please rework > your patchsets to remove any of such dependencies. Ah, that makes sense. I'll re-send the patchset in a second with the panel node removed. Best regards Artur Weber
On 16/04/2023 12:49, Artur Weber wrote: > On 16/04/2023 12:34, Krzysztof Kozlowski wrote: >> On 16/04/2023 12:26, Artur Weber wrote: >>> On 16/04/2023 12:16, Artur Weber wrote: >>>> This patches re-introduces the Exynos4212 platform and adds support >>>> for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it: >>>> >>>> - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) >>>> - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) >>>> - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) >>>> >>>> What works: >>>> >>>> - Display and backlight >>>> - Touchscreen (without touchkeys) >>>> - GPIO buttons, hall sensor >>>> - WiFi and Bluetooth >>>> - USB, fuel gauge, charging (partial) >>>> - Accelerometer and magnetometer >>>> - WiFi model only: light sensor >>> >>> This patchset depends on "[PATCH 0/3] Add Samsung S6D7AA0 panel >>> controller driver" for the display panel support for the Samsung Galaxy >>> 3 8.0 boards. >> >> Why? DTS and ARM code cannot depend on driver changes. Please rework >> your patchsets to remove any of such dependencies. > > Ah, that makes sense. I'll re-send the patchset in a second with the > panel node removed. I am sorry, I don't understand. Why would you remove anything from DTS? Are bindings NAKed? Best regards, Krzysztof
On 16/04/2023 12:53, Krzysztof Kozlowski wrote: > On 16/04/2023 12:49, Artur Weber wrote: >> On 16/04/2023 12:34, Krzysztof Kozlowski wrote: >>> On 16/04/2023 12:26, Artur Weber wrote: >>>> On 16/04/2023 12:16, Artur Weber wrote: >>>>> This patches re-introduces the Exynos4212 platform and adds support >>>>> for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it: >>>>> >>>>> - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) >>>>> - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) >>>>> - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) >>>>> >>>>> What works: >>>>> >>>>> - Display and backlight >>>>> - Touchscreen (without touchkeys) >>>>> - GPIO buttons, hall sensor >>>>> - WiFi and Bluetooth >>>>> - USB, fuel gauge, charging (partial) >>>>> - Accelerometer and magnetometer >>>>> - WiFi model only: light sensor >>>> >>>> This patchset depends on "[PATCH 0/3] Add Samsung S6D7AA0 panel >>>> controller driver" for the display panel support for the Samsung Galaxy >>>> 3 8.0 boards. >>> >>> Why? DTS and ARM code cannot depend on driver changes. Please rework >>> your patchsets to remove any of such dependencies. >> >> Ah, that makes sense. I'll re-send the patchset in a second with the >> panel node removed. > > I am sorry, I don't understand. Why would you remove anything from DTS? > Are bindings NAKed? The dependency display panel patchset introduces the panel and its bindings, which in turn are included in the Tab3 DTSI. It was submitted at roughly the same time as this series, and hasn't been fully reviewed or merged as of writing. (I have seen your comments on that patchset, and I will be addressing them shortly.) So the bindings haven't been explicitly ACKed yet (assuming you mean the Acked-by reply). In response to: > Please rework your patchsets to remove any of such dependencies. I suggested that I could remove the panel node from the DTSI for the time being. The intent was to submit it in a separate patch later, once the display is reviewed/merged, and thus actually available in the kernel; this way, the two patches could be reviewed and merged separately. I could instead wait for the display patchset to get reviewed/merged first, then resubmit this series, if that's preferable. I apologize for the confusion. Best regards, Artur Weber
On 16/04/2023 14:37, Artur Weber wrote: > On 16/04/2023 12:53, Krzysztof Kozlowski wrote: >> On 16/04/2023 12:49, Artur Weber wrote: >>> On 16/04/2023 12:34, Krzysztof Kozlowski wrote: >>>> On 16/04/2023 12:26, Artur Weber wrote: >>>>> On 16/04/2023 12:16, Artur Weber wrote: >>>>>> This patches re-introduces the Exynos4212 platform and adds support >>>>>> for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it: >>>>>> >>>>>> - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) >>>>>> - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) >>>>>> - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) >>>>>> >>>>>> What works: >>>>>> >>>>>> - Display and backlight >>>>>> - Touchscreen (without touchkeys) >>>>>> - GPIO buttons, hall sensor >>>>>> - WiFi and Bluetooth >>>>>> - USB, fuel gauge, charging (partial) >>>>>> - Accelerometer and magnetometer >>>>>> - WiFi model only: light sensor >>>>> >>>>> This patchset depends on "[PATCH 0/3] Add Samsung S6D7AA0 panel >>>>> controller driver" for the display panel support for the Samsung Galaxy >>>>> 3 8.0 boards. >>>> >>>> Why? DTS and ARM code cannot depend on driver changes. Please rework >>>> your patchsets to remove any of such dependencies. >>> >>> Ah, that makes sense. I'll re-send the patchset in a second with the >>> panel node removed. >> >> I am sorry, I don't understand. Why would you remove anything from DTS? >> Are bindings NAKed? > > The dependency display panel patchset introduces the panel and its > bindings, which in turn are included in the Tab3 DTSI. It was submitted > at roughly the same time as this series, and hasn't been fully reviewed > or merged as of writing. (I have seen your comments on that patchset, > and I will be addressing them shortly.) So the bindings haven't been > explicitly ACKed yet (assuming you mean the Acked-by reply). So there is no dependency. DTS is (and must be) independent of driver. You need to mention in the patch (under --- ) or cover letter that it uses new bindings which are documented under the given link. > > In response to: > > > Please rework your patchsets to remove any of such dependencies. > > I suggested that I could remove the panel node from the DTSI for the > time being. The intent was to submit it in a separate patch later, once > the display is reviewed/merged, and thus actually available in the > kernel; this way, the two patches could be reviewed and merged separately. No need, there is no dependency. Just remove such remarks from cover letter. Best regards, Krzysztof
This patches re-introduces the Exynos4212 platform and adds support for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it: - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) What works: - Display and backlight - Touchscreen (without touchkeys) - GPIO buttons, hall sensor - WiFi and Bluetooth - USB, fuel gauge, charging (partial) - Accelerometer and magnetometer - WiFi model only: light sensor Signed-off-by: Artur Weber <aweber.kernel@gmail.com> Artur Weber (12): dt-bindings: soc: samsung: add Exynos4212 PMU compatible dt-bindings: clock: add Exynos4212 clock compatible ARM: exynos: Re-introduce Exynos4212 support soc: samsung: Re-introduce Exynos4212 support clk: samsung: Add Exynos4212 compatible to CLKOUT driver clk: samsung: Re-add support for Exynos4212 CPU clock Revert "media: exynos4-is: Remove dependency on obsolete SoC support" Revert "phy: Remove SOC_EXYNOS4212 dep. from PHY_EXYNOS4X12_USB" ARM: dts: Move common Exynos4x12 definitions to exynos4x12.dtsi ARM: dts: Re-introduce Exynos4212 DTSI dt-bindings: arm: samsung: Add Samsung Galaxy Tab3 family boards ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards .../bindings/arm/samsung/samsung-boards.yaml | 10 + .../bindings/clock/samsung,exynos-clock.yaml | 1 + .../bindings/soc/samsung/exynos-pmu.yaml | 3 + arch/arm/boot/dts/Makefile | 3 + arch/arm/boot/dts/exynos4212-tab3-3g8.dts | 30 + arch/arm/boot/dts/exynos4212-tab3-lte8.dts | 43 + arch/arm/boot/dts/exynos4212-tab3-wifi8.dts | 25 + arch/arm/boot/dts/exynos4212-tab3.dtsi | 1175 +++++++++++++++++ arch/arm/boot/dts/exynos4212.dtsi | 157 +++ arch/arm/boot/dts/exynos4412.dtsi | 645 +-------- ...2-pinctrl.dtsi => exynos4x12-pinctrl.dtsi} | 4 +- arch/arm/boot/dts/exynos4x12.dtsi | 665 ++++++++++ arch/arm/mach-exynos/Kconfig | 5 + arch/arm/mach-exynos/common.h | 8 + arch/arm/mach-exynos/exynos.c | 2 + arch/arm/mach-exynos/firmware.c | 8 +- arch/arm/mach-exynos/pm.c | 2 +- arch/arm/mach-exynos/suspend.c | 4 + drivers/clk/samsung/clk-exynos-clkout.c | 3 + drivers/clk/samsung/clk-exynos4.c | 44 +- .../media/platform/samsung/exynos4-is/Kconfig | 2 +- .../platform/samsung/exynos4-is/fimc-core.c | 2 +- .../platform/samsung/exynos4-is/fimc-lite.c | 2 +- drivers/phy/samsung/Kconfig | 2 +- drivers/soc/samsung/exynos-pmu.c | 9 + drivers/soc/samsung/exynos-pmu.h | 2 + drivers/soc/samsung/exynos4-pmu.c | 13 +- 27 files changed, 2213 insertions(+), 656 deletions(-) create mode 100644 arch/arm/boot/dts/exynos4212-tab3-3g8.dts create mode 100644 arch/arm/boot/dts/exynos4212-tab3-lte8.dts create mode 100644 arch/arm/boot/dts/exynos4212-tab3-wifi8.dts create mode 100644 arch/arm/boot/dts/exynos4212-tab3.dtsi create mode 100644 arch/arm/boot/dts/exynos4212.dtsi rename arch/arm/boot/dts/{exynos4412-pinctrl.dtsi => exynos4x12-pinctrl.dtsi} (99%) create mode 100644 arch/arm/boot/dts/exynos4x12.dtsi