| Message ID | 20240418121116.22184-1-kabel@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Turris Omnia MCU driver | expand |
On Thu, Apr 18, 2024 at 02:11:05PM +0200, Marek Behún wrote: > Hello Andy, Dan, Linus, Arnd, Gregory, and others, > > I am sending v6 of the series adding Turris Omnia MCU driver. > > This series depends on the immutable branch between LEDs and locking, > introducing devm_mutex_init(), see the PR > https://lore.kernel.org/linux-leds/20240412084616.GR2399047@google.com/ ... > devm-helpers: Add resource managed version of irq_create_mapping() > devm-helpers: Add resource managed version of debugfs directory create > function IIUC you created them as static inline, the header will become yet another cumbersome and messy "kernel.h". Can we prevent that?
Hello Andy, Dan, Linus, Arnd, Gregory, and others, I am sending v6 of the series adding Turris Omnia MCU driver. This series depends on the immutable branch between LEDs and locking, introducing devm_mutex_init(), see the PR https://lore.kernel.org/linux-leds/20240412084616.GR2399047@google.com/ See the cover letters for v1, v2, v3, v4 and v5: https://patchwork.kernel.org/project/linux-soc/cover/20230823161012.6986-1-kabel@kernel.org/ https://patchwork.kernel.org/project/linux-soc/cover/20230919103815.16818-1-kabel@kernel.org/ https://patchwork.kernel.org/project/linux-soc/cover/20231023143130.11602-1-kabel@kernel.org/ https://patchwork.kernel.org/project/linux-soc/cover/20231026161803.16750-1-kabel@kernel.org/ https://patchwork.kernel.org/project/linux-soc/cover/20240323164359.21642-1-kabel@kernel.org/ Changes since v5: - use dev_get_drvdata(dev) instead of i2c_get_clientdata(to_i2c_client(dev)) - uses devm_mutex_init() from the above mentioned branch - addressed Andy's suggestions for patch 2 (excluding the one suggesting 100 column lines, I still prefer 80 columns) - addressed Dan's suggestion for devm_irq_create_mapping() (return -ENXIO if mapping could not be created, not 0 as irq_create_mapping() does) - I threw away the changes for other drivers that came with the new devm_ helpers, notably conversion to devm_debugfs_create_dir(), as there were some problems Marek Behún (11): dt-bindings: arm: add cznic,turris-omnia-mcu binding platform: cznic: Add preliminary support for Turris Omnia MCU platform: cznic: turris-omnia-mcu: Add support for MCU connected GPIOs platform: cznic: turris-omnia-mcu: Add support for poweroff and wakeup platform: cznic: turris-omnia-mcu: Add support for MCU watchdog devm-helpers: Add resource managed version of irq_create_mapping() platform: cznic: turris-omnia-mcu: Add support for MCU provided TRNG devm-helpers: Add resource managed version of debugfs directory create function platform: cznic: turris-omnia-mcu: Add support for digital message signing via debugfs ARM: dts: turris-omnia: Add MCU system-controller node ARM: dts: turris-omnia: Add GPIO key node for front button .../ABI/testing/debugfs-turris-omnia-mcu | 13 + .../sysfs-bus-i2c-devices-turris-omnia-mcu | 126 ++ .../bindings/arm/cznic,turris-omnia-mcu.yaml | 86 ++ MAINTAINERS | 5 + .../dts/marvell/armada-385-turris-omnia.dts | 35 +- drivers/platform/Kconfig | 2 + drivers/platform/Makefile | 1 + drivers/platform/cznic/Kconfig | 51 + drivers/platform/cznic/Makefile | 9 + .../platform/cznic/turris-omnia-mcu-base.c | 439 +++++++ .../platform/cznic/turris-omnia-mcu-debugfs.c | 209 ++++ .../platform/cznic/turris-omnia-mcu-gpio.c | 1047 +++++++++++++++++ .../cznic/turris-omnia-mcu-sys-off-wakeup.c | 258 ++++ .../platform/cznic/turris-omnia-mcu-trng.c | 89 ++ .../cznic/turris-omnia-mcu-watchdog.c | 123 ++ drivers/platform/cznic/turris-omnia-mcu.h | 188 +++ include/linux/devm-helpers.h | 94 ++ include/linux/turris-omnia-mcu-interface.h | 249 ++++ 18 files changed, 3023 insertions(+), 1 deletion(-) create mode 100644 Documentation/ABI/testing/debugfs-turris-omnia-mcu create mode 100644 Documentation/ABI/testing/sysfs-bus-i2c-devices-turris-omnia-mcu create mode 100644 Documentation/devicetree/bindings/arm/cznic,turris-omnia-mcu.yaml create mode 100644 drivers/platform/cznic/Kconfig create mode 100644 drivers/platform/cznic/Makefile create mode 100644 drivers/platform/cznic/turris-omnia-mcu-base.c create mode 100644 drivers/platform/cznic/turris-omnia-mcu-debugfs.c create mode 100644 drivers/platform/cznic/turris-omnia-mcu-gpio.c create mode 100644 drivers/platform/cznic/turris-omnia-mcu-sys-off-wakeup.c create mode 100644 drivers/platform/cznic/turris-omnia-mcu-trng.c create mode 100644 drivers/platform/cznic/turris-omnia-mcu-watchdog.c create mode 100644 drivers/platform/cznic/turris-omnia-mcu.h create mode 100644 include/linux/turris-omnia-mcu-interface.h